fix(env): proxy directly to process.env instead of snapshotting

Env.set/get/all/remove now read and write process.env directly,
fixing the stale snapshot that caused external SDKs to never see
env changes (fixes #12698).

- Remove InstanceState-based snapshot
- Layer.succeed with direct process.env proxy
- Add Env.test() for isolated test environments
- Remove obsolete workaround TODOs in provider.ts

Author: jerome-benoit

packages/opencode/src/env/index.ts

@@ -1,5 +1,4 @@
 import { Context, Effect, Layer } from "effect"
-import { InstanceState } from "@/effect/instance-state"
 import { makeRuntime } from "@/effect/run-service"
 
 export namespace Env {
@@ -14,28 +13,47 @@ export namespace Env {
 
   export class Service extends Context.Service<Service, Interface>()("@opencode/Env") {}
 
-  export const layer = Layer.effect(
+  export const layer = Layer.succeed(
     Service,
-    Effect.gen(function* () {
-      const state = yield* InstanceState.make<State>(Effect.fn("Env.state")(() => Effect.succeed({ ...process.env })))
-
-      const get = Effect.fn("Env.get")((key: string) => InstanceState.use(state, (env) => env[key]))
-      const all = Effect.fn("Env.all")(() => InstanceState.get(state))
-      const set = Effect.fn("Env.set")(function* (key: string, value: string) {
-        const env = yield* InstanceState.get(state)
-        env[key] = value
-      })
-      const remove = Effect.fn("Env.remove")(function* (key: string) {
-        const env = yield* InstanceState.get(state)
-        delete env[key]
-      })
-
-      return Service.of({ get, all, set, remove })
+    Service.of({
+      get: Effect.fn("Env.get")((key: string) => Effect.succeed(process.env[key])),
+      all: Effect.fn("Env.all")(() => Effect.succeed(process.env as State)),
+      set: Effect.fn("Env.set")((key: string, value: string) =>
+        Effect.sync(() => {
+          process.env[key] = value
+        }),
+      ),
+      remove: Effect.fn("Env.remove")((key: string) =>
+        Effect.sync(() => {
+          delete process.env[key]
+        }),
+      ),
     }),
   )
 
   export const defaultLayer = layer
 
+  export function test(initial: State = {}) {
+    const state = { ...initial }
+    return Layer.succeed(
+      Service,
+      Service.of({
+        get: Effect.fn("Env.get")((key: string) => Effect.succeed(state[key])),
+        all: Effect.fn("Env.all")(() => Effect.succeed(state)),
+        set: Effect.fn("Env.set")((key: string, value: string) =>
+          Effect.sync(() => {
+            state[key] = value
+          }),
+        ),
+        remove: Effect.fn("Env.remove")((key: string) =>
+          Effect.sync(() => {
+            delete state[key]
+          }),
+        ),
+      }),
+    )
+  }
+
   const rt = makeRuntime(Service, defaultLayer)
 
   export function get(key: string) {

packages/opencode/src/provider/provider.ts

@@ -287,8 +287,6 @@ export namespace Provider {
 
         const awsAccessKeyId = env["AWS_ACCESS_KEY_ID"]
 
-        // TODO: Using process.env directly because Env.set only updates a process.env shallow copy,
-        // until the scope of the Env API is clarified (test only or runtime?)
         const awsBearerToken = iife(() => {
           const envToken = process.env.AWS_BEARER_TOKEN_BEDROCK
           if (envToken) return envToken
@@ -503,8 +501,6 @@ export namespace Provider {
       }),
       "sap-ai-core": Effect.fnUntraced(function* () {
         const auth = yield* dep.auth("sap-ai-core")
-        // TODO: Using process.env directly because Env.set only updates a shallow copy (not process.env),
-        // until the scope of the Env API is clarified (test only or runtime?)
         const envServiceKey = iife(() => {
           const envAICoreServiceKey = process.env.AICORE_SERVICE_KEY
           if (envAICoreServiceKey) return envAICoreServiceKey