Skip to content

Commit e552211

Browse files
Apply PR #12633: feat(tui): add auto-accept mode for permission requests
2 parents 4fd693f + 5792a80 commit e552211

6 files changed

Lines changed: 37 additions & 5 deletions

File tree

packages/opencode/src/agent/agent.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ export const layer = Layer.effect(
9797
question: "deny",
9898
plan_enter: "deny",
9999
plan_exit: "deny",
100+
edit: "ask",
100101
// mirrors github.com/github/gitignore Node.gitignore pattern for .env files
101102
read: {
102103
"*": "allow",

packages/opencode/src/cli/cmd/run.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -372,6 +372,11 @@ export const RunCommand = effectCmd({
372372
action: "deny",
373373
pattern: "*",
374374
},
375+
{
376+
permission: "edit",
377+
action: "allow",
378+
pattern: "*",
379+
},
375380
]
376381

377382
function title() {

packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ export function Prompt(props: PromptProps) {
139139
const dimensions = useTerminalDimensions()
140140
const { theme, syntax } = useTheme()
141141
const kv = useKV()
142+
const [autoaccept, setAutoaccept] = kv.signal<"none" | "edit">("permission_auto_accept", "edit")
142143
const animationsEnabled = createMemo(() => kv.get("animations_enabled", true))
143144
const list = createMemo(() => props.placeholders?.normal ?? [])
144145
const shell = createMemo(() => props.placeholders?.shell ?? [])
@@ -383,6 +384,17 @@ export function Prompt(props: PromptProps) {
383384

384385
command.register(() => {
385386
return [
387+
{
388+
title: autoaccept() === "none" ? "Enable autoedit" : "Disable autoedit",
389+
value: "permission.auto_accept.toggle",
390+
search: "toggle permissions",
391+
keybind: "permission_auto_accept_toggle",
392+
category: "Agent",
393+
onSelect: (dialog) => {
394+
setAutoaccept(() => (autoaccept() === "none" ? "edit" : "none"))
395+
dialog.clear()
396+
},
397+
},
386398
{
387399
title: "Clear prompt",
388400
value: "prompt.clear",
@@ -1459,9 +1471,14 @@ export function Prompt(props: PromptProps) {
14591471
)}
14601472
</Show>
14611473
</box>
1462-
<Show when={hasRightContent()}>
1474+
<Show when={hasRightContent() || autoaccept() === "edit"}>
14631475
<box flexDirection="row" gap={1} alignItems="center">
14641476
{props.right}
1477+
<Show when={autoaccept() === "edit"}>
1478+
<text>
1479+
<span style={{ fg: theme.warning }}>autoedit</span>
1480+
</text>
1481+
</Show>
14651482
</box>
14661483
</Show>
14671484
</box>

packages/opencode/src/cli/cmd/tui/context/sync.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
110110
const project = useProject()
111111
const sdk = useSDK()
112112
const kv = useKV()
113+
const [autoaccept] = kv.signal<"none" | "edit">("permission_auto_accept", "edit")
113114

114115
const fullSyncedSessions = new Set<string>()
115116
let syncedWorkspace = project.workspace.current()
@@ -152,6 +153,13 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
152153

153154
case "permission.asked": {
154155
const request = event.properties
156+
if (autoaccept() === "edit" && request.permission === "edit") {
157+
sdk.client.permission.reply({
158+
reply: "once",
159+
requestID: request.id,
160+
})
161+
break
162+
}
155163
const requests = store.permission[request.sessionID]
156164
if (!requests) {
157165
setStore("permission", request.sessionID, [request])

packages/opencode/src/cli/cmd/tui/ui/dialog-select.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export interface DialogSelectOption<T = any> {
3838
title: string
3939
value: T
4040
description?: string
41+
search?: string
4142
footer?: JSX.Element | string
4243
category?: string
4344
categoryView?: JSX.Element
@@ -94,8 +95,8 @@ export function DialogSelect<T>(props: DialogSelectProps<T>) {
9495
// users typically search by the item name, and not its category.
9596
const result = fuzzysort
9697
.go(needle, options, {
97-
keys: ["title", "category"],
98-
scoreFn: (r) => r[0].score * 2 + r[1].score,
98+
keys: ["title", "category", "search"],
99+
scoreFn: (r) => r[0].score * 2 + r[1].score + r[2].score,
99100
})
100101
.map((x) => x.obj)
101102

packages/opencode/test/agent/agent.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ test("agent permission config merges with defaults", async () => {
229229
expect(build).toBeDefined()
230230
// Specific pattern is denied
231231
expect(Permission.evaluate("bash", "rm -rf *", build!.permission).action).toBe("deny")
232-
// Edit still allowed
233-
expect(evalPerm(build, "edit")).toBe("allow")
232+
// Edit uses ask by default
233+
expect(evalPerm(build, "edit")).toBe("ask")
234234
},
235235
})
236236
})

0 commit comments

Comments
 (0)