Revert "Optimize file extension detection performance"

This reverts commit 824962c.

Author: alexyaroshuk

packages/opencode/src/file/index.ts

@@ -204,34 +204,37 @@ export namespace File {
     "x3f",
   ])
 
-  const imageMimeTypes: Record<string, string> = {
-    png: "image/png",
-    jpg: "image/jpeg",
-    jpeg: "image/jpeg",
-    gif: "image/gif",
-    bmp: "image/bmp",
-    webp: "image/webp",
-    ico: "image/x-icon",
-    tif: "image/tiff",
-    tiff: "image/tiff",
-    svg: "image/svg+xml",
-    svgz: "image/svg+xml",
-    avif: "image/avif",
-    apng: "image/apng",
-    jxl: "image/jxl",
-    heic: "image/heic",
-    heif: "image/heif",
+  function isImageByExtension(filepath: string): boolean {
+    const ext = path.extname(filepath).toLowerCase().slice(1)
+    return imageExtensions.has(ext)
   }
 
-  function getFileTypeByExtension(filepath: string): { isImage: boolean; isBinary: boolean; mimeType?: string } {
+  function getImageMimeType(filepath: string): string {
     const ext = path.extname(filepath).toLowerCase().slice(1)
-    if (imageExtensions.has(ext)) {
-      return { isImage: true, isBinary: false, mimeType: imageMimeTypes[ext] || "image/" + ext }
-    }
-    if (binaryExtensions.has(ext)) {
-      return { isImage: false, isBinary: true }
+    const mimeTypes: Record<string, string> = {
+      png: "image/png",
+      jpg: "image/jpeg",
+      jpeg: "image/jpeg",
+      gif: "image/gif",
+      bmp: "image/bmp",
+      webp: "image/webp",
+      ico: "image/x-icon",
+      tif: "image/tiff",
+      tiff: "image/tiff",
+      svg: "image/svg+xml",
+      svgz: "image/svg+xml",
+      avif: "image/avif",
+      apng: "image/apng",
+      jxl: "image/jxl",
+      heic: "image/heic",
+      heif: "image/heif",
     }
-    return { isImage: false, isBinary: false }
+    return mimeTypes[ext] || "image/" + ext
+  }
+
+  function isBinaryByExtension(filepath: string): boolean {
+    const ext = path.extname(filepath).toLowerCase().slice(1)
+    return binaryExtensions.has(ext)
   }
 
   function isImage(mimeType: string): boolean {
@@ -433,19 +436,18 @@ export namespace File {
     }
 
     // Fast path: check extension before any filesystem operations
-    const fileType = getFileTypeByExtension(file)
-
-    if (fileType.isImage) {
+    if (isImageByExtension(file)) {
       const bunFile = Bun.file(full)
       if (await bunFile.exists()) {
         const buffer = await bunFile.arrayBuffer().catch(() => new ArrayBuffer(0))
         const content = Buffer.from(buffer).toString("base64")
-        return { type: "text", content, mimeType: fileType.mimeType, encoding: "base64" }
+        const mimeType = getImageMimeType(file)
+        return { type: "text", content, mimeType, encoding: "base64" }
       }
       return { type: "text", content: "" }
     }
 
-    if (fileType.isBinary) {
+    if (isBinaryByExtension(file)) {
       return { type: "binary", content: "" }
     }