refactor: migrate test inits from Promise to Effect; drop Promise variant

Converts ~60 Instance.provide({init: () => Promise}) call sites in
amazon-bedrock and provider tests to Effect-typed inits via
Effect.promise(...).pipe(Effect.asVoid). Tightens Instance.provide /
Instance.load / Instance.reload signatures to only accept
Effect.Effect<void> for init.

liftLegacyInput still wraps the Effect with ALS bind via context.provide
(through Effect.callback) so legacy code reachable through init that
reads Instance.directory etc. continues to work. The wrap is now the
single remaining bridge; once tests stop reading from ALS in init
bodies, it can be deleted.

Tests: bedrock + provider suites both pass. Pre-existing baseline
failures in session.created.test.ts and project-init-git.test.ts are
unrelated flakes (verified by running on dev's HEAD).

Author: kitlangton

packages/opencode/src/project/instance.ts

@@ -9,23 +9,29 @@ export type { LoadInput } from "./instance-store"
 
 type LegacyLoadInput = {
   directory: string
-  init?: () => Promise<unknown>
+  init?: Effect.Effect<void>
   project?: Project.Info
   worktree?: string
 }
 
-// Promise-style legacy inits often read Instance.directory etc. from the ALS context.
-// The new Effect-typed init path doesn't bind ALS — it provides InstanceRef. To keep
-// legacy inits working without forcing every test to convert, bind ALS around the
-// Promise call here using the instance ctx that the store provides via InstanceRef.
+// Bind ALS around init so legacy code reachable through it (Instance.directory reads, etc.)
+// stays bound. The Effect-typed init also gets InstanceRef provided by the store.
 const liftLegacyInput = (input: LegacyLoadInput): InstanceStore.LoadInput => {
   const { init, ...rest } = input
   if (!init) return rest
   return {
     ...rest,
     init: Effect.gen(function* () {
       const ctx = yield* InstanceRef
-      yield* Effect.promise(() => (ctx ? context.provide(ctx, init) : init()))
+      if (!ctx) return yield* init
+      yield* Effect.callback<void>((resume) => {
+        context.provide(ctx, () => {
+          Effect.runPromise(init).then(
+            () => resume(Effect.void),
+            (err) => resume(Effect.die(err)),
+          )
+        })
+      })
     }),
   }
 }
@@ -34,7 +40,7 @@ export const Instance = {
   load(input: LegacyLoadInput): Promise<InstanceContext> {
     return InstanceStore.runtime.runPromise((store) => store.load(liftLegacyInput(input)))
   },
-  async provide<R>(input: { directory: string; init?: () => Promise<unknown>; fn: () => R }): Promise<R> {
+  async provide<R>(input: { directory: string; init?: Effect.Effect<void>; fn: () => R }): Promise<R> {
     return context.provide(
       await Instance.load({ directory: input.directory, init: input.init }),
       async () => input.fn(),

packages/opencode/test/provider/amazon-bedrock.test.ts

@@ -45,10 +45,10 @@ test("Bedrock: config region takes precedence over AWS_REGION env var", async ()
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_REGION", "us-east-1")
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -70,10 +70,10 @@ test("Bedrock: falls back to AWS_REGION env var when no config region", async ()
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_REGION", "eu-west-1")
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -125,11 +125,11 @@ test("Bedrock: loads when bearer token from auth.json is present", async () => {
 
     await Instance.provide({
       directory: tmp.path,
-      init: async () => {
+      init: Effect.promise(async () => {
         set("AWS_PROFILE", "")
         set("AWS_ACCESS_KEY_ID", "")
         set("AWS_BEARER_TOKEN_BEDROCK", "")
-      },
+      }).pipe(Effect.asVoid),
       fn: async () => {
         const providers = await list()
         expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -171,10 +171,10 @@ test("Bedrock: config profile takes precedence over AWS_PROFILE env var", async
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_PROFILE", "default")
       set("AWS_ACCESS_KEY_ID", "test-key-id")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -203,9 +203,9 @@ test("Bedrock: includes custom endpoint in options when specified", async () =>
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -236,12 +236,12 @@ test("Bedrock: autoloads when AWS_WEB_IDENTITY_TOKEN_FILE is present", async ()
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_WEB_IDENTITY_TOKEN_FILE", "/var/run/secrets/eks.amazonaws.com/serviceaccount/token")
       set("AWS_ROLE_ARN", "arn:aws:iam::123456789012:role/my-eks-role")
       set("AWS_PROFILE", "")
       set("AWS_ACCESS_KEY_ID", "")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -279,9 +279,9 @@ test("Bedrock: model with us. prefix should not be double-prefixed", async () =>
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -316,9 +316,9 @@ test("Bedrock: model with global. prefix should not be prefixed", async () => {
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -352,9 +352,9 @@ test("Bedrock: model with eu. prefix should not be double-prefixed", async () =>
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()
@@ -388,9 +388,9 @@ test("Bedrock: model without prefix in US region should get us. prefix added", a
   })
   await Instance.provide({
     directory: tmp.path,
-    init: async () => {
+    init: Effect.promise(async () => {
       set("AWS_PROFILE", "default")
-    },
+    }).pipe(Effect.asVoid),
     fn: async () => {
       const providers = await list()
       expect(providers[ProviderID.amazonBedrock]).toBeDefined()