fix(app): detach cached project state from Solid proxies

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <[email protected]>

Author: GuestAUser

packages/app/src/context/global-sync/utils.test.ts

@@ -1,6 +1,7 @@
 import { describe, expect, test } from "bun:test"
-import type { Agent } from "@opencode-ai/sdk/v2/client"
-import { normalizeAgentList } from "./utils"
+import type { Agent, Project } from "@opencode-ai/sdk/v2/client"
+import { createStore } from "solid-js/store"
+import { normalizeAgentList, sanitizeProject } from "./utils"
 
 const agent = (name = "build") =>
   ({
@@ -33,3 +34,57 @@ describe("normalizeAgentList", () => {
     expect(normalizeAgentList([{ name: "build" }, agent("docs")])).toEqual([agent("docs")])
   })
 })
+
+describe("sanitizeProject", () => {
+  test("clones nested project data and strips cached icon urls", () => {
+    const [store] = createStore({
+      value: {
+        id: "proj_1",
+        worktree: "/tmp/project",
+        name: "Project",
+        icon: {
+          url: "https://example.com/icon.png",
+          override: "data:image/png;base64,abc",
+          color: "pink",
+        },
+        commands: {
+          start: "bun dev",
+        },
+        time: {
+          created: 1,
+          updated: 2,
+        },
+        sandboxes: ["/tmp/project-a"],
+      } satisfies Project,
+    })
+
+    const next = sanitizeProject(store.value)
+
+    expect(next).not.toBe(store.value)
+    expect(next.time).not.toBe(store.value.time)
+    expect(next.sandboxes).not.toBe(store.value.sandboxes)
+    expect(next.commands).not.toBe(store.value.commands)
+    expect(next.icon).not.toBe(store.value.icon)
+    expect(next.icon?.url).toBeUndefined()
+    expect(next.icon?.override).toBeUndefined()
+    expect(next.icon?.color).toBe("pink")
+
+    next.sandboxes.push("/tmp/project-b")
+    expect(store.value.sandboxes).toEqual(["/tmp/project-a"])
+  })
+
+  test("returns a detached copy even without icon overrides", () => {
+    const project = {
+      id: "proj_2",
+      worktree: "/tmp/project-2",
+      time: { created: 1, updated: 1 },
+      sandboxes: [],
+    } satisfies Project
+
+    const next = sanitizeProject(project)
+
+    expect(next).not.toBe(project)
+    expect(next.time).not.toBe(project.time)
+    expect(next.sandboxes).not.toBe(project.sandboxes)
+  })
+})

packages/app/src/context/global-sync/utils.ts

@@ -27,13 +27,19 @@ export function normalizeProviderList(input: ProviderListResponse): ProviderList
 }
 
 export function sanitizeProject(project: Project) {
-  if (!project.icon?.url && !project.icon?.override) return project
   return {
     ...project,
-    icon: {
-      ...project.icon,
-      url: undefined,
-      override: undefined,
-    },
+    time: { ...project.time },
+    sandboxes: [...project.sandboxes],
+    ...(project.commands ? { commands: { ...project.commands } } : {}),
+    ...(project.icon
+      ? {
+          icon: {
+            ...project.icon,
+            url: undefined,
+            override: undefined,
+          },
+        }
+      : {}),
   }
 }