Skip to content

Commit 785f358

Browse files
authored
fix: add keyed prop to Show components for proper reactivity (#23935)
1 parent a419f1c commit 785f358

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/app/src/pages/layout/sidebar-items.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -269,10 +269,10 @@ export const SessionItem = (props: SessionItemProps): JSX.Element => {
269269
</Show>
270270
</div>
271271
</div>
272-
<Show when={currentChild()}>
272+
<Show when={currentChild()} keyed>
273273
{(child) => (
274274
<div class="w-full">
275-
<SessionItem {...props} session={child()} level={(props.level ?? 0) + 1} />
275+
<SessionItem {...props} session={child} level={(props.level ?? 0) + 1} />
276276
</div>
277277
)}
278278
</Show>

packages/app/src/pages/session/message-timeline.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -812,7 +812,7 @@ export function MessageTimeline(props: {
812812
</Show>
813813
</div>
814814
</div>
815-
<Show when={sessionID()}>
815+
<Show when={sessionID()} keyed>
816816
{(id) => (
817817
<div class="shrink-0 flex items-center gap-3">
818818
<SessionContextUsage placement="bottom" />
@@ -878,12 +878,12 @@ export function MessageTimeline(props: {
878878
</DropdownMenu.ItemLabel>
879879
</DropdownMenu.Item>
880880
</Show>
881-
<DropdownMenu.Item onSelect={() => void archiveSession(id())}>
881+
<DropdownMenu.Item onSelect={() => void archiveSession(id)}>
882882
<DropdownMenu.ItemLabel>{language.t("common.archive")}</DropdownMenu.ItemLabel>
883883
</DropdownMenu.Item>
884884
<DropdownMenu.Separator />
885885
<DropdownMenu.Item
886-
onSelect={() => dialog.show(() => <DialogDeleteSession sessionID={id()} />)}
886+
onSelect={() => dialog.show(() => <DialogDeleteSession sessionID={id} />)}
887887
>
888888
<DropdownMenu.ItemLabel>{language.t("common.delete")}</DropdownMenu.ItemLabel>
889889
</DropdownMenu.Item>

0 commit comments

Comments
 (0)