Urlbar changes from v146 to v147 (enterSelects.uc.js for v146 working attached).

[iax9123]

[

enterSelects.uc.js

](url)

I have a v146 working enterSelects.uc.js script for those who are able to find out what changed between v146 and v147 which even after updating the reference to moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs to its new location at chrome://browser/content/urlbar/UrlbarInput.mjs still doesn't work (as in it works, but doesn't function correctly).

Testing conditions for running under v146 was simply using MrOtherGuy's fx-autoconfig (boot.sys.mjs version 0.10.11) and was running fine with no errors in the developers console.

https://github.com/MrOtherGuy/fx-autoconfig

Eyeing through some of the differences with code between v146 and v147 suggests quite a few changes in urlbar related modules (besides UrlbarInput.sys.mjs / UrlbarInput.mjs):

moz-src:///browser/components/urlbar/UrlbarController.sys.mjs
moz-src:///browser/components/urlbar/UrlbarUtils.sys.mjs

What I tried:

I put the modules (UrlbarController.sys.mjs, UrlbarUtils.sys.mjs, UrlbarInput.sys.mjs) from v146 omni.ja into the chrome/resources/modules directory and updated the code in enterSelects.uc.js to point to them.

chrome://userchrome/content/modules/UrlbarController.sys.mjs
chrome://userchrome/content/modules/UrlbarInput.sys.mjs
chrome://userchrome/content/modules/UrlbarUtils.sys.mjs

Result:

No errors in developer console, but no sign of functionality. I am at a loss.

[aminomancer]

At a glance, gURLBar.textbox should be replaced with gURLBar. So should gURLBar.inputField, there's no reason to reference that directly anymore, gURLBar has value and event listener APIs on it.

I put the modules (UrlbarController.sys.mjs, UrlbarUtils.sys.mjs, UrlbarInput.sys.mjs) from v146 omni.ja into the chrome/resources/modules directory and updated the code in enterSelects.uc.js to point to them.

That's not how this works. Your script can reference whatever it wants, but the script works by modifying the urlbar modules that are imported and instantiated in the browser. The urlbar that actually exists in the browser is still being imported from the real urls. So all you've done here is duplicate the modules and modify the duplicate instances without anything else referencing or using them. For a script to have any effect on the urlbar, it needs to either A) modify the module instances that firefox is actually using, or B) intercept the chrome module registration so you can set your own files to live at those urls - but this doesn't work with moz-src urls.

But trying to revert modules is not the right way to go about this anyway. Instead of modifying parts of firefox to work with outdated scripts, you should modify the script to work with firefox. It's not really possible to do the former, unless it's a really small thing. But the urlbar is massive. If you successfully revert these modules, Firefox probably crashes, as there are dozens of other modules that reference them and expect them to contain properties that the reverted versions will not have. You would need to update not just the urlbar modules but everything that references any changed property of the urlbar modules. That would be a massive undertaking, far worse than just troubleshooting your script.

No errors in developer console, but no sign of functionality. I am at a loss.

I assume by this you mean there were no errors when you tried to revert the urlbar modules. But just forget that. What's important is what the browser console says when you try to run this script in 147. Leave the modules alone, just make the changes I suggested and run firefox as normal, and see what the console says. That should give you a clue. If what's broken about the script is that a property was redefined, then that's the property you should search for in the patch to see how it changed (and therefore how you need to update your script). That is how I keep things up to date.

But the inputField and textbox references are probably the only issue. I just updated several scripts in this same way.

[iax9123]

I assume by this you mean there were no errors when you tried to revert the urlbar modules

Yes. I do realise that it's the wrong way to go about it and if it were to be fixed this way that it would be not future-proof. It was just my attempt at a quick-fix without having to put the call out for some assistance.

Trying now to continue troubleshooting the code, I can't check to see if the changes to the gURLBar.textbox and gURLBar.inputField references are making any difference yet since I have a stop error when the compiler sees the bottom of the UrlbarInput.mjs module. The error says:

ReferenceError: customElements is not defined UrlbarInput.mjs:5966:1

It's referring to the last line of UrlbarInput.mjs which makes reference to customElements. So when this module is used in other areas of Firefox it has access to where customElements is defined, but not when it's called from within the script? I don't know what to import.

[aminomancer]

Can you share the entire call stack of the error? Does it have an arrow for expanding/collapsing the error?

It sounds to me like your script is importing UrlbarInput before browser-main.js does, and before customElements is set up. These properties are not just declared but defined as soon as the script runs:

  controller: ChromeUtils.importESModule('moz-src:///browser/components/urlbar/UrlbarController.sys.mjs').UrlbarController.prototype,
  eventBuffer: ChromeUtils.importESModule('moz-src:///browser/components/urlbar/UrlbarEventBufferer.sys.mjs').UrlbarEventBufferer.prototype,
  input: ChromeUtils.importESModule('moz-src:///browser/components/urlbar/UrlbarInput.sys.mjs').UrlbarInput.prototype,
  queryContext: ChromeUtils.importESModule('moz-src:///browser/components/urlbar/UrlbarUtils.sys.mjs').UrlbarQueryContext.prototype,

So it's importing UrlbarInput, which causes it to execute, and that module happens to not just be a neutral class or something; it has side effects, including the custom element definition. So UrlbarInput is being imported too early.

What you should probably do is replace these declarations with getters. That way, they won't be imported until something references them. You also shouldn't import UrlbarInput. There's no point, as far as I can tell. You can just get the prototype from gURLBar and avoid the side effects of importing.

const lazy = XPCOMUtils.declareLazy({
  UrlbarController: "moz-src:///browser/components/urlbar/UrlbarController.sys.mjs",
  ...
});

this.orig_receiveResults = lazy.UrlbarController.prototype.receiveResults;
...

Object.getPrototypeOf(gURLBar).setValueFromResult = new Proxy(this.input.setValueFromResult, {
...

Otherwise, you might also need to delay execution of the script. It seems like init() is happening as soon as the script loads, which might be too early. I would delay it with this pattern:

if (gBrowserInit.delayedStartupFinished) {
  init();
} else {
  let delayedListener = (subject, topic) => {
    if (topic == "browser-delayed-startup-finished" && subject == window) {
      Services.obs.removeObserver(delayedListener, topic);
      init();
    }
  };
  Services.obs.addObserver(delayedListener, "browser-delayed-startup-finished");
}

If that doesn't do it, you could try awaiting the definition of the urlbar custom element. That would look like this:

customElements.whenDefined("moz-urlbar").then(init);

But I don't know how you're loading this script. It does not seem compatible with fx-autoconfig. The @startup directive format is wrong for fx-autoconfig. This is how it's supposed to work. And at the bottom, it references _uc.windows, which I suspect is a reference to an API in xiaoxiaoflood's loader, not fx-autoconfig. So I don't know how this was working to begin with, unless you're using xiaoxiaoflood's loader.

[iax9123]

Can you share the entire call stack of the error? Does it have an arrow for expanding/collapsing the error?

That was the entire stock. There was no arrow.

I think your explanation about my script running too early may be correct -- this sort of thing has happened before ( #108 ). I'll have a go today and see if the changes can help.

But I don't know how you're loading this script. It does not seem compatible with fx-autoconfig.

Yes, it was modified from xiaoxiaoflood's repo. It doesn't seem to rely too heavily on the _uc functions is seems, as it was able to work even if it was silently dropping through that part of the code. I'm pretty sure the correct call of it for fx-autoconfig was UC_API, but when I was trying to make a clean build using the new codebases I ran into issues that at the time were hard to troubleshoot. They ended up turning out to be a combination of the following:

• files that you download through the 'releases' or 'master.zip' are not up to date compared to going through manually in the repo and copy and pasting the code
• sometimes when saving a text file on windows, the encoding does not get set correct (sometimes Unicode BOM instead of UTF-8).

So I had (at the time) given up on trying to migrate to the new codebases, and just lived with what I was able to get working. But now since I worked those issues out, I am on a clean build with the new codebases (meaning I can finally use things such as UC_API and as proof I have makeDefaultBookmarkFolderPermanent() from miscMods.uc.js working fine).

I have a good feeling about what you said the issue could be, and will report back after I have tested a bit. Thanks!

[iax9123]

I have a good feeling about what you said the issue could be, and will report back after I have tested a bit. Thanks!

Well, I had a go and successfully got the code updated. Still getting the customElements error, but I noticed that it is not a stop error, it's still letting the script do stuff, since with the updates now I have some new interesting errors:

URLBar - ProvidersManager: TypeError: right-hand side of 'in' should be an object, got undefined
receiveResults chrome://userscripts/content/enterSelects.uc.js:28
_notifyResults moz-src:///browser/components/urlbar/UrlbarProvidersManager.sys.mjs:985
callback moz-src:///browser/components/urlbar/UrlbarProvidersManager.sys.mjs:950
promise moz-src:///browser/components/urlbar/UrlbarUtils.sys.mjs:3120

My guess is that the code is trying to check information when the urlbar is clicked, and instead of finding the information (an object), it doesn't find anything. I don't know if I put the getters in the right place in the code --> I chose to put them at the top of the init function.

I attached the modified version, but if it's a lost cause then I can live without it. It's just sad to see it go, since I have had this kind of functionality since the good old Opera 9-11ish (presto) days.

enterSelects2.uc.js

Needless to say there is a lack of expertise on my end that I am unable to get this working. I am pretty sure it should be reproducible on your end --> I'm running just Firefox 147 and MrOtherGuy's fx-autoconfig (boot.sys.mjs version 0.10.11). I am testing without any additional userchrome scripts, but other scripts function normally when tested.

Without this script and using the normal urlbar autofill functionality (browser.urlbar.autoFill = true), typing a few characters will pre-fill the domain, so enter will take you to the top domain.

With this script (and turning off the browser.urlbar.autoFill), typing a few characters will pre-fill a full url. Back in the day, the only results you would get proposed from the urlbar were your previous history or bookmarks, so this is a way to quickly access something you are looking for with minimal key strokes. The more you type, the more refined the search will be, and then enter selects what you were looking for and goes to it ;)