forked from ember-cli/eslint-plugin-ember
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathno-ember-super-in-es-classes.js
More file actions
67 lines (58 loc) · 1.68 KB
/
no-ember-super-in-es-classes.js
File metadata and controls
67 lines (58 loc) · 1.68 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
'use strict';
function isDirectlyInClass(node) {
let currentNode = node.parent;
let inFunctionAlready = false;
while (currentNode) {
if (currentNode.type === 'MethodDefinition') {
return true;
} else if (currentNode.type === 'FunctionExpression') {
if (inFunctionAlready) {
return false;
} else {
inFunctionAlready = true;
}
}
currentNode = currentNode.parent;
}
return false;
}
/** @type {import('eslint').Rule.RuleModule} */
module.exports = {
meta: {
type: 'problem',
docs: {
description: 'disallow use of `this._super` in ES class methods',
category: 'Ember Octane',
recommended: true,
url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/no-ember-super-in-es-classes.md',
},
fixable: 'code',
schema: [],
},
create(context) {
return {
'MethodDefinition MemberExpression[object.type="ThisExpression"][property.name="_super"]'(
node
) {
if (!isDirectlyInClass(node)) {
return;
}
context.report({
node,
message: "Don't use `this._super` in ES classes; instead, you should use `super`",
fix(fixer) {
let method = node;
while (method.type !== 'MethodDefinition') {
method = method.parent;
}
if (method.key.type === 'Identifier') {
return fixer.replaceText(node, `super.${method.key.name}`);
}
const text = (context.sourceCode ?? context.getSourceCode()).getText(method.key);
return fixer.replaceText(node, `super[${text}]`);
},
});
},
};
},
};