Fix memory leaks that were reported by LeakSanitizer on Linux during simple usage

iyadahmed · iyadahmed · commit 5aca36bb580f · 2024-02-01T16:47:24.000+02:00
During simple usage of the library, LeakSanitizer reported some leaks related to `opendir`, this commit fixes those leaks
diff --git a/ImGuiFileDialog.cpp b/ImGuiFileDialog.cpp
@@ -559,8 +559,8 @@ class FileSystemDirent : public IGFD::IFileSystem {
             // this func will fail
             pDir = opendir(vName.c_str());
             if (pDir != nullptr) {
-                return true;
                 (void)closedir(pDir);
+                return true;
             }
         }
         return false;
@@ -728,7 +728,12 @@ class FileSystemDirent : public IGFD::IFileSystem {
         return res;
     }
     bool IsDirectory(const std::string& vFilePathName) override {
-        return (opendir(vFilePathName.c_str()) != nullptr);
+        DIR *pDir = opendir(vFilePathName.c_str());
+        if (pDir) {
+            (void)closedir(pDir);
+            return true;
+        }
+        return false;
     }
 };
 #define FILE_SYSTEM_OVERRIDE FileSystemDirent

Original file line number	Diff line number	Diff line change
`@@ -559,8 +559,8 @@ class FileSystemDirent : public IGFD::IFileSystem {`
`559`	`559`	`// this func will fail`
`560`	`560`	`pDir = opendir(vName.c_str());`
`561`	`561`	`if (pDir != nullptr) {`
`562`		`- return true;`
`563`	`562`	`(void)closedir(pDir);`
	`563`	`+ return true;`
`564`	`564`	`}`
`565`	`565`	`}`
`566`	`566`	`return false;`
`@@ -728,7 +728,12 @@ class FileSystemDirent : public IGFD::IFileSystem {`
`728`	`728`	`return res;`
`729`	`729`	`}`
`730`	`730`	`bool IsDirectory(const std::string& vFilePathName) override {`
`731`		`- return (opendir(vFilePathName.c_str()) != nullptr);`
	`731`	`+ DIR *pDir = opendir(vFilePathName.c_str());`
	`732`	`+ if (pDir) {`
	`733`	`+ (void)closedir(pDir);`
	`734`	`+ return true;`
	`735`	`+ }`
	`736`	`+ return false;`
`732`	`737`	`}`
`733`	`738`	`};`
`734`	`739`	`#define FILE_SYSTEM_OVERRIDE FileSystemDirent`