-

aiekick · aiekick · commit 3d91e54c8af1 · 2024-12-01T03:04:49.000+01:00
diff --git a/ImGuiFileDialog.cpp b/ImGuiFileDialog.cpp
@@ -876,7 +876,7 @@ bool IGFD::Utils::ReplaceString(std::string& str, const ::std::string& oldStr, c
     return false;
 }
 
-std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const std::string& vDelimiterPattern, const bool& vPushEmpty) {
+std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const std::string& vDelimiterPattern, const bool vPushEmpty) {
     std::vector<std::string> arr;
     if (!vText.empty()) {
         size_t start = 0;
@@ -897,7 +897,7 @@ std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vTe
     return arr;
 }
 
-std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const char& vDelimiter, const bool& vPushEmpty) {
+std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const char& vDelimiter, const bool vPushEmpty) {
     std::vector<std::string> arr;
     if (!vText.empty()) {
         size_t start = 0;
@@ -1145,12 +1145,12 @@ void IGFD::FilterInfos::setCollectionTitle(const std::string& vTitle) {
     title = vTitle;
 }
 
-void IGFD::FilterInfos::addFilter(const std::string& vFilter, const bool& vIsRegex) {
+void IGFD::FilterInfos::addFilter(const std::string& vFilter, const bool vIsRegex) {
     setCollectionTitle(vFilter);
     addCollectionFilter(vFilter, vIsRegex);
 }
 
-void IGFD::FilterInfos::addCollectionFilter(const std::string& vFilter, const bool& vIsRegex) {
+void IGFD::FilterInfos::addCollectionFilter(const std::string& vFilter, const bool vIsRegex) {
     if (!vIsRegex) {
         auto _count_dots = Utils::GetCharCountInString(vFilter, '.');
         if (_count_dots > IGFD::FilterInfos::count_dots) {
@@ -1669,12 +1669,12 @@ void IGFD::FilterManager::SetDefaultFilterIfNotDefined() {
 }
 
 IGFD::FileType::FileType() = default;
-IGFD::FileType::FileType(const ContentType& vContentType, const bool& vIsSymlink) : m_Content(vContentType), m_Symlink(vIsSymlink) {
+IGFD::FileType::FileType(const ContentType& vContentType, const bool vIsSymlink) : m_Content(vContentType), m_Symlink(vIsSymlink) {
 }
 void IGFD::FileType::SetContent(const ContentType& vContentType) {
     m_Content = vContentType;
 }
-void IGFD::FileType::SetSymLink(const bool& vIsSymlink) {
+void IGFD::FileType::SetSymLink(const bool vIsSymlink) {
     m_Symlink = vIsSymlink;
 }
 bool IGFD::FileType::isValid() const {
@@ -1721,7 +1721,7 @@ bool IGFD::FileInfos::SearchForTag(const std::string& vTag) const {
     return true;
 }
 
-bool IGFD::FileInfos::SearchForExt(const std::string& vExt, const bool& vIsCaseInsensitive, const size_t& vMaxLevel) const {
+bool IGFD::FileInfos::SearchForExt(const std::string& vExt, const bool vIsCaseInsensitive, const size_t& vMaxLevel) const {
     if (!vExt.empty()) {
         const auto& ext_to_check = vIsCaseInsensitive ? Utils::LowerCaseString(vExt) : vExt;
         const auto& ext_levels   = vIsCaseInsensitive ? fileExtLevels_optimized : fileExtLevels;
@@ -1738,7 +1738,7 @@ bool IGFD::FileInfos::SearchForExt(const std::string& vExt, const bool& vIsCaseI
     return false;
 }
 
-bool IGFD::FileInfos::SearchForExts(const std::string& vComaSepExts, const bool& vIsCaseInsensitive, const size_t& vMaxLevel) const {
+bool IGFD::FileInfos::SearchForExts(const std::string& vComaSepExts, const bool vIsCaseInsensitive, const size_t& vMaxLevel) const {
     if (!vComaSepExts.empty()) {
         const auto& arr = Utils::SplitStringToVector(vComaSepExts, ',', false);
         for (const auto& a : arr) {
@@ -3214,7 +3214,7 @@ bool IGFD::PlacesFeature::m_DrawPlacesPane(FileDialogInternal& vFileDialogIntern
     return res;
 }
 
-std::string IGFD::PlacesFeature::SerializePlaces(const bool& /*vForceSerialisationForAll*/) {
+std::string IGFD::PlacesFeature::SerializePlaces(const bool /*vForceSerialisationForAll*/) {
     std::string res;
     size_t idx = 0;
     for (const auto& group : m_Groups) {
@@ -3251,7 +3251,7 @@ void IGFD::PlacesFeature::DeserializePlaces(const std::string& vPlaces) {
     }
 }
 
-bool IGFD::PlacesFeature::AddPlacesGroup(const std::string& vGroupName, const size_t& vDisplayOrder, const bool& vCanBeEdited, const bool& vOpenedByDefault) {
+bool IGFD::PlacesFeature::AddPlacesGroup(const std::string& vGroupName, const size_t& vDisplayOrder, const bool vCanBeEdited, const bool vOpenedByDefault) {
     if (vGroupName.empty()) {
         return false;
     }
@@ -3285,7 +3285,7 @@ IGFD::PlacesFeature::GroupStruct* IGFD::PlacesFeature::GetPlacesGroupPtr(const s
     return nullptr;
 }
 
-bool IGFD::PlacesFeature::GroupStruct::AddPlace(const std::string& vPlaceName, const std::string& vPlacePath, const bool& vCanBeSaved, const FileStyle& vStyle) {
+bool IGFD::PlacesFeature::GroupStruct::AddPlace(const std::string& vPlaceName, const std::string& vPlacePath, const bool vCanBeSaved, const FileStyle& vStyle) {
     if (vPlaceName.empty() || vPlacePath.empty()) {
         return false;
     }
@@ -4198,7 +4198,7 @@ void IGFD::FileDialog::m_BeginFileColorIconStyle(std::shared_ptr<FileInfos> vFil
     if (*vOutFont) ImGui::PushFont(*vOutFont);
 }
 
-void IGFD::FileDialog::m_EndFileColorIconStyle(const bool& vShowColor, ImFont* vFont) {
+void IGFD::FileDialog::m_EndFileColorIconStyle(const bool vShowColor, ImFont* vFont) {
     if (vFont) ImGui::PopFont();
     if (vShowColor) ImGui::PopStyleColor();
 }
diff --git a/ImGuiFileDialog.h b/ImGuiFileDialog.h
@@ -329,8 +329,8 @@ class IGFD_API Utils {
     static void SetBuffer(char* vBuffer, size_t vBufferLen, const std::string& vStr);
     static std::string UTF8Encode(const std::wstring& wstr);
     static std::wstring UTF8Decode(const std::string& str);
-    static std::vector<std::string> SplitStringToVector(const std::string& vText, const std::string& vDelimiterPattern, const bool& vPushEmpty);
-    static std::vector<std::string> SplitStringToVector(const std::string& vText, const char& vDelimiter, const bool& vPushEmpty);
+    static std::vector<std::string> SplitStringToVector(const std::string& vText, const std::string& vDelimiterPattern, const bool vPushEmpty);
+    static std::vector<std::string> SplitStringToVector(const std::string& vText, const char& vDelimiter, const bool vPushEmpty);
     static std::string LowerCaseString(const std::string& vString);  // turn all text in lower case for search facilitie
     static size_t GetCharCountInString(const std::string& vString, const char& vChar);
     static size_t GetLastCharPosWithMinCharCount(const std::string& vString, const char& vChar, const size_t& vMinCharCount);
@@ -397,8 +397,8 @@ class IGFD_API FilterInfos {
     bool regexExist(const std::string& vFilter) const;                                   // is regex filter exist
     bool exist(const FileInfos& vFileInfos, bool vIsCaseInsensitive) const;              // is filter exist
     void setCollectionTitle(const std::string& vTitle);                                  // set the collection title
-    void addFilter(const std::string& vFilter, const bool& vIsRegex);                    // add a filter
-    void addCollectionFilter(const std::string& vFilter, const bool& vIsRegex);          // add a filter in collection
+    void addFilter(const std::string& vFilter, const bool vIsRegex);                    // add a filter
+    void addCollectionFilter(const std::string& vFilter, const bool vIsRegex);          // add a filter in collection
     static std::string transformAsteriskBasedFilterToRegex(const std::string& vFilter);  // will transform a filter who contain * to a regex
 };
 
@@ -455,10 +455,10 @@ class IGFD_API FileType {
 
 public:
     FileType();
-    FileType(const ContentType& vContentType, const bool& vIsSymlink);
+    FileType(const ContentType& vContentType, const bool vIsSymlink);
 
     void SetContent(const ContentType& vContentType);
-    void SetSymLink(const bool& vIsSymlink);
+    void SetSymLink(const bool vIsSymlink);
 
     bool isValid() const;
     bool isDir() const;
@@ -504,9 +504,9 @@ class IGFD_API FileInfos {
 
 public:
     bool SearchForTag(const std::string& vTag) const;  // will search a tag in fileNameExt and fileNameExt_optimized
-    bool SearchForExt(const std::string& vExt, const bool& vIsCaseInsensitive,
+    bool SearchForExt(const std::string& vExt, const bool vIsCaseInsensitive,
                       const size_t& vMaxLevel = EXT_MAX_LEVEL) const;  // will check the fileExtLevels levels for vExt, until vMaxLevel
-    bool SearchForExts(const std::string& vComaSepExts, const bool& vIsCaseInsensitive,
+    bool SearchForExts(const std::string& vComaSepExts, const bool vIsCaseInsensitive,
                        const size_t& vMaxLevel = EXT_MAX_LEVEL) const;  // will check the fileExtLevels levels for vExts (ext are coma separated), until vMaxLevel
     bool FinalizeFileTypeParsing(const size_t& vMaxDotToExtract);       // finalize the parsing the file (only a file or link to file. no dir)
 };
@@ -818,7 +818,7 @@ class IGFD_API PlacesFeature {
         bool AddPlace(                      // add a place by code
             const std::string& vPlaceName,  // place name
             const std::string& vPlacePath,  // place path
-            const bool& vCanBeSaved,        // prevent serialization
+            const bool vCanBeSaved,        // prevent serialization
             const FileStyle& vStyle = {});  // style
         void AddPlaceSeparator(const float& vThickness = 1.0f);
         bool RemovePlace(                    // remove a place by code, return true if succeed
@@ -840,14 +840,14 @@ class IGFD_API PlacesFeature {
 
 public:
     std::string SerializePlaces(                                    // serialize place : return place buffer to save in a file
-        const bool& vForceSerialisationForAll = true);              // for avoid serialization of places with flag 'canBeSaved to false'
+        const bool vForceSerialisationForAll = true);              // for avoid serialization of places with flag 'canBeSaved to false'
     void DeserializePlaces(                                         // deserialize place : load place buffer to load in the dialog (saved from
         const std::string& vPlaces);                                // previous use with SerializePlaces()) place buffer to load
     bool AddPlacesGroup(                                            // add a group
         const std::string& vGroupName,                              // the group name
         const size_t& vDisplayOrder,                                // the display roder of the group
-        const bool& vCanBeEdited     = false,                       // let the user add/remove place in the group
-        const bool& vOpenedByDefault = true);                       // hte group is opened by default
+        const bool vCanBeEdited     = false,                       // let the user add/remove place in the group
+        const bool vOpenedByDefault = true);                       // hte group is opened by default
     bool RemovePlacesGroup(const std::string& vGroupName);          // remove the group
     GroupStruct* GetPlacesGroupPtr(const std::string& vGroupName);  // get the group, if not existed, will be created
 #endif                                                              // USE_PLACES_FEATURE
@@ -1008,7 +1008,7 @@ class IGFD_API FileDialog : public PlacesFeature, public KeyExplorerFeature, pub
     // - m_DrawThumbnailsGridView
     void m_BeginFileColorIconStyle(std::shared_ptr<FileInfos> vFileInfos, bool& vOutShowColor, std::string& vOutStr,
                                    ImFont** vOutFont);                    // begin style apply of filter with color an icon if any
-    void m_EndFileColorIconStyle(const bool& vShowColor, ImFont* vFont);  // end style apply of filter
+    void m_EndFileColorIconStyle(const bool vShowColor, ImFont* vFont);  // end style apply of filter
 
     void m_DisplayFileInfosTooltip(const int32_t& vRowIdx, const int32_t& vColumnIdx, std::shared_ptr<FileInfos> vFileInfos);
 };

Original file line number	Diff line number	Diff line change
`@@ -876,7 +876,7 @@ bool IGFD::Utils::ReplaceString(std::string& str, const ::std::string& oldStr, c`
`876`	`876`	`return false;`
`877`	`877`	`}`
`878`	`878`
`879`		`-std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const std::string& vDelimiterPattern, const bool& vPushEmpty) {`
	`879`	`+std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const std::string& vDelimiterPattern, const bool vPushEmpty) {`
`880`	`880`	`std::vector<std::string> arr;`
`881`	`881`	`if (!vText.empty()) {`
`882`	`882`	`size_t start = 0;`
`@@ -897,7 +897,7 @@ std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vTe`
`897`	`897`	`return arr;`
`898`	`898`	`}`
`899`	`899`
`900`		`-std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const char& vDelimiter, const bool& vPushEmpty) {`
	`900`	`+std::vector<std::string> IGFD::Utils::SplitStringToVector(const std::string& vText, const char& vDelimiter, const bool vPushEmpty) {`
`901`	`901`	`std::vector<std::string> arr;`
`902`	`902`	`if (!vText.empty()) {`
`903`	`903`	`size_t start = 0;`
`@@ -1145,12 +1145,12 @@ void IGFD::FilterInfos::setCollectionTitle(const std::string& vTitle) {`
`1145`	`1145`	`title = vTitle;`
`1146`	`1146`	`}`
`1147`	`1147`
`1148`		`-void IGFD::FilterInfos::addFilter(const std::string& vFilter, const bool& vIsRegex) {`
	`1148`	`+void IGFD::FilterInfos::addFilter(const std::string& vFilter, const bool vIsRegex) {`
`1149`	`1149`	`setCollectionTitle(vFilter);`
`1150`	`1150`	`addCollectionFilter(vFilter, vIsRegex);`
`1151`	`1151`	`}`
`1152`	`1152`
`1153`		`-void IGFD::FilterInfos::addCollectionFilter(const std::string& vFilter, const bool& vIsRegex) {`
	`1153`	`+void IGFD::FilterInfos::addCollectionFilter(const std::string& vFilter, const bool vIsRegex) {`
`1154`	`1154`	`if (!vIsRegex) {`
`1155`	`1155`	`auto _count_dots = Utils::GetCharCountInString(vFilter, '.');`
`1156`	`1156`	`if (_count_dots > IGFD::FilterInfos::count_dots) {`
`@@ -1669,12 +1669,12 @@ void IGFD::FilterManager::SetDefaultFilterIfNotDefined() {`
`1669`	`1669`	`}`
`1670`	`1670`
`1671`	`1671`	`IGFD::FileType::FileType() = default;`
`1672`		`-IGFD::FileType::FileType(const ContentType& vContentType, const bool& vIsSymlink) : m_Content(vContentType), m_Symlink(vIsSymlink) {`
	`1672`	`+IGFD::FileType::FileType(const ContentType& vContentType, const bool vIsSymlink) : m_Content(vContentType), m_Symlink(vIsSymlink) {`
`1673`	`1673`	`}`
`1674`	`1674`	`void IGFD::FileType::SetContent(const ContentType& vContentType) {`
`1675`	`1675`	`m_Content = vContentType;`
`1676`	`1676`	`}`
`1677`		`-void IGFD::FileType::SetSymLink(const bool& vIsSymlink) {`
	`1677`	`+void IGFD::FileType::SetSymLink(const bool vIsSymlink) {`
`1678`	`1678`	`m_Symlink = vIsSymlink;`
`1679`	`1679`	`}`
`1680`	`1680`	`bool IGFD::FileType::isValid() const {`
`@@ -1721,7 +1721,7 @@ bool IGFD::FileInfos::SearchForTag(const std::string& vTag) const {`
`1721`	`1721`	`return true;`
`1722`	`1722`	`}`
`1723`	`1723`
`1724`		`-bool IGFD::FileInfos::SearchForExt(const std::string& vExt, const bool& vIsCaseInsensitive, const size_t& vMaxLevel) const {`
	`1724`	`+bool IGFD::FileInfos::SearchForExt(const std::string& vExt, const bool vIsCaseInsensitive, const size_t& vMaxLevel) const {`
`1725`	`1725`	`if (!vExt.empty()) {`
`1726`	`1726`	`const auto& ext_to_check = vIsCaseInsensitive ? Utils::LowerCaseString(vExt) : vExt;`
`1727`	`1727`	`const auto& ext_levels = vIsCaseInsensitive ? fileExtLevels_optimized : fileExtLevels;`
`@@ -1738,7 +1738,7 @@ bool IGFD::FileInfos::SearchForExt(const std::string& vExt, const bool& vIsCaseI`
`1738`	`1738`	`return false;`
`1739`	`1739`	`}`
`1740`	`1740`
`1741`		`-bool IGFD::FileInfos::SearchForExts(const std::string& vComaSepExts, const bool& vIsCaseInsensitive, const size_t& vMaxLevel) const {`
	`1741`	`+bool IGFD::FileInfos::SearchForExts(const std::string& vComaSepExts, const bool vIsCaseInsensitive, const size_t& vMaxLevel) const {`
`1742`	`1742`	`if (!vComaSepExts.empty()) {`
`1743`	`1743`	`const auto& arr = Utils::SplitStringToVector(vComaSepExts, ',', false);`
`1744`	`1744`	`for (const auto& a : arr) {`
`@@ -3214,7 +3214,7 @@ bool IGFD::PlacesFeature::m_DrawPlacesPane(FileDialogInternal& vFileDialogIntern`
`3214`	`3214`	`return res;`
`3215`	`3215`	`}`
`3216`	`3216`
`3217`		`-std::string IGFD::PlacesFeature::SerializePlaces(const bool& /vForceSerialisationForAll/) {`
	`3217`	`+std::string IGFD::PlacesFeature::SerializePlaces(const bool /vForceSerialisationForAll/) {`
`3218`	`3218`	`std::string res;`
`3219`	`3219`	`size_t idx = 0;`
`3220`	`3220`	`for (const auto& group : m_Groups) {`
`@@ -3251,7 +3251,7 @@ void IGFD::PlacesFeature::DeserializePlaces(const std::string& vPlaces) {`
`3251`	`3251`	`}`
`3252`	`3252`	`}`
`3253`	`3253`
`3254`		`-bool IGFD::PlacesFeature::AddPlacesGroup(const std::string& vGroupName, const size_t& vDisplayOrder, const bool& vCanBeEdited, const bool& vOpenedByDefault) {`
	`3254`	`+bool IGFD::PlacesFeature::AddPlacesGroup(const std::string& vGroupName, const size_t& vDisplayOrder, const bool vCanBeEdited, const bool vOpenedByDefault) {`
`3255`	`3255`	`if (vGroupName.empty()) {`
`3256`	`3256`	`return false;`
`3257`	`3257`	`}`
`@@ -3285,7 +3285,7 @@ IGFD::PlacesFeature::GroupStruct* IGFD::PlacesFeature::GetPlacesGroupPtr(const s`
`3285`	`3285`	`return nullptr;`
`3286`	`3286`	`}`
`3287`	`3287`
`3288`		`-bool IGFD::PlacesFeature::GroupStruct::AddPlace(const std::string& vPlaceName, const std::string& vPlacePath, const bool& vCanBeSaved, const FileStyle& vStyle) {`
	`3288`	`+bool IGFD::PlacesFeature::GroupStruct::AddPlace(const std::string& vPlaceName, const std::string& vPlacePath, const bool vCanBeSaved, const FileStyle& vStyle) {`
`3289`	`3289`	`if (vPlaceName.empty() \|\| vPlacePath.empty()) {`
`3290`	`3290`	`return false;`
`3291`	`3291`	`}`
`@@ -4198,7 +4198,7 @@ void IGFD::FileDialog::m_BeginFileColorIconStyle(std::shared_ptr<FileInfos> vFil`
`4198`	`4198`	`if (vOutFont) ImGui::PushFont(vOutFont);`
`4199`	`4199`	`}`
`4200`	`4200`
`4201`		`-void IGFD::FileDialog::m_EndFileColorIconStyle(const bool& vShowColor, ImFont* vFont) {`
	`4201`	`+void IGFD::FileDialog::m_EndFileColorIconStyle(const bool vShowColor, ImFont* vFont) {`
`4202`	`4202`	`if (vFont) ImGui::PopFont();`
`4203`	`4203`	`if (vShowColor) ImGui::PopStyleColor();`
`4204`	`4204`	`}`