Merge pull request #70 from aaronpowell/issue-69

Fix ID lookup bug

Author: aaronpowell

.github/workflows/ci.yml

@@ -17,10 +17,10 @@ jobs:
     runs-on: windows-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Dotnet ${{ env.DOTNET_VERSION }}
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
         with:
           dotnet-version: ${{ env.DOTNET_VERSION }}
 
@@ -31,7 +31,7 @@ jobs:
         run: dotnet fake run ./build.fsx --target CI
 
       - name: Publish release packages
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v3
         with:
           name: packages
           path: ${{ env.OUTPUT_PATH }}
@@ -41,13 +41,13 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v3
         with:
           name: packages
           path: ${{ env.OUTPUT_PATH }}
 
       - name: Setup .NET Core ${{ env.DOTNET_VERSION }}
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
         with:
           dotnet-version: ${{ env.DOTNET_VERSION }}
 

.github/workflows/release.yml

@@ -15,10 +15,10 @@ jobs:
     runs-on: windows-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: Setup Dotnet ${{ env.DOTNET_VERSION }}
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
         with:
           dotnet-version: ${{ env.DOTNET_VERSION }}
 
@@ -54,7 +54,7 @@ jobs:
           body_path: ${{ env.OUTPUT_PATH }}/changelog.md
       - run: echo ${{ steps.create_release.outputs.id }} >> release.txt
       - name: Upload release_id
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
             name: release_id
             path: release.txt
@@ -107,7 +107,7 @@ jobs:
 
     steps:
       - name: Download package
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
         with:
             name: release_id
       - run: echo "release_id=$(cat release.txt)" >> $GITHUB_ENV
@@ -128,7 +128,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v3
         with:
           name: packages
           path: ${{ env.OUTPUT_PATH }}
@@ -151,7 +151,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v3
         with:
           name: packages
           path: ${{ env.OUTPUT_PATH }}

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog for `FSharp.CosmosDb`
 
+## [1.2.1] - Unreleased
+
+### Fixes
+
+- Fixing #69 by finding a property using conventions first, before raising an error
+
 ## [1.2.0] - 2022-08-22
 
 ### Added

src/FSharp.CosmosDb/OperationHandling.fs

@@ -11,7 +11,11 @@ let getIdFieldName<'T> (item: 'T) =
 
     match idAttr with
     | Some attr -> attr.GetValue(item).ToString()
-    | None -> "id"
+    | None ->
+        let property = item.GetType().GetProperties() |> Array.tryFind(fun p -> p.Name.Equals("id", StringComparison.InvariantCultureIgnoreCase))
+        match property with
+        | Some property -> property.GetValue(item).ToString()
+        | None -> failwith "Unable to determine the id field of the type. Either use the IdAttribute or have a field named Id"
 
 let getPartitionKeyValue<'T> (single: 'T) =
     let partitionKey = PartitionKeyAttributeTools.findPartitionKey<'T> ()