Fix multipart injection (aio-libs#12104)

Co-authored-by: mingi jung <[email protected]>

Author: Dreamsorcerer

aiohttp/formdata.py

@@ -70,6 +70,11 @@ def add_field(
                 raise TypeError(
                     "content_type must be an instance of str. Got: %s" % content_type
                 )
+            if "\r" in content_type or "\n" in content_type:
+                raise ValueError(
+                    "Newline or carriage return detected in headers. "
+                    "Potential header injection attack."
+                )
             headers[hdrs.CONTENT_TYPE] = content_type
             self._is_multipart = True
 

tests/test_formdata.py

@@ -75,12 +75,18 @@ async def test_formdata_textio_charset(buf: bytearray, writer: StreamWriter) ->
     assert b"\x93\xfa\x96{" in buf
 
 
-def test_invalid_formdata_content_type() -> None:
+@pytest.mark.parametrize("val", (0, 0.1, {}, [], b"foo"))
+def test_invalid_type_formdata_content_type(val: object) -> None:
     form = FormData()
-    invalid_vals = [0, 0.1, {}, [], b"foo"]
-    for invalid_val in invalid_vals:
-        with pytest.raises(TypeError):
-            form.add_field("foo", "bar", content_type=invalid_val)  # type: ignore[arg-type]
+    with pytest.raises(TypeError):
+        form.add_field("foo", "bar", content_type=val)  # type: ignore[arg-type]
+
+
+@pytest.mark.parametrize("val", ("\r", "\n", "a\ra\n", "a\na\r"))
+def test_invalid_value_formdata_content_type(val: str) -> None:
+    form = FormData()
+    with pytest.raises(ValueError):
+        form.add_field("foo", "bar", content_type=val)
 
 
 def test_invalid_formdata_filename() -> None: