From 6efc08255ff8b2050fb10ee6d3cc6253eef2541c Mon Sep 17 00:00:00 2001 From: Lakshyajeet Singh Goyal Date: Wed, 11 Jun 2025 18:36:55 +0530 Subject: [PATCH 1/2] fix: make mobile nav menu scrollable --- .../sass/navigation/_menu-main-navigation.scss | 6 +++++- src/wp-content/themes/twentynineteen/style-rtl.css | 7 ++++++- src/wp-content/themes/twentynineteen/style.css | 6 +++++- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss b/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss index d1e30256f3d00..6d6d744ed80ae 100644 --- a/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss +++ b/src/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss @@ -433,9 +433,13 @@ white-space: inherit; } + &:not(:has(.sub-menu.expanded-true)) { + overflow-y: scroll; + } + &.expanded-true { - display: table; + display: block; margin-top: 0; opacity: 1; padding-left: 0; diff --git a/src/wp-content/themes/twentynineteen/style-rtl.css b/src/wp-content/themes/twentynineteen/style-rtl.css index da1b3636c03d0..beb0507dc4b3d 100644 --- a/src/wp-content/themes/twentynineteen/style-rtl.css +++ b/src/wp-content/themes/twentynineteen/style-rtl.css @@ -3271,8 +3271,12 @@ body.page .main-navigation { white-space: inherit; } +.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu .expanded-true:not(:has(.sub-menu.expanded-true)) { + overflow-y: scroll; +} + .main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu.expanded-true { - display: table; + display: block; margin-top: 0; opacity: 1; padding-right: 0; @@ -3282,6 +3286,7 @@ body.page .main-navigation { left: 0; bottom: 0; position: fixed; + overflow: scroll; z-index: 100000; /* Make sure appears above mobile admin bar */ width: 100vw; diff --git a/src/wp-content/themes/twentynineteen/style.css b/src/wp-content/themes/twentynineteen/style.css index 2124cf584f07c..634a947b3a880 100644 --- a/src/wp-content/themes/twentynineteen/style.css +++ b/src/wp-content/themes/twentynineteen/style.css @@ -3271,8 +3271,12 @@ body.page .main-navigation { white-space: inherit; } +.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu:not(:has(.sub-menu.expanded-true)) { + overflow-y: scroll; +} + .main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu.expanded-true { - display: table; + display: block; margin-top: 0; opacity: 1; padding-left: 0; From 47fad773b4740aade8ab6ff8c0f511fcc0a40bd6 Mon Sep 17 00:00:00 2001 From: Lakshyajeet Singh Goyal Date: Thu, 12 Jun 2025 12:09:29 +0530 Subject: [PATCH 2/2] fix: update `style-rtl.css` --- src/wp-content/themes/twentynineteen/style-rtl.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/wp-content/themes/twentynineteen/style-rtl.css b/src/wp-content/themes/twentynineteen/style-rtl.css index beb0507dc4b3d..9f1700c012b9b 100644 --- a/src/wp-content/themes/twentynineteen/style-rtl.css +++ b/src/wp-content/themes/twentynineteen/style-rtl.css @@ -3271,7 +3271,7 @@ body.page .main-navigation { white-space: inherit; } -.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu .expanded-true:not(:has(.sub-menu.expanded-true)) { +.main-navigation .main-menu .menu-item-has-children.off-canvas .sub-menu:not(:has(.sub-menu.expanded-true)) { overflow-y: scroll; } @@ -3286,7 +3286,6 @@ body.page .main-navigation { left: 0; bottom: 0; position: fixed; - overflow: scroll; z-index: 100000; /* Make sure appears above mobile admin bar */ width: 100vw;