Missing escaping for XML error message #65047

[maheshpatel27]

Add escaping src/wp-trackback.php

if ( $error ) {

echo '<?xml version="1.0" encoding="utf-8"?' . ">\n";
echo "\n";
echo "1\n";
echo "" . esc_html ( $error_message ) . "\n";
echo '';

}

Trac ticket: https://core.trac.wordpress.org/ticket/65047#ticket

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props maheshpatel, pbiron, sabernhardt, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Hi @maheshpatel27! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

• PHP Coding Standards
• CSS Coding Standards
• HTML Coding Standards
• JavaScript Coding Standards
• Accessibility Coding Standards
• Inline Documentation Standards

Thank you,
The WordPress Project

[westonruter]

I would say that this warrants adding a unit test, but it doesn't seem there are any unit tests for the functionality in wp-trackback.php.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[westonruter]

To resolve the PHPCS complaint:

Suggested change

	echo "<message>" . esc_xml( $error_message ) . "</message>\n";
	echo '<message>' . esc_xml( $error_message ) . "</message>\n";

[pbiron]

I would say that this warrants adding a unit test, but it doesn't seem there are any unit tests for the functionality in wp-trackback.php.

Agreed...wish I had time to work on that ;-(

Here's some info for whoever does write unit tests:

• the main diff between esc_html() and esc_xml() is that esc_xml() leaves CDATA Sections intact. That is, if the $error_message contained something like <![CDATA[<greeting>Hello, world!</greeting>]]>, esc_html() would replace the < and > chars with < and >, whereas esc_xml() won't.
• so, it'd be good if the unit tests included $error_message's with and without CDATA Sections

[westonruter]

I don't consider tests to be a blocker here.