Restore: Sync Gutenberg @ 022d8dd3d461f91b15c1f0410649d3ebb027207f

See changelog in f328908

Author: dmsnell

src/wp-admin/css/common.css

@@ -1575,11 +1575,11 @@ div.error.notice-alt {
 
 .notice-info {
 	border-left-color: #3858e9;
-	background-color: transparent;
+	background-color: #fff;
 }
 
 .notice-info.notice-alt {
-	background-color: transparent;
+	background-color: #fff;
 }
 
 #plugin-information-footer .update-now:not(.button-disabled):before {

src/wp-admin/css/customize-controls.css

@@ -273,8 +273,9 @@ body.trashing #publish-settings {
 	margin: 0;
 	position: absolute;
 	top: 50%;
-	transform: translateY(-50%);
+	transform: translateY(-50%) !important;
 	right: 0;
+	background: #fff !important;
 }
 
 .preview-link-wrapper {
@@ -284,7 +285,7 @@ body.trashing #publish-settings {
 .customize-copy-preview-link:before,
 .customize-copy-preview-link:after {
 	content: "";
-	height: 32px;
+	height: 40px;
 	position: absolute;
 	background: #fff;
 	top: 0;

src/wp-admin/css/dashboard.css

@@ -219,20 +219,19 @@
 }
 
 .welcome-panel .welcome-panel-close {
+	display: flex;
+	align-items: center;
 	position: absolute;
 	top: 10px;
 	right: 10px;
-	padding: 10px 15px 10px 24px;
+	padding: 10px 15px;
 	font-size: 13px;
 	line-height: 1.23076923; /* Chrome rounding, needs to be 16px equivalent */
 	text-decoration: none;
 	z-index: 1; /* Raise above the version image. */
 }
 
 .welcome-panel .welcome-panel-close:before {
-	position: absolute;
-	top: 8px;
-	left: 0;
 	transition: all .1s ease-in-out;
 	content: '\f335';
 	font-size: 24px;
@@ -721,14 +720,6 @@ body #dashboard-widgets .postbox form .submit {
 	margin-bottom: 10px;
 }
 
-#dashboard_right_now .inside {
-	padding: 0;
-}
-
-#dashboard_right_now .main {
-	padding: 16px 16px 11px;
-}
-
 #dashboard_right_now .main p {
 	margin: 0;
 }

src/wp-admin/css/edit.css

@@ -76,10 +76,16 @@
 	pointer-events: none;
 }
 
+#titlewrap .skiplink {
+	background: #fff;
+	line-height: 2.30769231; /* 30px for 32px min-height */
+	min-height: 32px;
+	right: 4px;
+}
+
 #titlewrap .skiplink:focus {
 	clip: inherit;
 	clip-path: inherit;
-	right: 4px;
 	top: 4px;
 	width: auto;
 }
@@ -1061,10 +1067,6 @@ form#tags-filter {
 	#edit-slug-box {
 		padding: 0;
 	}
-
-	#titlewrap .skiplink:focus {
-		top: 5px;
-	}
 }
 
 @media only screen and (max-width: 1004px) {

src/wp-admin/css/list-tables.css

@@ -1424,7 +1424,7 @@ ul.cat-checklist input[name="post_category[]"]:indeterminate::before {
 	content: "\f463";
 	content: "\f463" / '';
 	display: inline-block;
-	font: normal 20px/1.9 dashicons; /* line-height 1.9 = 38px to match button */
+	font: normal 16px/1.875 dashicons; /* line-height 1.875 = 30px to match button */
 	margin: 0 5px 0 -2px;
 	-webkit-font-smoothing: antialiased;
 	-moz-osx-font-smoothing: grayscale;
@@ -1452,6 +1452,14 @@ ul.cat-checklist input[name="post_category[]"]:indeterminate::before {
 	content: "\f147" / '';
 }
 
+.plugin-card .updated-message:before,
+.plugin-card .updating-message:before {
+	line-height: 1;
+	position: relative;
+	top: -2px;
+	vertical-align: middle;
+}
+
 .plugin-install-php #the-list {
 	display: flex;
 	flex-wrap: wrap;
@@ -1567,6 +1575,13 @@ div.action-links,
 	margin: 0; /* Override existing margins */
 }
 
+/* Use compact size for space-constrained plugin cards */
+.plugin-action-buttons li .button {
+	min-height: 32px;
+	line-height: 2.30769231; /* 30px for 32px min-height */
+	padding: 0 12px;
+}
+
 .plugin-card h3 {
 	margin: 0 12px 12px 0;
 	font-size: 18px;

src/wp-admin/css/login.css

@@ -49,7 +49,7 @@ p {
 	margin-top: 0;
 	margin-left: 0;
 	margin-bottom: 20px;
-	background-color: transparent;
+	background-color: #fff;
 	word-wrap: break-word;
 }
 

src/wp-admin/css/themes.css

@@ -114,6 +114,8 @@ body.js .theme-browser.search-loading {
 }
 
 /* Use compact size for space-constrained theme cards */
+.theme-browser .theme .theme-actions .button.updated-message,
+.theme-browser .theme .theme-actions .button.updating-message,
 .theme-browser .theme .theme-actions .button {
 	float: none;
 	margin-left: 3px;
@@ -122,6 +124,14 @@ body.js .theme-browser.search-loading {
 	padding: 0 12px;
 }
 
+.theme-browser .theme .theme-actions .button.updated-message::before,
+.theme-browser .theme .theme-actions .button.updating-message::before {
+	line-height: 1;
+	vertical-align: text-bottom;
+	position: relative;
+	top: 2px;
+}
+
 /* Secondary buttons need white background for visibility on semi-transparent overlay */
 .theme-browser .theme .theme-actions .button:not(.button-primary) {
 	background: #fff;

src/wp-admin/includes/class-wp-media-list-table.php

@@ -490,10 +490,8 @@ public function column_title( $post ) {
 
 		if ( current_user_can( 'edit_post', $post->ID ) && ! $this->is_trash ) {
 			$link_start = sprintf(
-				'<a href="%s" aria-label="%s">',
+				'<a href="%s">',
 				get_edit_post_link( $post->ID ),
-				/* translators: %s: Attachment title. */
-				esc_attr( sprintf( __( '&#8220;%s&#8221; (Edit)' ), $title ) )
 			);
 			$link_end = '</a>';
 		}

src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -37,8 +37,8 @@ class WP_MS_Themes_List_Table extends WP_List_Table {
 	 *
 	 * @see WP_List_Table::__construct() for more information on default arguments.
 	 *
-	 * @global string $status
-	 * @global int    $page
+	 * @global string $status The current theme status.
+	 * @global int    $page   The current page number.
 	 *
 	 * @param array $args An associative array of arguments.
 	 */
@@ -70,15 +70,19 @@ public function __construct( $args = array() ) {
 	}
 
 	/**
-	 * @return array
+	 * Gets the list of CSS classes for the table tag.
+	 *
+	 * @return string[] The list of CSS classes.
 	 */
 	protected function get_table_classes() {
 		// @todo Remove and add CSS for .themes.
 		return array( 'widefat', 'plugins' );
 	}
 
 	/**
-	 * @return bool
+	 * Checks if the current user has permissions to perform AJAX actions.
+	 *
+	 * @return bool True if the current user has permissions, false otherwise.
 	 */
 	public function ajax_user_can() {
 		if ( $this->is_site_themes ) {
@@ -89,12 +93,14 @@ public function ajax_user_can() {
 	}
 
 	/**
-	 * @global string $status
-	 * @global array $totals
-	 * @global int $page
-	 * @global string $orderby
-	 * @global string $order
-	 * @global string $s
+	 * Prepares the themes list for display.
+	 *
+	 * @global string             $status  The current theme status.
+	 * @global array<string, int> $totals  An array of theme counts for each status.
+	 * @global int                $page    The current page number.
+	 * @global string             $orderby The column to order the themes list by.
+	 * @global string             $order   The order of the themes list (ASC or DESC).
+	 * @global string             $s       The search string.
 	 */
 	public function prepare_items() {
 		global $status, $totals, $page, $orderby, $order, $s;
@@ -261,8 +267,10 @@ public function prepare_items() {
 	}
 
 	/**
-	 * @param WP_Theme $theme
-	 * @return bool
+	 * Filters a theme by the search term.
+	 *
+	 * @param WP_Theme $theme The WP_Theme object to check.
+	 * @return bool True if the theme matches the search term, false otherwise.
 	 */
 	public function _search_callback( $theme ) {
 		static $term = null;
@@ -290,11 +298,14 @@ public function _search_callback( $theme ) {
 
 	// Not used by any core columns.
 	/**
-	 * @global string $orderby
-	 * @global string $order
-	 * @param array $theme_a
-	 * @param array $theme_b
-	 * @return int
+	 * Compares the order of two themes by a specific field.
+	 *
+	 * @global string $orderby The column to order the themes list by.
+	 * @global string $order   The order of the themes list (ASC or DESC).
+	 *
+	 * @param WP_Theme $theme_a The first theme to compare.
+	 * @param WP_Theme $theme_b The second theme to compare.
+	 * @return int 0 if equal, -1 if the first is less than the second, 1 if more.
 	 */
 	public function _order_callback( $theme_a, $theme_b ) {
 		global $orderby, $order;
@@ -308,6 +319,7 @@ public function _order_callback( $theme_a, $theme_b ) {
 	}
 
 	/**
+	 * Displays the message when there are no items to list.
 	 */
 	public function no_items() {
 		if ( $this->has_items ) {
@@ -318,7 +330,9 @@ public function no_items() {
 	}
 
 	/**
-	 * @return string[] Array of column titles keyed by their column name.
+	 * Gets the list of columns for the list table.
+	 *
+	 * @return array<string, string> Array of column titles keyed by their column name.
 	 */
 	public function get_columns() {
 		$columns = array(
@@ -335,7 +349,9 @@ public function get_columns() {
 	}
 
 	/**
-	 * @return array
+	 * Gets the list of sortable columns for the list table.
+	 *
+	 * @return array<string, array<int, mixed>> An array of sortable columns.
 	 */
 	protected function get_sortable_columns() {
 		return array(
@@ -355,9 +371,12 @@ protected function get_primary_column_name() {
 	}
 
 	/**
-	 * @global array $totals
-	 * @global string $status
-	 * @return array
+	 * Gets the list of views (statuses) for the list table.
+	 *
+	 * @global array<string, int> $totals An array of theme counts for each status.
+	 * @global string             $status The current theme status.
+	 *
+	 * @return array<string, string> The list of views.
 	 */
 	protected function get_views() {
 		global $totals, $status;
@@ -451,9 +470,11 @@ protected function get_views() {
 	}
 
 	/**
-	 * @global string $status
+	 * Gets the list of bulk actions for the list table.
+	 *
+	 * @global string $status The current theme status.
 	 *
-	 * @return array
+	 * @return array<string, string> The list of bulk actions.
 	 */
 	protected function get_bulk_actions() {
 		global $status;
@@ -532,9 +553,9 @@ public function column_cb( $item ) {
 	 *
 	 * @since 4.3.0
 	 *
-	 * @global string $status
-	 * @global int    $page
-	 * @global string $s
+	 * @global string $status The current theme status.
+	 * @global int    $page   The current page number.
+	 * @global string $s      The search string.
 	 *
 	 * @param WP_Theme $theme The current WP_Theme object.
 	 */
@@ -689,8 +710,8 @@ public function column_name( $theme ) {
 	 *
 	 * @since 4.3.0
 	 *
-	 * @global string $status
-	 * @global array  $totals
+	 * @global string             $status The current theme status.
+	 * @global array<string, int> $totals An array of theme counts for each status.
 	 *
 	 * @param WP_Theme $theme The current WP_Theme object.
 	 */
@@ -777,8 +798,8 @@ public function column_description( $theme ) {
 	 *
 	 * @since 5.5.0
 	 *
-	 * @global string $status
-	 * @global int  $page
+	 * @global string $status The current theme status.
+	 * @global int    $page   The current page number.
 	 *
 	 * @param WP_Theme $theme The current WP_Theme object.
 	 */
@@ -979,10 +1000,12 @@ public function single_row_columns( $item ) {
 	}
 
 	/**
-	 * @global string $status
-	 * @global array  $totals
+	 * Handles the output for a single table row.
+	 *
+	 * @global string             $status The current theme status.
+	 * @global array<string, int> $totals An array of theme counts for each status.
 	 *
-	 * @param WP_Theme $theme
+	 * @param WP_Theme $theme The current WP_Theme object.
 	 */
 	public function single_row( $theme ) {
 		global $status, $totals;

src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1138,10 +1138,8 @@ public function column_title( $post ) {
 
 		if ( $can_edit_post && 'trash' !== $post->post_status ) {
 			printf(
-				'<a class="row-title" href="%s" aria-label="%s">%s%s</a>',
+				'<a class="row-title" href="%s">%s%s</a>',
 				get_edit_post_link( $post->ID ),
-				/* translators: %s: Post title. */
-				esc_attr( sprintf( __( '&#8220;%s&#8221; (Edit)' ), $title ) ),
 				$pad,
 				$title
 			);