Connectors: Address review feedback on PHPDoc and test improvements.

Removes the duplicate untyped `@param array` tag from
`_wp_connectors_get_connector_script_module_data()` left over after
applying the `@param array<string, mixed>` suggestion.

In `wpGetConnectors.php`, adds `void` return types to all test methods
for PHPStan level 8 compliance, and uses `?? null` when accessing
optional array keys (`setting_name`, `credentials_url`) so PHPStan
does not complain about potentially missing offsets.

Props gziolo, westonruter.
Fixes #64791.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

Author: gziolo

src/wp-includes/connectors.php

@@ -536,7 +536,6 @@ function _wp_connectors_pass_default_keys_to_ai_client(): void {
  * @since 7.0.0
  * @access private
  *
- * @param array $data Existing script module data.
  * @param array<string, mixed> $data Existing script module data.
  * @return array<string, mixed> Script module data with connectors added.
  */

tests/phpunit/tests/connectors/wpGetConnectors.php

@@ -15,23 +15,23 @@ class Tests_Connectors_WpGetConnectors extends WP_UnitTestCase {
 	/**
 	 * Registers the mock provider once before any tests in this class run.
 	 */
-	public static function set_up_before_class() {
+	public static function set_up_before_class(): void {
 		parent::set_up_before_class();
 		self::register_mock_connectors_provider();
 	}
 
 	/**
 	 * Unregisters the mock provider setting added by `init`.
 	 */
-	public static function tear_down_after_class() {
+	public static function tear_down_after_class(): void {
 		self::unregister_mock_connector_setting();
 		parent::tear_down_after_class();
 	}
 
 	/**
 	 * @ticket 64730
 	 */
-	public function test_returns_expected_connector_keys() {
+	public function test_returns_expected_connector_keys(): void {
 		$connectors = wp_get_connectors();
 
 		$this->assertArrayHasKey( 'google', $connectors );
@@ -44,7 +44,7 @@ public function test_returns_expected_connector_keys() {
 	/**
 	 * @ticket 64730
 	 */
-	public function test_each_connector_has_required_fields() {
+	public function test_each_connector_has_required_fields(): void {
 		$connectors = wp_get_connectors();
 
 		$this->assertNotEmpty( $connectors, 'Connector settings should not be empty.' );
@@ -67,7 +67,7 @@ public function test_each_connector_has_required_fields() {
 	/**
 	 * @ticket 64730
 	 */
-	public function test_api_key_connectors_have_setting_name_and_credentials_url() {
+	public function test_api_key_connectors_have_setting_name_and_credentials_url(): void {
 		$connectors    = wp_get_connectors();
 		$api_key_count = 0;
 
@@ -81,7 +81,7 @@ public function test_api_key_connectors_have_setting_name_and_credentials_url()
 			$this->assertArrayHasKey( 'setting_name', $connector_data['authentication'], "Connector '{$connector_id}' authentication is missing 'setting_name'." );
 			$this->assertSame(
 				"connectors_ai_{$connector_id}_api_key",
-				$connector_data['authentication']['setting_name'],
+				$connector_data['authentication']['setting_name'] ?? null,
 				"Connector '{$connector_id}' setting_name does not match expected format."
 			);
 			$this->assertArrayHasKey( 'credentials_url', $connector_data['authentication'], "Connector '{$connector_id}' authentication is missing 'credentials_url'." );
@@ -93,7 +93,7 @@ public function test_api_key_connectors_have_setting_name_and_credentials_url()
 	/**
 	 * @ticket 64730
 	 */
-	public function test_featured_provider_names_match_expected() {
+	public function test_featured_provider_names_match_expected(): void {
 		$connectors = wp_get_connectors();
 
 		$this->assertSame( 'Google', $connectors['google']['name'] );
@@ -104,15 +104,15 @@ public function test_featured_provider_names_match_expected() {
 	/**
 	 * @ticket 64730
 	 */
-	public function test_includes_registered_provider_from_registry() {
+	public function test_includes_registered_provider_from_registry(): void {
 		$connectors = wp_get_connectors();
 		$mock       = $connectors['mock_connectors_test'];
 
 		$this->assertSame( 'Mock Connectors Test', $mock['name'] );
 		$this->assertSame( '', $mock['description'] );
 		$this->assertSame( 'ai_provider', $mock['type'] );
 		$this->assertSame( 'api_key', $mock['authentication']['method'] );
-		$this->assertNull( $mock['authentication']['credentials_url'] );
-		$this->assertSame( 'connectors_ai_mock_connectors_test_api_key', $mock['authentication']['setting_name'] );
+		$this->assertNull( $mock['authentication']['credentials_url'] ?? null );
+		$this->assertSame( 'connectors_ai_mock_connectors_test_api_key', $mock['authentication']['setting_name'] ?? null );
 	}
 }