Permalinks: Ignore malformed post type query arrays

Author: dhrupo

src/wp-includes/class-wp.php

@@ -382,7 +382,10 @@ public function parse_request( $extra_query_vars = '' ) {
 					unset( $this->query_vars['post_type'] );
 				}
 			} else {
-				$this->query_vars['post_type'] = array_intersect( $this->query_vars['post_type'], $queryable_post_types );
+				$this->query_vars['post_type'] = array_intersect(
+					array_filter( $this->query_vars['post_type'], 'is_scalar' ),
+					$queryable_post_types
+				);
 			}
 		}
 

tests/phpunit/tests/wp/parseRequest.php

@@ -56,4 +56,70 @@ static function ( $url ) {
 		$this->wp->parse_request();
 		$this->assertSame( '', $this->wp->request );
 	}
+
+	/**
+	 * @ticket 65123
+	 */
+	public function test_parse_request_ignores_non_scalar_post_type_values_from_get() {
+		$original_get     = $_GET;
+		$original_post    = $_POST;
+		$original_request = $_SERVER['REQUEST_URI'] ?? null;
+		$original_self    = $_SERVER['PHP_SELF'] ?? null;
+
+		$_GET['post_type']      = array( array( 'page' ), 'post' );
+		$_SERVER['REQUEST_URI'] = '/?post_type[][]=page&post_type[]=post';
+		$_SERVER['PHP_SELF']    = '/index.php';
+
+		$this->wp->parse_request();
+
+		$this->assertSame( array( 'post' ), array_values( $this->wp->query_vars['post_type'] ) );
+
+		$_GET  = $original_get;
+		$_POST = $original_post;
+
+		if ( null === $original_request ) {
+			unset( $_SERVER['REQUEST_URI'] );
+		} else {
+			$_SERVER['REQUEST_URI'] = $original_request;
+		}
+
+		if ( null === $original_self ) {
+			unset( $_SERVER['PHP_SELF'] );
+		} else {
+			$_SERVER['PHP_SELF'] = $original_self;
+		}
+	}
+
+	/**
+	 * @ticket 65123
+	 */
+	public function test_parse_request_ignores_non_scalar_post_type_values_from_post() {
+		$original_get     = $_GET;
+		$original_post    = $_POST;
+		$original_request = $_SERVER['REQUEST_URI'] ?? null;
+		$original_self    = $_SERVER['PHP_SELF'] ?? null;
+
+		$_POST['post_type']     = array( array( 'page' ), 'post' );
+		$_SERVER['REQUEST_URI'] = '/';
+		$_SERVER['PHP_SELF']    = '/index.php';
+
+		$this->wp->parse_request();
+
+		$this->assertSame( array( 'post' ), array_values( $this->wp->query_vars['post_type'] ) );
+
+		$_GET  = $original_get;
+		$_POST = $original_post;
+
+		if ( null === $original_request ) {
+			unset( $_SERVER['REQUEST_URI'] );
+		} else {
+			$_SERVER['REQUEST_URI'] = $original_request;
+		}
+
+		if ( null === $original_self ) {
+			unset( $_SERVER['PHP_SELF'] );
+		} else {
+			$_SERVER['PHP_SELF'] = $original_self;
+		}
+	}
 }