Skip to content

Commit bacdfcf

Browse files
author
Paul Bearne
committed
Remove error suppression from iis7_rewrite_rule_exists() tests and align array keys
1 parent 0764cb9 commit bacdfcf

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

tests/phpunit/tests/admin/includes/misc/iis7RewriteRuleExists.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ public function tear_down() {
4646
*/
4747
public function test_iis7_rewrite_rule_exists( $expected, $content ) {
4848
if ( 'Not XML' === $content ) {
49-
@file_put_contents( $this->temp_file, $content );
50-
$this->assertSame( $expected, @iis7_rewrite_rule_exists( $this->temp_file ) );
49+
file_put_contents( $this->temp_file, $content );
50+
$this->assertSame( $expected, iis7_rewrite_rule_exists( $this->temp_file ) );
5151
} else {
5252
file_put_contents( $this->temp_file, $content );
5353
$this->assertSame( $expected, iis7_rewrite_rule_exists( $this->temp_file ) );
@@ -61,27 +61,27 @@ public function test_iis7_rewrite_rule_exists( $expected, $content ) {
6161
*/
6262
public function data_iis7_rewrite_rule_exists(): array {
6363
return array(
64-
'Rule with name "wordpress" exists' => array(
64+
'Rule with name "wordpress" exists' => array(
6565
'expected' => true,
6666
'content' => '<configuration><system.webServer><rewrite><rules><rule name="wordpress" /></rules></rewrite></system.webServer></configuration>',
6767
),
68-
'Rule with name "WordPress" exists' => array(
68+
'Rule with name "WordPress" exists' => array(
6969
'expected' => true,
7070
'content' => '<configuration><system.webServer><rewrite><rules><rule name="WordPress" /></rules></rewrite></system.webServer></configuration>',
7171
),
7272
'Rule with name starting with "wordpress" exists' => array(
7373
'expected' => true,
7474
'content' => '<configuration><system.webServer><rewrite><rules><rule name="wordpress-rules" /></rules></rewrite></system.webServer></configuration>',
7575
),
76-
'Rule does not exist' => array(
76+
'Rule does not exist' => array(
7777
'expected' => false,
7878
'content' => '<configuration><system.webServer><rewrite><rules><rule name="other-rule" /></rules></rewrite></system.webServer></configuration>',
7979
),
80-
'Empty configuration' => array(
80+
'Empty configuration' => array(
8181
'expected' => false,
8282
'content' => '<configuration />',
8383
),
84-
'Invalid XML' => array(
84+
'Invalid XML' => array(
8585
'expected' => false,
8686
'content' => 'Not XML',
8787
),

0 commit comments

Comments
 (0)