Connectors: Defer plugin.is_active check to connector retrieval.

Previously, `WP_Connector_Registry::register()` silently filled in `__return_true` when no `is_active` callback was provided, which made it impossible for consumers to distinguish "no callback supplied" from "callback always returns true." Defer the check to call sites instead, so the stored connector data reflects what was actually registered.

Update `_wp_register_default_connector_settings()` and `_wp_connectors_get_connector_script_module_data()` to treat a missing callback as active, matching the documented `Defaults to __return_true` semantics.

See #65020.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

Author: t-hamano

src/wp-includes/class-wp-connector-registry.php

@@ -270,10 +270,6 @@ public function register( string $id, array $args ): ?array {
 			}
 		}
 
-		if ( ! isset( $connector['plugin']['is_active'] ) ) {
-			$connector['plugin']['is_active'] = '__return_true';
-		}
-
 		$this->registered_connectors[ $id ] = $connector;
 		return $connector;
 	}

src/wp-includes/connectors.php

@@ -682,8 +682,13 @@ function _wp_connectors_get_connector_script_module_data( array $data ): array {
 		);
 
 		if ( ! empty( $connector_data['plugin']['file'] ) ) {
-			$file         = $connector_data['plugin']['file'];
-			$is_activated = (bool) call_user_func( $connector_data['plugin']['is_active'] );
+			$file = $connector_data['plugin']['file'];
+			if ( ! isset( $connector_data['plugin']['is_active'] ) ) {
+				// Assume plugin has registered own connector and is therefore active.
+				$is_activated = true;
+			} else {
+				$is_activated = (bool) call_user_func( $connector_data['plugin']['is_active'] );
+			}
 			$is_installed = $is_activated || file_exists( wp_normalize_path( WP_PLUGIN_DIR . '/' . $file ) );
 
 			$connector_out['plugin'] = array(

tests/phpunit/tests/connectors/wpConnectorRegistry.php

@@ -339,15 +339,14 @@ public function test_register_rejects_non_callable_plugin_is_active() {
 	/**
 	 * @ticket 65020
 	 */
-	public function test_register_defaults_plugin_is_active_to_return_true() {
+	public function test_register_omits_plugin_is_active_when_not_provided() {
 		$args           = self::$default_args;
 		$args['plugin'] = array( 'file' => 'my-plugin/my-plugin.php' );
 
 		$result = $this->registry->register( 'default-callback', $args );
 
 		$this->assertIsArray( $result );
-		$this->assertArrayHasKey( 'is_active', $result['plugin'] );
-		$this->assertSame( '__return_true', $result['plugin']['is_active'] );
+		$this->assertArrayNotHasKey( 'is_active', $result['plugin'] );
 	}
 
 	/**
@@ -358,7 +357,7 @@ public function test_register_defaults_plugin_when_not_provided() {
 
 		$this->assertArrayHasKey( 'plugin', $result );
 		$this->assertArrayNotHasKey( 'file', $result['plugin'] );
-		$this->assertSame( '__return_true', $result['plugin']['is_active'] );
+		$this->assertArrayNotHasKey( 'is_active', $result['plugin'] );
 	}
 
 	/**