Skip to content

Commit a931a3f

Browse files
committed
fix(rest-api): handle null in prepare_items_query()
Use null coalescing to default to an empty array instead of wrapping the loop in an is_array() check in WP_REST_Posts_Controller and WP_REST_Revisions_Controller.
1 parent fdafcd3 commit a931a3f

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,8 @@ public function delete_item( $request ) {
12101210
* @return array Items query arguments.
12111211
*/
12121212
protected function prepare_items_query( $prepared_args = array(), $request = null ) {
1213-
$query_args = array();
1213+
$query_args = array();
1214+
$prepared_args = $prepared_args ?? array();
12141215

12151216
foreach ( $prepared_args as $key => $value ) {
12161217
/**

src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,8 @@ public function delete_item( $request ) {
548548
* @return array Items query arguments.
549549
*/
550550
protected function prepare_items_query( $prepared_args = array(), $request = null ) {
551-
$query_args = array();
551+
$query_args = array();
552+
$prepared_args = $prepared_args ?? array();
552553

553554
foreach ( $prepared_args as $key => $value ) {
554555
/** This filter is documented in wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php */

0 commit comments

Comments
 (0)