Use MockAction for content_url test, drop spy from the others

Replace the bespoke by-ref-closure spy (not used elsewhere in
tests/phpunit/) with the idiomatic MockAction helper. Keep the spy
only on test_unparseable_content_url_returns_false, where the early
return is the only thing distinguishing the new branch from the
fallback path tail-end load_script_translations(false, ...) call.

The other two tests do not need a spy: removing the early return for
unparseable src triggers the "Automatic conversion of false to array"
deprecation, and reverting the is_string guard triggers a TypeError
in str_ends_with() -- both surface as test failures already.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>

Author: westonruter

tests/phpunit/tests/l10n/loadScriptTextdomain.php

@@ -173,28 +173,6 @@ public function test_does_not_throw_deprecation_notice_for_rtrim_with_default_pa
 		$this->assertSame( $expected, load_script_textdomain( $handle ) );
 	}
 
-	/**
-	 * Records every `$file` value passed to `load_script_translations()`
-	 * so individual tests can assert which code path produced the result.
-	 *
-	 * @return list<string|false> Reference to the array updated by the spy filter.
-	 */
-	private function &spy_load_script_translations_files(): array {
-		/** @var list<string|false> $files_seen */
-		$files_seen = array();
-		add_filter(
-			'pre_load_script_translations',
-			static function ( $translations, $file ) use ( &$files_seen ) {
-				assert( is_string( $file ) || false === $file );
-				$files_seen[] = $file;
-				return $translations;
-			},
-			10,
-			2
-		);
-		return $files_seen;
-	}
-
 	/**
 	 * Tests that an unparseable script source URL short-circuits to
 	 * `load_script_translations( false, ... )` instead of falling through
@@ -208,26 +186,22 @@ public function test_unparseable_src_returns_false(): void {
 
 		$this->assertFalse( wp_parse_url( $src ), 'Test prerequisite failed: the test src should be unparseable.' );
 
-		$files_seen = &$this->spy_load_script_translations_files();
-
 		wp_enqueue_script( $handle, $src, array(), null );
 
 		$this->assertFalse( load_script_textdomain( $handle, 'default', DIR_TESTDATA . '/languages' ) );
-		$this->assertSame(
-			array(
-				DIR_TESTDATA . '/languages/en_US-' . $handle . '.json',
-				false,
-			),
-			$files_seen,
-			'Expected the unparseable $src branch to short-circuit before any relative-path lookup.'
-		);
 	}
 
 	/**
 	 * Tests that an unparseable `content_url()` return value short-circuits
 	 * to `load_script_translations( false, ... )` instead of computing
 	 * `$relative` from a corrupted parsed-URL array.
 	 *
+	 * The `MockAction` spy on `pre_load_script_translations` is necessary
+	 * here because the function's tail end also calls `load_script_translations( false, ... )`,
+	 * so a regression that bypasses the early return would still return false
+	 * via the fallback path. Asserting on the recorded `$file` arguments pins
+	 * the test to the intended branch.
+	 *
 	 * @ticket 65015
 	 */
 	public function test_unparseable_content_url_returns_false(): void {
@@ -241,7 +215,8 @@ static function () {
 			}
 		);
 
-		$files_seen = &$this->spy_load_script_translations_files();
+		$mock = new MockAction();
+		add_filter( 'pre_load_script_translations', array( $mock, 'filter' ), 10, 4 );
 
 		wp_enqueue_script( $handle, $src, array(), null );
 
@@ -251,7 +226,7 @@ static function () {
 				DIR_TESTDATA . '/languages/en_US-' . $handle . '.json',
 				false,
 			),
-			$files_seen,
+			array_column( $mock->get_args(), 1 ),
 			'Expected the unparseable content_url branch to short-circuit before any relative-path lookup.'
 		);
 	}
@@ -270,19 +245,9 @@ public function test_non_string_relative_path_filter_returns_false(): void {
 
 		add_filter( 'load_script_textdomain_relative_path', '__return_null' );
 
-		$files_seen = &$this->spy_load_script_translations_files();
-
 		wp_enqueue_script( $handle, $src, array(), null );
 
 		$this->assertFalse( load_script_textdomain( $handle, 'default', DIR_TESTDATA . '/languages' ) );
-		$this->assertSame(
-			array(
-				DIR_TESTDATA . '/languages/en_US-' . $handle . '.json',
-				false,
-			),
-			$files_seen,
-			'Expected the non-string $relative branch to short-circuit before md5 path computation.'
-		);
 	}
 
 	/**