Merge branch 'trunk' into fix/issue-36409-comment-count

Author: hbhalodia

.github/workflows/test-old-branches.yml

@@ -25,7 +25,7 @@ on:
 permissions: {}
 
 env:
-  CURRENTLY_SUPPORTED_BRANCH: '6.8'
+  CURRENTLY_SUPPORTED_BRANCH: '6.9'
 
 jobs:
   dispatch-workflows-for-old-branches:

.github/workflows/upgrade-develop-testing.yml

@@ -51,7 +51,15 @@ jobs:
     permissions:
       contents: read
 
-  # Run upgrade tests for the current branch.
+# Because the number of jobs spawned can quickly balloon out of control, the following methodology is applied when
+# building out the matrix below:
+#
+# - The two most recent releases of WordPress are always tested.
+# - After a branch is created, the pre-release version is also added.
+# - The oldest version of WordPress receiving security updates as a courtesy that also runs on a PHP version supported by trunk
+#   should always be tested.
+# - PHP and DB versions are kept to a minimum. In general this should be the highest and lowest supported versions of each with excludes
+#   being updated to keep the matrix as small as is reasonable.
   upgrade-tests-develop:
     name: Upgrade from ${{ matrix.wp }}
     uses: ./.github/workflows/reusable-upgrade-testing.yml
@@ -67,7 +75,7 @@ jobs:
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.4' ]
         # WordPress 5.3 is the oldest version that supports PHP 7.4.
-        wp: [ '5.3', '6.7', '6.8', '6.9-RC1' ]
+        wp: [ '5.3', '6.8', '6.9' ]
         multisite: [ false, true ]
     with:
       os: ${{ matrix.os }}
@@ -93,7 +101,7 @@ jobs:
         php: [ '7.4', '8.4' ]
         db-type: [ 'mysql' ]
         db-version: [ '8.4' ]
-        wp: [ '6.7', '6.8' ]
+        wp: [ '6.8', '6.9' ]
         multisite: [ false, true ]
     with:
       os: ${{ matrix.os }}

.github/workflows/upgrade-testing.yml

@@ -71,7 +71,7 @@ jobs:
         php: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5' ]
         db-type: [ 'mysql' ]
         db-version: [ '5.7', '8.0', '8.4', '9.6' ]
-        wp: [ '6.7', '6.8' ]
+        wp: [ '6.8', '6.9' ]
         multisite: [ false, true ]
     with:
       os: ${{ matrix.os }}

src/wp-admin/css/forms.css

@@ -1057,7 +1057,7 @@ table.form-table td .updated p {
 
 .application-password-display input.code {
 	margin-bottom: 6px;
-	width: 19em;
+	width: 20em;
 }
 
 .auth-app-card.card {

src/wp-admin/includes/post.php

@@ -2564,7 +2564,7 @@ function the_block_editor_meta_box_post_form_hidden_fields( $post ) {
 	$classic_output = ob_get_clean();
 
 	$classic_elements = wp_html_split( $classic_output );
-	$hidden_inputs    = '';
+
 	foreach ( $classic_elements as $element ) {
 		if ( ! str_starts_with( $element, '<input ' ) ) {
 			continue;

src/wp-includes/post.php

@@ -2599,8 +2599,9 @@ function is_post_embeddable( $post = null ) {
  * @see WP_Query
  * @see WP_Query::parse_query()
  *
- * @param array $args {
- *     Optional. Arguments to retrieve posts. See WP_Query::parse_query() for all available arguments.
+ * @param array|string $args {
+ *     Optional. Array or query string of arguments to retrieve posts.
+ *     See WP_Query::parse_query() for all available arguments.
  *
  *     @type int        $numberposts      Total number of posts to retrieve. Is an alias of `$posts_per_page`
  *                                        in WP_Query. Accepts -1 for all. Default 5.

tests/phpunit/tests/post/getPosts.php

@@ -163,4 +163,17 @@ public function test_explicit_offset_non_0_should_override_paged() {
 
 		$this->assertSame( array( $p3 ), $found );
 	}
+
+	/**
+	 * Verifies that get_posts() accepts a query string for the `$args` parameter.
+	 *
+	 * @ticket 64813
+	 */
+	public function test_should_accept_query_string_args(): void {
+		self::factory()->post->create();
+		$second_post_id = self::factory()->post->create();
+		$found_post_ids = get_posts( 'numberposts=1&fields=ids' );
+
+		$this->assertSame( array( $second_post_id ), $found_post_ids );
+	}
 }