Extract md5 hashing to get_room_hash()

Author: mindctrl

src/wp-includes/collaboration/class-wp-sync-post-meta-storage.php

@@ -84,8 +84,7 @@ public function add_update( string $room, $update ): bool {
 		);
 
 		if ( $meta_id ) {
-			$room_hash = md5( $room );
-			wp_cache_delete( "sync_room_state_{$room_hash}", 'sync' );
+			wp_cache_delete( "sync_room_state_{$this->get_room_hash( $room )}", 'sync' );
 		}
 
 		return (bool) $meta_id;
@@ -100,8 +99,7 @@ public function add_update( string $room, $update ): bool {
 	 * @return array<int, mixed> Awareness state.
 	 */
 	public function get_awareness_state( string $room ): array {
-		$room_hash = md5( $room );
-		$awareness = get_transient( "sync_awareness_{$room_hash}" );
+		$awareness = get_transient( "sync_awareness_{$this->get_room_hash( $room )}" );
 
 		if ( ! is_array( $awareness ) ) {
 			return array();
@@ -120,8 +118,7 @@ public function get_awareness_state( string $room ): array {
 	 * @return bool True on success, false on failure.
 	 */
 	public function set_awareness_state( string $room, array $awareness ): bool {
-		$room_hash = md5( $room );
-		return set_transient( "sync_awareness_{$room_hash}", $awareness, MINUTE_IN_SECONDS );
+		return set_transient( "sync_awareness_{$this->get_room_hash( $room )}", $awareness, MINUTE_IN_SECONDS );
 	}
 
 	/**
@@ -151,7 +148,7 @@ public function get_cursor( string $room ): int {
 	 * @return int|null Post ID.
 	 */
 	private function get_storage_post_id( string $room ): ?int {
-		$room_hash = md5( $room );
+		$room_hash = $this->get_room_hash( $room );
 
 		if ( isset( self::$storage_post_ids[ $room_hash ] ) ) {
 			return self::$storage_post_ids[ $room_hash ];
@@ -216,7 +213,7 @@ public function get_update_count( string $room ): int {
 	public function get_updates_after_cursor( string $room, int $cursor ): array {
 		global $wpdb;
 
-		$room_hash       = md5( $room );
+		$room_hash       = $this->get_room_hash( $room );
 		$state_cache_key = "sync_room_state_{$room_hash}";
 		$cached          = wp_cache_get( $state_cache_key, 'sync' );
 
@@ -316,8 +313,7 @@ public function remove_updates_before_cursor( string $room, int $cursor ): bool
 
 		if ( $deleted_rows > 0 ) {
 			wp_cache_delete( $post_id, 'post_meta' );
-			$room_hash = md5( $room );
-			wp_cache_delete( "sync_room_state_{$room_hash}", 'sync' );
+			wp_cache_delete( "sync_room_state_{$this->get_room_hash( $room )}", 'sync' );
 		}
 
 		return true;
@@ -352,4 +348,19 @@ private function with_suspended_posts_last_changed_update( Closure $callback ) {
 		}
 		return $return_value;
 	}
+
+	/**
+	 * Returns a hash of the room identifier.
+	 *
+	 * Used as the post slug for storage posts, as a segment in cache keys,
+	 * and as part of transient names.
+	 *
+	 * @since 7.0.0
+	 *
+	 * @param string $room Room identifier.
+	 * @return string MD5 hash of the room.
+	 */
+	private function get_room_hash( string $room ): string {
+		return md5( $room );
+	}
 }