Refactor Chromium version tests to use dataProvider

Author: adamsilverstein

tests/phpunit/tests/media/wpGetChromiumMajorVersion.php

@@ -29,43 +29,41 @@ public function tear_down() {
 		parent::tear_down();
 	}
 
+	/**
+	 * @ticket 64766
+	 */
 	public function test_returns_null_when_no_user_agent() {
 		unset( $_SERVER['HTTP_USER_AGENT'] );
 		$this->assertNull( wp_get_chromium_major_version() );
 	}
 
-	public function test_returns_null_for_empty_user_agent() {
-		$_SERVER['HTTP_USER_AGENT'] = '';
-		$this->assertNull( wp_get_chromium_major_version() );
-	}
-
-	public function test_returns_null_for_firefox() {
-		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; rv:128.0) Gecko/20100101 Firefox/128.0';
-		$this->assertNull( wp_get_chromium_major_version() );
-	}
-
-	public function test_returns_null_for_safari() {
-		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15';
-		$this->assertNull( wp_get_chromium_major_version() );
-	}
-
-	public function test_returns_version_for_chrome() {
-		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36';
-		$this->assertSame( 137, wp_get_chromium_major_version() );
-	}
-
-	public function test_returns_version_for_edge() {
-		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36 Edg/137.0.0.0';
-		$this->assertSame( 137, wp_get_chromium_major_version() );
-	}
-
-	public function test_returns_version_for_opera() {
-		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36 OPR/122.0.0.0';
-		$this->assertSame( 136, wp_get_chromium_major_version() );
+	/**
+	 * @ticket 64766
+	 *
+	 * @dataProvider data_user_agents
+	 *
+	 * @param string   $user_agent The user agent string.
+	 * @param int|null $expected   The expected Chromium major version, or null.
+	 */
+	public function test_returns_expected_version( $user_agent, $expected ) {
+		$_SERVER['HTTP_USER_AGENT'] = $user_agent;
+		$this->assertSame( $expected, wp_get_chromium_major_version() );
 	}
 
-	public function test_returns_version_for_older_chrome() {
-		$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36';
-		$this->assertSame( 100, wp_get_chromium_major_version() );
+	/**
+	 * Data provider for test_returns_expected_version.
+	 *
+	 * @return array[]
+	 */
+	public function data_user_agents() {
+		return array(
+			'empty user agent'  => array( '', null ),
+			'Firefox'           => array( 'Mozilla/5.0 (Windows NT 10.0; rv:128.0) Gecko/20100101 Firefox/128.0', null ),
+			'Safari'            => array( 'Mozilla/5.0 (Macintosh; Intel Mac OS X 14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15', null ),
+			'Chrome 137'        => array( 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36', 137 ),
+			'Edge 137'          => array( 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36 Edg/137.0.0.0', 137 ),
+			'Opera (Chrome 136)' => array( 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36 OPR/122.0.0.0', 136 ),
+			'Chrome 100'        => array( 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36', 100 ),
+		);
 	}
 }