Dynamically determine maximum level in PHPStan baseline generator

The generate-baselines.sh script now automatically reads the maximum level from phpstan.neon or phpstan.neon.dist instead of using a hardcoded value.

Additionally, the script was updated to use indexed arrays for compatibility with Bash 3.2 (macOS default), and the README was updated to reflect these changes and fix minor typos.

Co-authored-by: gemini-cli <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: westonruter

tests/phpstan/README.md

@@ -89,7 +89,7 @@ Sometimes, due to the lack of type information in legacy code, PHPStan may still
 
 The `generate-baselines.sh` script is a helper tool to generate per-level baseline files for triaging PHPStan errors. It iterates through the specified levels, generates a baseline for each level, and outputs a summary of the results.
 
-The process relies on iteration, and assumes that the baseline for the previous level has been freshly generated to capture any new/remediated errors on that level before generating the next level's baseline.
+The process relies on iteration, and assumes that the baseline for the previous level has been freshly generated to capture any new/remediated errors on that level before generating the next level's baseline. The maximum level is automatically determined from the `level` parameter in `phpstan.neon` (or `phpstan.neon.dist`).
 
 ### Usage
 
@@ -98,8 +98,7 @@ To run the script, use the following command:
 ```bash
 bash tests/phpstan/generate-baselines.sh --all # to generate baselines for all levels
 bash tests/phpstan/generate-baselines.sh --start=1 --end=3 # to generate baselines for levels 1 to 3
-bash tests/phpstan/generate-baselines.sh --level=6 # to generate a baseline for level 2 only. ASSUMES that the baseline for level 1 has been freshly generated.
+bash tests/phpstan/generate-baselines.sh --level=6 # to generate a baseline for level 6 only. ASSUMES that the baseline for the previous level has been freshly generated.
 bash tests/phpstan/generate-baselines.sh --summary-only # to only output the summary of results for the existing baselines, without regenerating them.
 
 ```
-To change the max level, update the `MAX_LEVEL` variable at the top of the script, alongside any changes to the root `phpstan.neon.dist` file to add the new level.

tests/phpstan/generate-baselines.sh

@@ -2,14 +2,27 @@
 # generate-baselines.sh
 # Generate PHPStan baseline files for each level
 
-set -e
+# Determine MAX_LEVEL from configuration files
+MAX_LEVEL=""
+if [[ -f "phpstan.neon" ]]; then
+  MAX_LEVEL=$(sed -n 's/^[[:space:]]*level:[[:space:]]*\([0-9]\+\)/\1/p' "phpstan.neon" | head -n 1)
+fi
+
+if [[ -z "$MAX_LEVEL" ]] && [[ -f "phpstan.neon.dist" ]]; then
+  MAX_LEVEL=$(sed -n 's/^[[:space:]]*level:[[:space:]]*\([0-9]\+\)/\1/p' "phpstan.neon.dist" | head -n 1)
+fi
 
-MAX_LEVEL=6  # Change this when adding new levels
+MAX_LEVEL=${MAX_LEVEL:-0}
+
+if (( MAX_LEVEL == 0 )); then
+  echo "Notice: Maximum level is 0. No per-level baselines to generate for levels 1 and above."
+  exit 0
+fi
 
 LEVEL_START=""
 LEVEL_END=""
-declare -A BEFORE_COUNTS
-declare -A AFTER_COUNTS
+declare -a BEFORE_COUNTS
+declare -a AFTER_COUNTS
 
 usage() {
   cat <<EOF