Merge branch 'trunk' into collaboration/table-awareness-object-cache

Author: peterwilsoncc

src/wp-admin/css/forms.css

@@ -583,6 +583,11 @@ input[type="number"].tiny-text {
 	vertical-align: middle;
 }
 
+.button.wp-hide-pw.user-new-password-toggle > .dashicons {
+	line-height: 1.85;
+	vertical-align: top;
+}
+
 .wp-cancel-pw .dashicons-no {
 	display: none;
 }

src/wp-admin/user-edit.php

@@ -695,7 +695,7 @@
 											<input type="password" name="pass1" id="pass1" class="regular-text ltr" value="" autocomplete="new-password" spellcheck="false" data-pw="<?php echo esc_attr( wp_generate_password( 24 ) ); ?>" aria-describedby="pass-strength-result" />
 											<div style="display:none" id="pass-strength-result" aria-live="polite"></div>
 										</div>
-										<button type="button" class="button wp-hide-pw hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
+										<button type="button" class="button wp-hide-pw user-new-password-toggle hide-if-no-js" data-toggle="0" aria-label="<?php esc_attr_e( 'Hide password' ); ?>">
 											<span class="dashicons dashicons-hidden" aria-hidden="true"></span>
 											<span class="text"><?php _e( 'Hide' ); ?></span>
 										</button>

tests/phpunit/tests/blocks/registerBlockTypeFromMetadataWithRegistry.php

@@ -3,6 +3,8 @@
  * Tests for WP_Block_Metadata_Registry integration with register_block_type_from_metadata().
  *
  * @group blocks
+ *
+ * @covers ::register_block_type_from_metadata
  */
 class Tests_Blocks_RegisterBlockTypeFromMetadataWithRegistry extends WP_UnitTestCase {
 	private $temp_manifest_file;

tests/phpunit/tests/blocks/wpBlockParser.php

@@ -7,6 +7,8 @@
  * @since 5.0.0
  *
  * @group blocks
+ *
+ * @coversDefaultClass WP_Block_Parser
  */
 class Tests_Blocks_wpBlockParser extends WP_UnitTestCase {
 	/**
@@ -17,35 +19,11 @@ class Tests_Blocks_wpBlockParser extends WP_UnitTestCase {
 	 */
 	protected static $fixtures_dir;
 
-	/**
-	 * @ticket 45109
-	 */
-	public function data_parsing_test_filenames() {
-		self::$fixtures_dir = DIR_TESTDATA . '/blocks/fixtures';
-
-		$fixture_filenames = array_merge(
-			glob( self::$fixtures_dir . '/*.json' ),
-			glob( self::$fixtures_dir . '/*.html' )
-		);
-
-		$fixture_filenames = array_values(
-			array_unique(
-				array_map(
-					array( $this, 'clean_fixture_filename' ),
-					$fixture_filenames
-				)
-			)
-		);
-
-		return array_map(
-			array( $this, 'pass_parser_fixture_filenames' ),
-			$fixture_filenames
-		);
-	}
-
 	/**
 	 * @dataProvider data_parsing_test_filenames
 	 * @ticket 45109
+	 *
+	 * @covers ::parse
 	 */
 	public function test_default_parser_output( $html_filename, $parsed_json_filename ) {
 		$html_path        = self::$fixtures_dir . '/' . $html_filename;
@@ -70,6 +48,32 @@ public function test_default_parser_output( $html_filename, $parsed_json_filenam
 		);
 	}
 
+	/**
+	 * @ticket 45109
+	 */
+	public function data_parsing_test_filenames() {
+		self::$fixtures_dir = DIR_TESTDATA . '/blocks/fixtures';
+
+		$fixture_filenames = array_merge(
+			glob( self::$fixtures_dir . '/*.json' ),
+			glob( self::$fixtures_dir . '/*.html' )
+		);
+
+		$fixture_filenames = array_values(
+			array_unique(
+				array_map(
+					array( $this, 'clean_fixture_filename' ),
+					$fixture_filenames
+				)
+			)
+		);
+
+		return array_map(
+			array( $this, 'pass_parser_fixture_filenames' ),
+			$fixture_filenames
+		);
+	}
+
 	/**
 	 * Helper function to remove relative paths and extension from a filename, leaving just the fixture name.
 	 *