General: Use DataProvider in unit tests

Suggested by Mukesh Panchal.

I also added some tests for sanitize_email, for which there were none
before. They didn't break, I just felt that having some is better than
having none.

Author: arnt

tests/phpunit/tests/formatting/antispambot.php

@@ -6,22 +6,32 @@
  * @covers ::antispambot
  */
 class Tests_Formatting_antispambot extends WP_UnitTestCase {
-	public function test_returns_valid_utf8() {
-		$data = array(
-			'[email protected]',
-			'[email protected]',
-			'[email protected]',
-			'[email protected]',
-			'[email protected]',
-			'[email protected]',
-			'[email protected]',
-			'info@grå.org',
-			'grå@grå.org',
-			"gr\u{0061}\u{030a}blå@grå.org",
-			'[email protected]',
+
+	/**
+	 * This is basically a driveby test. While working on ticket
+	 * 31992 I noticed that there was no unit testing for
+		 * antispambot, so I added a little, just so I'd leave
+		 * the code better than I found it.
+	 *
+	 * @ticket 31992
+	 *
+	 * @dataProvider data_returns_valid_utf8
+	 */
+
+	public function test_returns_valid_utf8( $address, $validity ) {
+		$this->assertSame( seems_utf8( antispambot( $address ) ), $validity );
+	}
+
+	public function data_returns_valid_utf8() {
+		return array(
+			'plain'                => array( '[email protected]', true ),
+			'plain with ip'        => array( '[email protected]', true ),
+			'deep subdomain'       => array( '[email protected]', true ),
+			'short address'        => array( '[email protected]', true ),
+			'ascii@nonascii'       => array( 'info@grå.org', true ),
+			'nonascii@nonascii'    => array( 'grå@grå.org', true ),
+			'decomposed unicode'   => array( 'gr\u{0061}\u{030a}blå@grå.org', true ),
+			'weird but legal dots' => array( '[email protected]', true ),
 		);
-		foreach ( $data as $datum ) {
-			$this->assertTrue( seems_utf8( antispambot( $datum ) ) );
-		}
 	}
 }

tests/phpunit/tests/formatting/sanitizeEmail.php

@@ -0,0 +1,26 @@
+<?php
+
+/**
+ * @group formatting
+ *
+ * @covers ::sanitize_email
+ */
+class Tests_Formatting_SanitizeEmail extends WP_UnitTestCase {
+	public function data_for_sanitation() {
+		return array(
+			'shorter than 6 characters' => array( 'a@b', '' ),
+			'contains no @'             => array( 'ab', '' ),
+			'just a TLD'                => array( 'abc@com', '' ),
+			'plain'                     => array( '[email protected]', '[email protected]' ),
+		);
+	}
+
+	/**
+	* @ticket 31992
+	* @dataProvider data_for_sanitation
+	*/
+
+	public function test_returns_stripped_email_address( $address, $expected ) {
+		$this->assertSame( sanitize_email( $address ), $expected );
+	}
+}