Use filters instead of setting option value

Author: chriszarate

tests/phpunit/tests/rest-api/rest-autosaves-controller.php

@@ -570,9 +570,6 @@ public function test_rest_autosave_published_post() {
 	}
 
 	public function test_rest_autosave_draft_post_same_author() {
-		$original_option = get_option( 'enable_real_time_collaboration' );
-		update_option( 'enable_real_time_collaboration', false );
-
 		wp_set_current_user( self::$editor_id );
 
 		$post_data = array(
@@ -592,10 +589,15 @@ public function test_rest_autosave_draft_post_same_author() {
 		$request->add_header( 'Content-Type', 'application/json' );
 		$request->set_body( wp_json_encode( $autosave_data ) );
 
+		// Behavior differs depending on whether real-time collaboration is enabled.
+		add_filter( 'pre_option_enable_real_time_collaboration', '__return_zero' );
+
 		$response = rest_get_server()->dispatch( $request );
 		$new_data = $response->get_data();
 		$post     = get_post( $post_id );
 
+		remove_filter( 'pre_option_enable_real_time_collaboration', '__return_zero' );
+
 		$this->assertSame( $post_id, $new_data['id'] );
 		// The draft post should be updated.
 		$this->assertSame( $autosave_data['content'], $new_data['content']['raw'] );
@@ -607,7 +609,6 @@ public function test_rest_autosave_draft_post_same_author() {
 		$this->assertSame( $post_data['post_excerpt'], $post->post_excerpt );
 
 		wp_delete_post( $post_id );
-		update_option( 'enable_real_time_collaboration', $original_option );
 	}
 
 	public function test_rest_autosave_draft_post_different_author() {
@@ -748,9 +749,6 @@ public function test_get_item_sets_up_postdata() {
 	}
 
 	public function test_update_item_draft_page_with_parent() {
-		$original_option = get_option( 'enable_real_time_collaboration' );
-		update_option( 'enable_real_time_collaboration', false );
-
 		wp_set_current_user( self::$editor_id );
 		$request = new WP_REST_Request( 'POST', '/wp/v2/pages/' . self::$child_draft_page_id . '/autosaves' );
 		$request->add_header( 'Content-Type', 'application/x-www-form-urlencoded' );
@@ -762,13 +760,18 @@ public function test_update_item_draft_page_with_parent() {
 			)
 		);
 
+		// Behavior differs depending on whether real-time collaboration is enabled.
+		add_filter( 'pre_option_enable_real_time_collaboration', '__return_zero' );
+
 		$request->set_body_params( $params );
 		$response = rest_get_server()->dispatch( $request );
 		$data     = $response->get_data();
 
+		remove_filter( 'pre_option_enable_real_time_collaboration', '__return_zero' );
+
 		$this->assertSame( self::$child_draft_page_id, $data['id'] );
 		$this->assertSame( self::$parent_page_id, $data['parent'] );
-		update_option( 'enable_real_time_collaboration', $original_option );
+
 	}
 
 	public function test_schema_validation_is_applied() {
@@ -932,11 +935,10 @@ public static function data_head_request_with_specified_fields_returns_success_r
 	/**
 	 * When real-time collaboration is enabled, autosaving a draft post by the
 	 * same author should create a revision instead of updating the post directly.
+	 *
+	 * @ticket 64622
 	 */
 	public function test_rest_autosave_draft_post_same_author_with_rtc() {
-		$original_option = get_option( 'enable_real_time_collaboration' );
-		update_option( 'enable_real_time_collaboration', true );
-
 		wp_set_current_user( self::$editor_id );
 
 		$post_data = array(
@@ -952,6 +954,9 @@ public function test_rest_autosave_draft_post_same_author_with_rtc() {
 			'title'   => 'Updated post title',
 		);
 
+		// Behavior differs depending on whether real-time collaboration is enabled.
+		add_filter( 'pre_option_enable_real_time_collaboration', '__return_true' );
+
 		$request = new WP_REST_Request( 'POST', '/wp/v2/posts/' . self::$post_id . '/autosaves' );
 		$request->add_header( 'Content-Type', 'application/json' );
 		$request->set_body( wp_json_encode( $autosave_data ) );
@@ -960,6 +965,8 @@ public function test_rest_autosave_draft_post_same_author_with_rtc() {
 		$new_data = $response->get_data();
 		$post     = get_post( $post_id );
 
+		remove_filter( 'pre_option_enable_real_time_collaboration', '__return_true' );
+
 		// With RTC enabled, a revision is created instead of updating the post.
 		$this->assertNotSame( $post_id, $new_data['id'] );
 		$this->assertSame( $post_id, $new_data['parent'] );
@@ -974,17 +981,13 @@ public function test_rest_autosave_draft_post_same_author_with_rtc() {
 		$this->assertSame( $post_data['post_excerpt'], $post->post_excerpt );
 
 		wp_delete_post( $post_id );
-		update_option( 'enable_real_time_collaboration', $original_option );
 	}
 
 	/**
 	 * When real-time collaboration is enabled, autosaving a draft page with
 	 * a parent should create a revision instead of updating the page directly.
 	 */
 	public function test_update_item_draft_page_with_parent_with_rtc() {
-		$original_option = get_option( 'enable_real_time_collaboration' );
-		update_option( 'enable_real_time_collaboration', true );
-
 		wp_set_current_user( self::$editor_id );
 		$request = new WP_REST_Request( 'POST', '/wp/v2/pages/' . self::$child_draft_page_id . '/autosaves' );
 		$request->add_header( 'Content-Type', 'application/x-www-form-urlencoded' );
@@ -996,13 +999,17 @@ public function test_update_item_draft_page_with_parent_with_rtc() {
 			)
 		);
 
+		// Behavior differs depending on whether real-time collaboration is enabled.
+		add_filter( 'pre_option_enable_real_time_collaboration', '__return_true' );
+
 		$request->set_body_params( $params );
 		$response = rest_get_server()->dispatch( $request );
 		$data     = $response->get_data();
 
+		remove_filter( 'pre_option_enable_real_time_collaboration', '__return_true' );
+
 		// With RTC enabled, a revision is created instead of updating the page.
 		$this->assertNotSame( self::$child_draft_page_id, $data['id'] );
 		$this->assertSame( self::$child_draft_page_id, $data['parent'] );
-		update_option( 'enable_real_time_collaboration', $original_option );
 	}
 }