Icons library: Register all icons found in manifest

As of WordPress/gutenberg#75684, icons' manifest.php
file only lists "public" icons, and in the process the now-redundant `"public"
=> true` flag was dropped.

Accordingly, this removes the check for the `public` flag from the icon
registry's registration logic.

Follow-up to [61674].

Props mcsf, wildworks, ellatrix.
Fixes #64651.



git-svn-id: https://develop.svn.wordpress.org/trunk@61675 602fd350-edb4-49c9-b593-d223f7449a82

Author: mcsf

src/wp-includes/class-wp-icons-registry.php

@@ -38,8 +38,7 @@ class WP_Icons_Registry {
 	 *
 	 * These icons are defined in @wordpress/packages (Gutenberg repository) as
 	 * SVG files and as entries in a single manifest file. On init, the
-	 * registry is loaded with those icons in the manifest which are marked
-	 * `public`.
+	 * registry is loaded with those icons listed in the manifest.
 	 */
 	private function __construct() {
 		$icons_directory = __DIR__ . '/icons/';
@@ -77,10 +76,6 @@ private function __construct() {
 				return;
 			}
 
-			if ( ! ( $icon_data['public'] ?? false ) ) {
-				continue;
-			}
-
 			$this->register(
 				'core/' . $icon_name,
 				array(