Skip to content

Commit 45bf1fe

Browse files
Mamadukaramonjdsidhant-tomar-003t-hamanoshimotmk
authored
Image: Hide 'Set as featured image' for in-editor revisions (#76123)
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: sidhant-tomar-003 <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: shimotmk <[email protected]>
1 parent d37cda8 commit 45bf1fe

2 files changed

Lines changed: 15 additions & 15 deletions

File tree

  • packages
    • block-editor/src/components/block-settings-menu-controls
    • block-library/src/image

packages/block-editor/src/components/block-settings-menu-controls/index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ const BlockSettingsMenuControlsSlot = ( { fillProps, clientIds = null } ) => {
7979
<Slot
8080
fillProps={ {
8181
...fillProps,
82+
canEdit,
8283
selectedBlocks,
8384
selectedClientIds,
8485
} }

packages/block-library/src/image/image.js

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,21 +1241,20 @@ export default function Image( {
12411241
} );
12421242
};
12431243

1244-
const featuredImageControl = (
1245-
<BlockSettingsMenuControls>
1246-
{ ( { selectedClientIds } ) =>
1247-
selectedClientIds.length === 1 &&
1248-
! isDescendentOfQueryLoop &&
1249-
postId &&
1250-
id &&
1251-
clientId === selectedClientIds[ 0 ] && (
1252-
<MenuItem onClick={ setPostFeatureImage }>
1253-
{ __( 'Set as featured image' ) }
1254-
</MenuItem>
1255-
)
1256-
}
1257-
</BlockSettingsMenuControls>
1258-
);
1244+
const featuredImageControl =
1245+
! isDescendentOfQueryLoop && postId && id ? (
1246+
<BlockSettingsMenuControls>
1247+
{ ( { canEdit, selectedClientIds } ) =>
1248+
canEdit &&
1249+
selectedClientIds.length === 1 &&
1250+
clientId === selectedClientIds[ 0 ] && (
1251+
<MenuItem onClick={ setPostFeatureImage }>
1252+
{ __( 'Set as featured image' ) }
1253+
</MenuItem>
1254+
)
1255+
}
1256+
</BlockSettingsMenuControls>
1257+
) : null;
12591258

12601259
return (
12611260
<>

0 commit comments

Comments
 (0)