Make type hint annotations clickable (#17)

* Minor refactoring for binary expressions

* Add support for click on inlay hint and move to referenced element in editor

* Fix condition for ignore __ parameters

* Remove empty space

* Remove unused variable

* Fix render for dict types

* Fix async functions resolving

* Remove debug printl

Author: divaltor

gradle.properties

@@ -1,6 +1,6 @@
 pluginGroup = space.whitememory.pythoninlayparams
 pluginName = Python Inlay Params
-pluginVersion = 0.2.1
+pluginVersion = 0.3.0
 
 # See https://plugins.jetbrains.com/docs/intellij/build-number-ranges.html
 # for insight into build numbers and IntelliJ Platform versions.

src/main/kotlin/space/whitememory/pythoninlayparams/PythonInlayParameterHintsProvider.kt

@@ -156,7 +156,7 @@ class PythonInlayParameterHintsProvider : InlayParameterHintsProvider {
      * If the argument is very similar, we don't need to show it.
      */
     private fun isHintNameValid(paramName: String, argument: PyExpression): Boolean {
-        if (paramName.startsWith("__") && paramName.length == 1) return false
+        if (paramName.startsWith("__") || paramName.length == 1) return false
 
         val argumentName = if (argument is PySubscriptionExpression) {
             // It's a __getitem__ call (subscription), let's take the argument name from it

src/main/kotlin/space/whitememory/pythoninlayparams/types/AbstractPythonInlayTypeHintsCollector.kt

@@ -2,12 +2,15 @@ package space.whitememory.pythoninlayparams.types
 
 import com.intellij.codeInsight.hints.FactoryInlayHintsCollector
 import com.intellij.codeInsight.hints.InlayHintsSink
+import com.intellij.codeInsight.hints.presentation.InlayPresentation
 import com.intellij.openapi.editor.Editor
 import com.intellij.psi.PsiElement
 import com.jetbrains.python.psi.PyElement
 import com.jetbrains.python.psi.types.TypeEvalContext
 import space.whitememory.pythoninlayparams.types.hints.HintGenerator
 import space.whitememory.pythoninlayparams.types.hints.HintResolver
+import space.whitememory.pythoninlayparams.types.hints.InlayInfoDetails
+import space.whitememory.pythoninlayparams.types.hints.PsiInlayInfoDetail
 
 @Suppress("UnstableApiUsage")
 abstract class AbstractPythonInlayTypeHintsCollector(editor: Editor, open val settings: Any) :
@@ -24,10 +27,93 @@ abstract class AbstractPythonInlayTypeHintsCollector(editor: Editor, open val se
         val typeAnnotation = HintResolver.getExpressionAnnotationType(element, typeEvalContext)
         val hintName = HintGenerator.generateTypeHintText(element, typeAnnotation, typeEvalContext)
 
-        displayTypeHint(element, sink, hintName)
+        if (hintName.isEmpty()) {
+            return
+        }
+
+        val resolvedHintName = resolveInlayPresentation(hintName)
+
+        displayTypeHint(element, sink, resolvedHintName)
+    }
+
+    private fun resolveInlayPresentation(
+        infoDetails: List<InlayInfoDetails>,
+        separator: String = " | ",
+        limit: Int? = 3
+    ): InlayPresentation {
+        val convertedInlayInfoDetails = infoDetails.map { getInlayPresentationForInlayInfoDetails(it) }
+
+        return factory.seq(*separatePresentation(convertedInlayInfoDetails, separator, limit).toTypedArray())
+    }
+
+    private fun getInlayPresentationForInlayInfoDetails(infoDetail: InlayInfoDetails): InlayPresentation {
+        if (infoDetail.rootInlayInfo == null) {
+            return resolveInlayPresentation(infoDetail.details, separator = infoDetail.separator, limit = infoDetail.limit)
+        }
+
+        val textPresentation = factory.smallText(infoDetail.rootInlayInfo.text)
+        val navigationElementProvider: (() -> PsiElement?)? = when(infoDetail.rootInlayInfo) {
+            is PsiInlayInfoDetail -> {{ infoDetail.rootInlayInfo.element }}
+            else -> null
+        }
+
+        val basePresentation = navigationElementProvider?.let {
+            factory.psiSingleReference(textPresentation, it)
+        } ?: textPresentation
+
+        if (infoDetail.details.isEmpty()) {
+            return basePresentation
+        }
+
+        val childDetails = infoDetail.details.map { getInlayPresentationForInlayInfoDetails(it) }
+
+        return factory.seq(
+            basePresentation,
+            factory.smallText("["),
+            *separatePresentation(
+                childDetails,
+                separator = infoDetail.separator,
+                limit = infoDetail.limit
+            ).toTypedArray(),
+            factory.smallText("]")
+        )
+    }
+
+    private fun separatePresentation(
+        presentations: List<InlayPresentation>,
+        separator: String,
+        limit: Int?
+    ): List<InlayPresentation> {
+        if (presentations.size <= 1) {
+            return presentations
+        }
+
+        val separatedInlayPresentation = mutableListOf<InlayPresentation>()
+
+        val iterator = presentations.iterator()
+        var count = 0
+
+        while (iterator.hasNext()) {
+            if (limit != null && count == limit) {
+                if (iterator.hasNext()) {
+                    separatedInlayPresentation.add(factory.smallText("..."))
+                }
+                break
+            }
+
+            separatedInlayPresentation.add(iterator.next())
+
+            count = count.inc()
+
+            if (iterator.hasNext() && (limit != null && count != limit)) {
+                separatedInlayPresentation.add(factory.smallText(separator))
+            }
+        }
+
+        return separatedInlayPresentation
     }
 
-    abstract fun displayTypeHint(element: PyElement, sink: InlayHintsSink, hintName: String)
+    abstract fun displayTypeHint(element: PyElement, sink: InlayHintsSink, hintName: InlayPresentation)
 
     override fun collect(element: PsiElement, editor: Editor, sink: InlayHintsSink): Boolean {
         if (!element.isValid || element.project.isDefault) {

src/main/kotlin/space/whitememory/pythoninlayparams/types/functions/PythonFunctionInlayTypeHintsCollector.kt

@@ -1,6 +1,7 @@
 package space.whitememory.pythoninlayparams.types.functions
 
 import com.intellij.codeInsight.hints.InlayHintsSink
+import com.intellij.codeInsight.hints.presentation.InlayPresentation
 import com.intellij.openapi.editor.Editor
 import com.intellij.psi.PsiElement
 import com.intellij.psi.tree.TokenSet
@@ -53,14 +54,14 @@ class PythonFunctionInlayTypeHintsCollector(editor: Editor, settings: Any) :
         return true
     }
 
-    override fun displayTypeHint(element: PyElement, sink: InlayHintsSink, hintName: String) {
+    override fun displayTypeHint(element: PyElement, sink: InlayHintsSink, hintName: InlayPresentation) {
         val statementList = PsiTreeUtil.getChildOfType(element, PyParameterList::class.java)
 
         statementList?.let {
             sink.addInlineElement(
                 it.endOffset,
                 false,
-                factory.roundWithBackground(factory.smallText("$textBeforeTypeHint $hintName")),
+                factory.roundWithBackground(factory.seq(factory.smallText("$textBeforeTypeHint "), hintName)),
                 false
             )
         }