Skip to content

Commit 7a3b14e

Browse files
misc: minor improvements
1 parent 7f34450 commit 7a3b14e

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

src/test/java/org/variantsync/vevos/simulation/variability/sequenceextraction/LongestNonOverlappingSequencesTest.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.variantsync.vevos.simulation.variability.sequenceextraction;
22

3+
import org.junit.Assert;
34
import org.junit.Test;
45
import org.variantsync.functjonal.list.NonEmptyList;
56
import org.variantsync.vevos.simulation.variability.SPLCommit;
@@ -54,13 +55,15 @@ public void exampleExtraction() {
5455
LongestNonOverlappingSequences algorithm = new LongestNonOverlappingSequences();
5556
List<NonEmptyList<SPLCommit>> result = algorithm.extract(exampleCommits);
5657

57-
assert result.size() == 3;
58-
assert sequencesAreEqual(result.get(0), expectedOne);
59-
assert sequencesAreEqual(result.get(1), expectedTwo);
60-
assert sequencesAreEqual(result.get(2), expectedThree);
58+
Assert.assertEquals(result.size(), 3);
59+
Assert.assertTrue(sequencesAreEqual(result.get(0), expectedOne));
60+
Assert.assertTrue(sequencesAreEqual(result.get(1), expectedTwo));
61+
Assert.assertTrue(sequencesAreEqual(result.get(2), expectedThree));
6162
}
6263

6364
@Test
65+
// This test caused a StackoverflowError for the previous implementation of LongestNonOverlappingSequences at
66+
// confirms that the Error is no longer thrown.
6467
public void stackOverflowPrevented() {
6568
int size = 10_000;
6669
Set<SPLCommit> commits = new HashSet<>();
@@ -76,8 +79,9 @@ public void stackOverflowPrevented() {
7679

7780
LongestNonOverlappingSequences algo = new LongestNonOverlappingSequences();
7881
var result = algo.extract(commits);
79-
assert result.size() == 1;
80-
assert result.get(0).size() == size;
82+
// Some sanity checks (i.e., is the sequence extracted correctly?)
83+
Assert.assertEquals(1, result.size());
84+
Assert.assertEquals(result.get(0).size(), size);
8185
}
8286

8387
private boolean sequencesAreEqual(final NonEmptyList<SPLCommit> a, final NonEmptyList<SPLCommit> b) {

0 commit comments

Comments
 (0)