Skip to content

Commit 70d766a

Browse files
Fixed some tests
1 parent bcd5e87 commit 70d766a

17 files changed

Lines changed: 8 additions & 15 deletions

File tree

src/test/java/de/variantsync/evolution/VariabilityDatasetLoaderTest.java

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
package de.variantsync.evolution;
22

33
import de.ovgu.featureide.fm.core.base.IFeatureModel;
4-
import de.variantsync.evolution.Main;
54
import de.variantsync.evolution.io.data.VariabilityDatasetLoader;
65
import de.variantsync.evolution.repository.Commit;
76
import de.variantsync.evolution.util.GitUtil;
87
import de.variantsync.evolution.variability.SPLCommit;
9-
import de.variantsync.evolution.variability.SequenceExtractors;
108
import de.variantsync.evolution.variability.VariabilityDataset;
119
import de.variantsync.evolution.variability.VariabilityHistory;
12-
import de.variantsync.evolution.variability.pc.Artefact;
10+
import de.variantsync.evolution.variability.sequenceextraction.LongestNonOverlappingSequences;
1311
import org.eclipse.jgit.api.errors.GitAPIException;
1412
import org.junit.Before;
1513
import org.junit.Test;
@@ -123,7 +121,7 @@ public void variabilityHistoryBuildCorrectly() {
123121
final var secondList = new String[]{"454f7da158fdf3fe4b3c3fc8110f6c15861f97fa", "600f60df96cdbbf3319085d8e777d7e66c96e013", "a54c3c30f2dff6dc36331f06360630b697b7562c", "38e15e31eabccf82d3183273240cd44f2dec9fa9", "741ee98bf3edee477c504726fdc482ae85adf0e5"};
124122
final var thirdList = new String[]{"c79e89cd49fc17be386ca026686dd01e0985a5ea", "48c073dfcfd0907f1e460628a7379b4bcbc8c737"};
125123

126-
final VariabilityHistory history = dataset.getVariabilityHistory(SequenceExtractors.longestNonOverlappingSequences());
124+
final VariabilityHistory history = dataset.getVariabilityHistory(new LongestNonOverlappingSequences());
127125
final var commitSequences = history.commitSequences();
128126
// Check the size
129127
assert commitSequences.size() == 3;
@@ -181,32 +179,28 @@ public void logsOfEachCommitAreLoaded() {
181179
@Test
182180
public void presenceConditionsOfSuccessCommitsAreLoaded() {
183181
for (final SPLCommit commit : dataset.getSuccessCommits()) {
184-
final Artefact trace = commit.presenceConditions().run().orElseThrow();
185-
assert trace != null;
186-
}
182+
assert commit.presenceConditions().run().isPresent();
183+
}
187184
}
188185

189186
@Test
190187
public void presenceConditionsOfIncompletePCCommitsAreLoaded() {
191188
for (final SPLCommit commit : dataset.getPartialSuccessCommits()) {
192-
final Artefact trace = commit.presenceConditions().run().orElseThrow();
193-
assert trace != null;
189+
assert commit.presenceConditions().run().isPresent();
194190
}
195191
}
196192

197193
@Test
198194
public void noPresenceConditionsForErrorCommits() {
199195
for (final SPLCommit commit : dataset.getErrorCommits()) {
200-
final Optional<Artefact> trace = commit.presenceConditions().run();
201-
assert trace.isEmpty();
196+
assert commit.presenceConditions().run().isEmpty();
202197
}
203198
}
204199

205200
@Test
206201
public void featureModelsOfSuccessCommitsAreLoaded() {
207202
for (final SPLCommit commit : dataset.getSuccessCommits()) {
208-
final IFeatureModel model = commit.featureModel().run().orElseThrow();
209-
assert model != null;
203+
assert commit.featureModel().run().isPresent();
210204
}
211205
}
212206

@@ -217,8 +211,7 @@ public void featureModelsOfIncompletePCCommitsAreLoaded() {
217211
// I added an invalid String to one of the commits
218212
continue;
219213
}
220-
final IFeatureModel model = commit.featureModel().run().orElseThrow();
221-
assert model != null;
214+
assert commit.featureModel().run().isPresent();
222215
}
223216
}
224217

src/test/resources/simple-variability-metadata/data/38e15e31eabccf82d3183273240cd44f2dec9fa9/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/38e15e31eabccf82d3183273240cd44f2dec9fa9/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/411129f5a1923ce107b2970311fdcea72e0b628b/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/411129f5a1923ce107b2970311fdcea72e0b628b/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/454f7da158fdf3fe4b3c3fc8110f6c15861f97fa/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/454f7da158fdf3fe4b3c3fc8110f6c15861f97fa/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/48c073dfcfd0907f1e460628a7379b4bcbc8c737/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/48c073dfcfd0907f1e460628a7379b4bcbc8c737/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/600f60df96cdbbf3319085d8e777d7e66c96e013/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/600f60df96cdbbf3319085d8e777d7e66c96e013/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/60dc6013409b060b6f68c34902b3390e26e585dd/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/60dc6013409b060b6f68c34902b3390e26e585dd/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/741ee98bf3edee477c504726fdc482ae85adf0e5/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/741ee98bf3edee477c504726fdc482ae85adf0e5/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/78fe3d306860e11e327a43cfce2c97748a34c1e1/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/78fe3d306860e11e327a43cfce2c97748a34c1e1/code-variability.spl.csv

File renamed without changes.

src/test/resources/simple-variability-metadata/data/a54c3c30f2dff6dc36331f06360630b697b7562c/code-variability.csv renamed to src/test/resources/simple-variability-metadata/data/a54c3c30f2dff6dc36331f06360630b697b7562c/code-variability.spl.csv

File renamed without changes.

0 commit comments

Comments
 (0)