Skip to content

Commit 1219c8f

Browse files
committed
changed variable names to be more descriptive
1 parent 6f744dc commit 1219c8f

3 files changed

Lines changed: 17 additions & 17 deletions

File tree

src/main/java/de/variantsync/evolution/variability/pc/Artefact.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,14 @@ default String prettyPrint() {
6868
return new PrettyPrinter().prettyPrint(this);
6969
}
7070

71-
default Result<Node, Exception> getPresenceConditionOf(final CaseSensitivePath path, final int lineNumber) {
72-
final LinePCQuery query = new LinePCQuery(path, lineNumber);
71+
default Result<Node, Exception> getPresenceConditionOf(final CaseSensitivePath relativePath, final int lineNumber) {
72+
final LinePCQuery query = new LinePCQuery(relativePath, lineNumber);
7373
accept(query);
7474
return query.getResult();
7575
}
7676

77-
default Result<Node, Exception> getPresenceConditionOf(final CaseSensitivePath path) {
78-
final FilePCQuery query = new FilePCQuery(path);
77+
default Result<Node, Exception> getPresenceConditionOf(final CaseSensitivePath relativePath) {
78+
final FilePCQuery query = new FilePCQuery(relativePath);
7979
accept(query);
8080
return query.getResult();
8181
}

src/main/java/de/variantsync/evolution/variability/pc/visitor/common/FilePCQuery.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.variantsync.evolution.variability.pc.visitor.common;
22

3-
import de.variantsync.evolution.util.io.CaseSensitivePath;
43
import de.variantsync.evolution.util.functional.Result;
4+
import de.variantsync.evolution.util.io.CaseSensitivePath;
55
import de.variantsync.evolution.variability.pc.ArtefactTree;
66
import de.variantsync.evolution.variability.pc.visitor.ArtefactVisitor;
77
import de.variantsync.evolution.variability.pc.visitor.LineBasedAnnotationVisitorFocus;
@@ -12,21 +12,21 @@
1212
import java.io.FileNotFoundException;
1313

1414
public class FilePCQuery implements ArtefactVisitor {
15-
private final CaseSensitivePath path;
15+
private final CaseSensitivePath relativePath;
1616

1717
private boolean fileFound = false;
1818
private Node result = null;
1919

20-
public FilePCQuery(final CaseSensitivePath path) {
21-
this.path = path;
20+
public FilePCQuery(final CaseSensitivePath relativePath) {
21+
this.relativePath = relativePath;
2222
}
2323

2424
public Result<Node, Exception> getResult() {
2525
if (fileFound) {
2626
return Result.Success(result);
2727
}
2828

29-
return Result.Failure(new FileNotFoundException("Could not find file " + path.toString() + "!"));
29+
return Result.Failure(new FileNotFoundException("Could not find file " + relativePath.toString() + "!"));
3030
}
3131

3232
@Override
@@ -38,7 +38,7 @@ public <C extends ArtefactTree<?>> void visitGenericArtefactTreeNode(final Synth
3838

3939
@Override
4040
public void visitSourceCodeFile(final SourceCodeFileVisitorFocus focus) {
41-
if (!fileFound && focus.getValue().getFile().equals(path)) {
41+
if (!fileFound && focus.getValue().getFile().equals(relativePath)) {
4242
result = focus.getValue().getPresenceCondition();
4343
fileFound = true;
4444
}

src/main/java/de/variantsync/evolution/variability/pc/visitor/common/LinePCQuery.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package de.variantsync.evolution.variability.pc.visitor.common;
22

3-
import de.variantsync.evolution.util.io.CaseSensitivePath;
43
import de.variantsync.evolution.util.functional.Result;
4+
import de.variantsync.evolution.util.io.CaseSensitivePath;
55
import de.variantsync.evolution.variability.pc.ArtefactTree;
66
import de.variantsync.evolution.variability.pc.LineBasedAnnotation;
77
import de.variantsync.evolution.variability.pc.SourceCodeFile;
@@ -14,15 +14,15 @@
1414
import java.io.FileNotFoundException;
1515

1616
public class LinePCQuery implements ArtefactVisitor {
17-
private final CaseSensitivePath path;
17+
private final CaseSensitivePath relativePath;
1818
private final int lineNumber;
1919

2020
private SourceCodeFile foundFile = null;
2121
private boolean lineFound = false;
2222
private Node result = null;
2323

24-
public LinePCQuery(final CaseSensitivePath path, final int lineNumber) {
25-
this.path = path;
24+
public LinePCQuery(final CaseSensitivePath relativePath, final int lineNumber) {
25+
this.relativePath = relativePath;
2626
this.lineNumber = lineNumber;
2727
}
2828

@@ -36,7 +36,7 @@ public Result<Node, Exception> getResult() {
3636
"Given line number "
3737
+ lineNumber
3838
+ " is not within bounds of file "
39-
+ path
39+
+ relativePath
4040
+ " that ranges from "
4141
+ foundFile.getRootAnnotation().getLineFrom()
4242
+ " to "
@@ -45,7 +45,7 @@ public Result<Node, Exception> getResult() {
4545
));
4646
}
4747

48-
return Result.Failure(new FileNotFoundException("Could not find file " + path.toString() + "!"));
48+
return Result.Failure(new FileNotFoundException("Could not find file " + relativePath.toString() + "!"));
4949
}
5050

5151
@Override
@@ -59,7 +59,7 @@ public <C extends ArtefactTree<?>> void visitGenericArtefactTreeNode(final Synth
5959
@Override
6060
public void visitSourceCodeFile(final SourceCodeFileVisitorFocus focus) {
6161
// Logger.info("visitSourceCodeFile(" + focus.getValue() + ")");
62-
if (foundFile == null && focus.getValue().getFile().equals(path)) {
62+
if (foundFile == null && focus.getValue().getFile().equals(relativePath)) {
6363
foundFile = focus.getValue();
6464
focus.skipRootAnnotationButVisitItsSubtrees(this);
6565
}

0 commit comments

Comments
 (0)