Switched to Alpine-based image

Author: AlexanderSchultheiss

Dockerfile

@@ -1,10 +1,8 @@
 # syntax=docker/dockerfile:1
-FROM ubuntu:20.04
+FROM alpine:3.14
 
 # Prepare the environment
-RUN apt-get update \
-    && apt-get install -y --no-install-recommends tzdata
-RUN apt-get install -y --no-install-recommends build-essential maven
+RUN apk add maven
 
 # Build the jar files
 WORKDIR /home/user
@@ -14,15 +12,19 @@ COPY pom.xml .
 RUN mvn package || exit
 
 
-FROM ubuntu:20.04
+FROM alpine:3.14
 
 # Create a user
 RUN adduser --disabled-password  --home /home/user --gecos '' user
 
-RUN apt-get update \
-    && apt-get install -y --no-install-recommends build-essential openjdk-11-jdk unzip python3.8 python3-pip
+RUN apk add --no-cache --upgrade bash
+RUN apk add --update openjdk11 unzip
+RUN apk add --no-cache tesseract-ocr python3 py3-pip py3-numpy && \
+    pip3 install --upgrade pip setuptools wheel && \
+    apk add --no-cache --virtual .build-deps gcc g++ zlib-dev make python3-dev py3-numpy-dev jpeg-dev && \
+    pip3 install matplotlib && \
+    apk del .build-deps
 
-RUN python3.8 -m pip install -U matplotlib
 # Copy all relevant files
 WORKDIR /home/user
 RUN mkdir -p ./experimental_subjects/argouml
@@ -50,5 +52,7 @@ RUN chown user:user /home/user -R
 RUN chmod +x run-experiments.sh
 RUN chmod +x entrypoint.sh
 
+RUN ls -l
+
 ENTRYPOINT ["./entrypoint.sh", "./run-experiments.sh"]
 USER user

README.md

@@ -31,6 +31,11 @@ Authors:
 }
 ```
 
+### Contact
+Please contact Alexander Schultheiß if you have any questions:
+* Mail: [[email protected]]([email protected])
+* Discord: AlexS#1561
+
 ## Obtaining the Artifacts
 Clone the repository to a location of your choice using [git](https://git-scm.com/):
   ```

artifact-evaluation/README.md

@@ -7,7 +7,7 @@ You can find the latest release of the package online.
 ### Zenodo
 To obtain the artifact from Zenodo, do the following:
 
-* Download the package from [Zenodo](https://doi.org/10.5281/zenodo.5111532) to a location of your choice.
+* Download the package from Zenodo to a location of your choice.
 * Unpack the archive
   * OS with built-in ZIP support (e.g., Windows 10, Most Unix-Based OS): 
     * `Right-click` on the zip file

artifact-evaluation/REVIEWS.md

@@ -3,15 +3,16 @@ We want to thank the reviewers for their helpful and valuable feedback. We will
 in the camera-ready submission. More complicated changes might be done in the future. 
 
 ## Review 1
-* (FUTURE WORK) Your Dockerfile is built on top of ubuntu:20.04, but that is a pretty hefty Docker image. I wonder if you could base it on something lighter, like buster-slim, or even Alpine?
-  * > This is a good idea and should be done for this artifact and other artifacts which we create. However, it is out of scope for the camera-ready release.
+* (DONE) Your Dockerfile is built on top of ubuntu:20.04, but that is a pretty hefty Docker image. I wonder if you could base it on something lighter, like buster-slim, or even Alpine?
+  * > We based our image on Alpine:3.14.
 * (DONE) The build-docker-image.sh script doesn't test whether you have rights to access the Docker daemon, and the README does not make clear if it should run with root privileges or not. It appears this requires a user that can use `docker` without resorting to root. I had to add my user to the Docker group, log out and back in:
   `sudo usermod -a -G docker $(id -u)`
   I think it may be good to clarify this in the instructions, or test for it in the script and warn the user.
-  * > We implemented the fix-perms solution shown in [1]
+  * > We implemented the fix-perms solution ([1]) that should take care of this problem
 * (DONE) In addition, the Docker image that you are building is not redistributable, as it is tied to the UID of the user building it. Rather than that, I would suggest using the "fix-perms" approach mentioned in the "Tips and Tricks of the Docker Captains" talk [1].
   * > This is a really cool suggestion, as we experienced difficulties when trying to get the permissions right. We implemented the solution proposed in the talk.
 * (DONE) I would make a further suggestion: run the Maven build in a different Docker stage, and then copy over the generated JAR to a minimal stage. You could further reduce the size of the Docker image that way [2].
+  * > We switched to a multi-stage build. 
 * (DONE) The artifact includes a validation option for the scripts, which takes a shorter time and helps checking that it is functional in less time. This already took about 1.5h, so I assume that a full run can take a good while!
   * > We reduced the validation duration by limiting the execution to specific subset ids.
 * (DONE) One note - another reviewer mentioned that a few additional imports were needed in order to use RaQuN as a library. Please touch up your documentation for your final version of the artifact.
@@ -32,6 +33,7 @@ in the camera-ready submission. More complicated changes might be done in the fu
   * > We implemented the fix-perms solution shown in [1]
 * (DONE) Also, for RQ3, the indicated time was still too long even for single instance as suggested, for usual evaluation process, so smaller size of dataset had to be used. An amendment was necessary to the parameter file and the Java source code.
   * > We fixed the argument parsing in AbstractRQRunner that caused a problem. We reduced the validation duration by limiting the execution to specific subset ids.
-* (DOING) As a side note, Python script evaluation.py runs outside of the Docker environment, except for validation, so the user is responsible to make sure the Python environment is set properly (it does not happen for validation task since it runs under Docker environment).
+* (OPEN) As a side note, Python script evaluation.py runs outside of the Docker environment, except for validation, so the user is responsible to make sure the Python environment is set properly (it does not happen for validation task since it runs under Docker environment).
 For example, when the tkinter environment is not set properly, it does not plot the graph for experiments other than the validation package.
 A warning would be quite helpful as there was no error message with that situation.
+  * > We were not able to reproduce this problem, as the validation is also run using the docker container and is called in line 22 of docker-resources/run-experiments.sh. Please inform us if you are experiencing this issue.

docker-resources/entrypoint.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+ls -l
 if [ "$(id -u)" = "0" ]; then
   # running on a developer laptop as root
   fix-perms -r -u user -g user /home/user

docker-resources/run-experiments.sh

@@ -19,7 +19,7 @@ if [ "$1" == 'evaluate' ]
 then
     echo "Running result evaluation"
     cd result_analysis_python || exit
-    python3.8 evaluation.py
+    python3 evaluation.py
     exit
 else
   echo "Copying jars"
@@ -61,7 +61,7 @@ else
       java -Xmx16G -jar RQ3Runner-jar-with-dependencies.jar quick-validation.properties 3
       echo "Running result evaluation"
       cd result_analysis_python || exit
-      python3.8 evaluation.py
+      python3 evaluation.py
   else
       echo "Either fully run a specific experiment one time (RQ1|RQ2|RQ3), run all experiments (run), evaluate the results (evaluate), or a do quick setup validation (validate)."
       echo "-- Bash Examples --"

experiment.bat

@@ -1,4 +1,5 @@
 @echo Starting %*
+@if not exist "results" mkdir results
 @docker run --rm -v "%cd%/results":"/home/user/results" match-experiments %*
 
 @pause

experiment.sh

@@ -1,5 +1,6 @@
 #! /bin/bash
 echo "Starting $1"
+mkdir results
 docker run --rm -v "$(pwd)/results":"/home/user/results" match-experiments "$@"
 
 echo "Done."