Skip to content

Commit c237849

Browse files
committed
fix: document hidden assumptions in MiningResultAccumulator
1 parent 683d99f commit c237849

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

src/main/java/org/variantsync/diffdetective/tablegen/MiningResultAccumulator.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,13 @@ public static Map<String, AnalysisResult> getAllTotalResultsIn(final Path folder
4848
final Map<String, AnalysisResult> results = new HashMap<>();
4949
for (final Path p : paths) {
5050
var result = new AnalysisResult();
51+
52+
// FIXME: Here, we actually have to use the Analysis::initializeResult method on all Hooks of the Analysis
53+
// that produced the results we accumulate. Maybe Java reflection can help?
54+
result.append(StatisticsAnalysis.RESULT, new StatisticsAnalysis.Result());
5155
result.append(ExplainedFilterSummary.KEY, new ExplainedFilterSummary());
5256
result.append(EditClassCount.KEY, new EditClassCount());
53-
result.append(StatisticsAnalysis.RESULT, new StatisticsAnalysis.Result());
57+
5458
result.setFrom(p);
5559
results.put(p.getParent().getFileName().toString(), result);
5660
}

0 commit comments

Comments
 (0)