refactor: Hide the fact that Repository uses Lazy for Git

Author: ibbem

src/main/java/org/variantsync/diffdetective/AnalysisRunner.java

@@ -132,14 +132,14 @@ public static void run(Options options, BiConsumer<Repository, Path> validation)
         if (options.preloadReposBeforeAnalysis()) {
             Logger.info("Preloading repositories:");
             for (final Repository repo : repos) {
-                repo.getGitRepo().run();
+                repo.preload();
             }
 
             if (options.pullRepositoriesBeforeAnalysis()) {
                 Logger.info("Updating repositories:");
                 for (final Repository repo : repos) {
                     try {
-                        Assert.assertTrue(repo.getGitRepo().run().pull().call().isSuccessful());
+                        Assert.assertTrue(repo.getGitRepo().pull().call().isSuccessful());
                     } catch (GitAPIException e) {
                         Logger.error(e, "Failed to pull repository '{}'", repo.getRepositoryName());
                     }

src/main/java/org/variantsync/diffdetective/datasets/DatasetFactory.java

@@ -104,15 +104,15 @@ public List<Repository> createAll(final Collection<DatasetDescription> datasets,
         if (preload) {
             Logger.info("Preloading repositories:");
             for (final Repository repo : repos) {
-                repo.getGitRepo().run();
+                repo.preload();
             }
         }
 
         if (pull) {
             Logger.info("Pulling repositories:");
             for (final Repository repo : repos) {
                 try {
-                    Assert.assertTrue(repo.getGitRepo().run().pull().call().isSuccessful());
+                    Assert.assertTrue(repo.getGitRepo().pull().call().isSuccessful());
                 } catch (GitAPIException e) {
                     Logger.error(e, "Failed to pull repository '{}'", repo.getRepositoryName());
                 }

src/main/java/org/variantsync/diffdetective/datasets/Repository.java

@@ -223,8 +223,15 @@ public PatchDiffParseOptions getParseOptions() {
 	/**
 	 * Returns the internal jgit representation of this repository that allows to inspect the repositories history and content.
 	 */
-	public Lazy<Git> getGitRepo() {
-		return git;
+	public Git getGitRepo() {
+		return git.run();
+	}
+
+	/**
+	 * Prepares the Git repository (e.g., clones it if necessary).
+	 */
+	public void preload() {
+		getGitRepo();
 	}
 
 	/**

src/main/java/org/variantsync/diffdetective/diff/git/GitDiffer.java

@@ -65,7 +65,7 @@ public class GitDiffer {
      * @param repository The repository for whose history to obtain diffs.
      */
     public GitDiffer(final Repository repository) {
-        this.git = repository.getGitRepo().run();
+        this.git = repository.getGitRepo();
         this.diffFilter = repository.getDiffFilter();
         this.parseOptions = repository.getParseOptions();
     }

src/main/java/org/variantsync/diffdetective/experiments/thesis_bm/ConstructionValidation.java

@@ -384,7 +384,7 @@ private VariationDiff<DiffLinesLabel> parseVariationTree(Analysis analysis, RevC
                  */
                 new CharacterFilterReader(
                     GitDiffer.getBeforeFullFile(
-                        analysis.getRepository().getGitRepo().run(),
+                        analysis.getRepository().getGitRepo(),
                         commit,
                         analysis.getCurrentPatch().getFileName(AFTER)),
                     0xfeff)) // BOM, same as GitDiffer.BOM_PATTERN

src/main/java/org/variantsync/diffdetective/variation/diff/parse/VariationDiffParser.java

@@ -432,7 +432,7 @@ private void addNode(DiffNode<DiffLinesLabel> newNode) throws DiffParseException
      * @throws IOException when an error occurred.
      */
     public static CommitDiff parseCommit(Repository repo, String commitHash) throws IOException {
-        final Git git = repo.getGitRepo().run();
+        final Git git = repo.getGitRepo();
         Assert.assertNotNull(git);
         final RevWalk revWalk = new RevWalk(git.getRepository());
         final RevCommit childCommit = revWalk.parseCommit(ObjectId.fromString(commitHash));