refactor: move initialization of NodeType based on AnnotationType to NodeType.java

Author: AlexanderSchultheiss

src/main/java/org/variantsync/diffdetective/variation/NodeType.java

@@ -1,7 +1,8 @@
 package org.variantsync.diffdetective.variation;
 
-import org.variantsync.diffdetective.variation.diff.DiffNode; // For Javadoc
-import org.variantsync.diffdetective.variation.tree.VariationNode; // For Javadoc
+import org.variantsync.diffdetective.feature.AnnotationType;
+import org.variantsync.diffdetective.variation.diff.DiffNode;
+import org.variantsync.diffdetective.variation.tree.VariationNode;
 
 /**
  * The type of nodes of a {@link DiffNode} and a {@link VariationNode}.
@@ -39,11 +40,11 @@ public boolean isAnnotation() {
 
     /**
      * Creates a NodeType from its value names.
-     * 
-     * @see Enum#name()
+     *
      * @param name a string that equals the name of one value of this enum (ignoring
      *             case)
      * @return The NodeType that has the given name
+     * @see Enum#name()
      */
     public static NodeType fromName(final String name) {
         for (NodeType candidate : values()) {
@@ -55,10 +56,37 @@ public static NodeType fromName(final String name) {
         throw new IllegalArgumentException("Given string \"" + name + "\" is not the name of a NodeType.");
     }
 
-    // TODO: fromAnnotationType constructor with switch case
+    /**
+     * Creates a NodeType from an AnnotationType.
+     * <p>
+     * All AnnotationType variants except for 'Endif' are supported.
+     * There is no valid representation for 'Endif' annotations. Thus, the method throws an IllegalArgumentException
+     * if it is given an 'Endif'.
+     * </p>
+     *
+     * @param annotationType a variant of AnnotationType
+     * @return The NodeType that fits the given AnnotationType
+     */
+    public static NodeType fromAnnotationType(final AnnotationType annotationType) {
+        switch (annotationType) {
+            case If -> {
+                return NodeType.IF;
+            }
+            case Elif -> {
+                return NodeType.ELIF;
+            }
+            case Else -> {
+                return NodeType.ELSE;
+            }
+            case None -> {
+                return NodeType.ARTIFACT;
+            }
+            default -> throw new IllegalArgumentException(annotationType + "has no NodeType counterpart");
+        }
+    }
 
     /**
-     * Returns the number of bits required for storing {@link ordinal}.
+     * Returns the number of bits required for storing.
      */
     public static int getRequiredBitCount() {
         return 3;

src/main/java/org/variantsync/diffdetective/variation/diff/parse/VariationDiffParser.java

@@ -325,12 +325,7 @@ private void parseLine(
             lastArtifact.setToLine(toLine);
         } else {
             try {
-                NodeType nodeType;
-                if (annotationType == AnnotationType.None) {
-                    nodeType = NodeType.ARTIFACT;
-                } else {
-                    nodeType = NodeType.fromName(annotationType.name);
-                }
+                NodeType nodeType = NodeType.fromAnnotationType(annotationType);
 
                 DiffNode<DiffLinesLabel> newNode = new DiffNode<DiffLinesLabel>(
                         diffType,