refactor: Move the default DiffFilter into DiffFilter

Author: ibbem

src/main/java/org/variantsync/diffdetective/datasets/DatasetFactory.java

@@ -33,23 +33,6 @@ public class DatasetFactory {
      */
     public static final String PHP = "PHP";
 
-    /**
-     * Default value for diff filters.
-     * It disallows merge commits, only considers patches that modified files,
-     * and only allows source files of C/C++ projects ("h", "hpp", "c", "cpp").
-     */
-    public static final DiffFilter DEFAULT_DIFF_FILTER =
-            new DiffFilter.Builder()
-                    .allowMerge(false)
-                    .allowCommitsWithoutParents(false)
-                    .allowedChangeTypes(DiffEntry.ChangeType.MODIFY)
-                    .allowedFileExtensions("h", "hpp", "c", "cpp")
-                    .build();
-//    public static final DiffFilter PHP_DIFF_FILTER =
-//            new DiffFilter.Builder(DEFAULT_DIFF_FILTER)
-////                    .blockedPaths("ext/fileinfo/data_file.c")
-//                    .build();
-
     private final Path cloneDirectory;
 
     /**
@@ -69,10 +52,7 @@ public static DiffFilter getDefaultDiffFilterFor(final String repositoryName) {
         if (repositoryName.equalsIgnoreCase(MARLIN)) {
             return StanciulescuMarlin.DIFF_FILTER;
         }
-//        if (repositoryName.equalsIgnoreCase(PHP)) {
-//            return PHP_DIFF_FILTER;
-//        }
-        return DEFAULT_DIFF_FILTER;
+        return DiffFilter.DEFAULT_DIFF_FILTER;
     }
 
     /**

src/main/java/org/variantsync/diffdetective/diff/git/DiffFilter.java

@@ -27,6 +27,19 @@ public class DiffFilter {
             .allowAllFileExtensions()
             .build();
 
+    /**
+     * Default value for diff filters.
+     * It disallows merge commits, only considers patches that modified files,
+     * and only allows source files of C/C++ projects ("h", "hpp", "c", "cpp").
+     */
+    public static final DiffFilter DEFAULT_DIFF_FILTER =
+            new DiffFilter.Builder()
+                    .allowMerge(false)
+                    .allowCommitsWithoutParents(false)
+                    .allowedChangeTypes(DiffEntry.ChangeType.MODIFY)
+                    .allowedFileExtensions("h", "hpp", "c", "cpp")
+                    .build();
+
     /**
      * A list of allowed file extensions for patches.
      * When this list is not empty all file extension that it does not contain will be filtered.