fix: Manually move generated javadoc to docs/javadoc

The dependency update of the maven-javadoc-plugin in
afd65e1 removed the possibility to
define an alternative output directory for the generated javadoc which
resulted in a warning that I missed until now. This regression was
intentional and is declared as won't fix by upstream. See
apache/maven-javadoc-plugin#1194

Author: ibbem

default.nix

@@ -122,6 +122,7 @@ pkgs.stdenvNoCC.mkDerivation rec {
       if buildGitHubPages
       then ''
         mvn javadoc:javadoc
+        mv target/reports/apidocs docs/javadoc
         JEKYLL_ENV=production PAGES_REPO_NWO=VariantSync/DiffDetective JEKYLL_BUILD_REVISION= PAGES_DISABLE_NETWORK=1 github-pages build
         rm -rf _site/target
       ''

pom.xml

@@ -46,8 +46,6 @@
                 <artifactId>maven-javadoc-plugin</artifactId>
                 <version>3.11.2</version>
                 <configuration>
-                    <reportOutputDirectory>docs</reportOutputDirectory>
-                    <destDir>javadoc</destDir>
                     <show>private</show>
                     <quiet>true</quiet>
                 </configuration>