Skip to content

Commit 123c479

Browse files
committed
Use Set instead of Map<*, Boolean> in DiffTreeTraversal
1 parent 6c59ddd commit 123c479

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

src/main/java/org/variantsync/diffdetective/diff/difftree/traverse/DiffTreeTraversal.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
import org.variantsync.diffdetective.diff.difftree.DiffNode;
44
import org.variantsync.diffdetective.diff.difftree.DiffTree;
55

6-
import java.util.HashMap;
6+
import java.util.HashSet;
7+
import java.util.Set;
78
import java.util.function.Consumer;
89

910
/**
@@ -21,12 +22,12 @@
2122
* @author Paul Bittner
2223
*/
2324
public class DiffTreeTraversal {
24-
private final HashMap<Integer, Boolean> visited;
25+
private final Set<Integer> visited;
2526
private final DiffTreeVisitor visitor;
2627

2728
private DiffTreeTraversal(final DiffTreeVisitor visitor) {
2829
this.visitor = visitor;
29-
this.visited = new HashMap<>();
30+
this.visited = new HashSet<>();
3031
}
3132

3233
/**
@@ -85,11 +86,6 @@ public void visitChildrenOf(final DiffNode subtree) {
8586
* False if the node was already marked visited.
8687
*/
8788
public boolean markAsVisited(final DiffNode node) {
88-
final Integer id = node.getID();
89-
if (!visited.containsKey(id)) {
90-
visited.put(id, true);
91-
return true;
92-
}
93-
return false;
89+
return visited.add(node.getID());
9490
}
9591
}

0 commit comments

Comments
 (0)