refactor: DiffView::naive to produce raw text at last

Author: pmbittner

src/main/java/org/variantsync/diffdetective/variation/diff/view/DiffView.java

@@ -47,8 +47,12 @@ public static BiPredicate<Time, Projection> computeWhenNodesAreRelevant(final Di
         return (t, p) -> V.get(t).contains(p);
     }
 
-    public static DiffTree naive(final DiffTree d, final Query q, final String[] projectionViewText, final RawText[] text) throws IOException, DiffParseException {
+    public static DiffTree naive(final DiffTree d, final Query q, final String[] projectionViewText) throws IOException, DiffParseException {
 //        Logger.info("q = " + q);
+        final RawText[] text = new RawText[] {
+                new RawText(projectionViewText[Time.BEFORE.ordinal()].getBytes()),
+                new RawText(projectionViewText[Time.AFTER.ordinal()].getBytes())
+        };
 
         // MYERS or HISTOGRAM
         final DiffAlgorithm diffAlgorithm = DiffAlgorithm.getAlgorithm(DiffAlgorithm.SupportedAlgorithm.MYERS);
@@ -63,7 +67,6 @@ public static DiffTree naive(final DiffTree d, final Query q, final String[] pro
         {
             final ByteArrayOutputStream os = new ByteArrayOutputStream();
 
-
             /*
             Using our own formatter without diff headers (paired with a maximum context (?))
             caused the formatter to crash due to index out of bounds exceptions.
@@ -114,7 +117,6 @@ Using our own formatter without diff headers (paired with a maximum context (?))
 
     public static DiffTree naive(final DiffTree d, final Query q, final BiPredicate<Time, Projection> inView) throws IOException, DiffParseException {
         final String[] projectionViewText = new String[2];
-        final RawText[] text = new RawText[2];
 
         for (final Time t : Time.values()) {
             final int i = t.ordinal();
@@ -132,15 +134,13 @@ public static DiffTree naive(final DiffTree d, final Query q, final BiPredicate<
             final StringBuilder b = new StringBuilder();
             treeView.root().printSourceCode(b);
             projectionViewText[i] = b.toString();
-            text[i] = new RawText(projectionViewText[i].getBytes());
         }
 
-        return naive(d, q, projectionViewText, text);
+        return naive(d, q, projectionViewText);
     }
 
     public static DiffTree naive(final DiffTree d, final Query q) throws IOException, DiffParseException {
         final String[] projectionViewText = new String[2];
-        final RawText[] text = new RawText[2];
 
         for (final Time t : Time.values()) {
             final int i = t.ordinal();
@@ -156,9 +156,8 @@ public static DiffTree naive(final DiffTree d, final Query q) throws IOException
             final StringBuilder b = new StringBuilder();
             projection.root().printSourceCode(b);
             projectionViewText[i] = b.toString();
-            text[i] = new RawText(projectionViewText[i].getBytes());
         }
-        return naive(d, q, projectionViewText, text);
+        return naive(d, q, projectionViewText);
     }
 
     public static DiffTree badgood(final DiffTree d, final Query q) {