Skip to content

Commit 136f35b

Browse files
authored
fix extensions processing android (#43)
* fix: extension processing on android
1 parent ab51721 commit 136f35b

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

android/src/main/java/com/fileviewerturbo/FileViewerTurboModule.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ class FileViewerTurboModule(reactContext: ReactApplicationContext) :
7070
return
7171
}
7272

73-
val extension = MimeTypeMap.getFileExtensionFromUrl(path).lowercase()
73+
val extension = MimeTypeMap.getFileExtensionFromUrl(Uri.encode(path)).lowercase()
7474
val mimeType = MimeTypeMap.getSingleton().getMimeTypeFromExtension(extension)
7575

7676
val shareIntent = Intent().apply {

example/src/App.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import { useState } from 'react';
2-
import { View, StyleSheet, Button, ActivityIndicator } from 'react-native';
2+
import { ActivityIndicator, Button, StyleSheet, View } from 'react-native';
33
import {
44
DocumentDirectoryPath,
55
downloadFile,
66
} from '@dr.pogodin/react-native-fs';
77
import { open } from 'react-native-file-viewer-turbo';
8+
import { DoneButtonPosition } from '../../src/NativeFileViewerTurbo';
89

910
function getUrlExtension(url: string) {
1011
return url.split(/[#?]/)[0]?.split('.').pop()?.trim() ?? '';
@@ -39,7 +40,7 @@ export default function App() {
3940
await open(localFile, {
4041
onDismiss: () => console.log('dismissed!'),
4142
doneButtonTitle: 'Custom done',
42-
doneButtonPosition: 'right',
43+
doneButtonPosition: DoneButtonPosition.right,
4344
});
4445
} catch (error) {
4546
console.error(error);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-file-viewer-turbo",
3-
"version": "0.7.4",
3+
"version": "0.7.5",
44
"description": "Native file viewer for react-native - now with TurboModules support",
55
"source": "./src/index.tsx",
66
"main": "./lib/commonjs/index.js",

src/NativeFileViewerTurbo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { EventEmitter } from 'react-native/Libraries/Types/CodegenTypes';
33

44
export enum DoneButtonPosition {
55
left = 'left',
6-
right = 'right'
6+
right = 'right',
77
}
88

99
export type Options = {

0 commit comments

Comments
 (0)