Explicitly scope the fixtures

Contravenes PT003 but "Explicit is better than implicit."

Co-authored-by: Paddy Roddy <[email protected]>

Author: samcunliffe

tests/conftest.py

@@ -7,7 +7,7 @@
 import pytest
 
 
-@pytest.fixture
+@pytest.fixture(scope="function")  # noqa: PT003
 def default_config() -> dict[str, str]:
     """
     Get the minimal default configuration for cutting a cookie in tests.
@@ -22,19 +22,19 @@ def default_config() -> dict[str, str]:
     }
 
 
-@pytest.fixture
+@pytest.fixture(scope="function")  # noqa: PT003
 def default_config_with(default_config: dict[str, str]) -> typing.Callable:
     """Extend or modify the default configuration with one additional value."""
 
-    def _wrapped_with(**kwargs: str) -> dict[str, str]:
-        return default_config | kwargs
+    def _wrapped_with(key: str, value: str) -> dict[str, str]:
+        default_config[key] = value
+        return default_config
 
     return _wrapped_with
 
 
 def _generate_package(
-    config: dict[str, str],
-    path: pathlib.Path,
+    config: dict[str, str], path: pathlib.Path
 ) -> tuple[subprocess.CompletedProcess[str], pathlib.Path]:
     """
     Generate a project from the cookiecutter template.
@@ -66,8 +66,7 @@ def _generate_package(
 
 @pytest.fixture
 def generate_package(
-    default_config: dict[str, str],
-    tmp_path: pathlib.Path,
+    default_config: dict[str, str], tmp_path: pathlib.Path
 ) -> typing.Callable:
     """Generate project from cookiecutter template."""