Dates comparison by isDataEqual

[cherniavskii]

Hi :)

In 1.3.0 deepEqual is used for data comparison.

I've noticed that Date objects are not properly compared, since comparing two different dates always returns true.
While this is edge case and APIs always return serialized data, I wonder if this should be fixed.

Theoretically, queryFn can return virtually anything and doesn't have to use any API at all.

What do you think?

[tannerlinsley]

I think dates are a safe one to include, mostly because json.parse will sometimes auto create dates from strings

[cherniavskii]

What do you think about adding fast-deep-equal as dependency?
There's 4 additional lines of code in original fast-deep-equal, and dates support is one of them.
Also, we wouldn't need to write tests for it

[tannerlinsley]

How about we inline it instead. Saves .2kb ;)

…

On May 2, 2020, 6:57 AM -0600, Andrew Cherniavskii ***@***.***>, wrote: What do you think about adding fast-deep-equal as dependency? There's 4 additional lines of code in original fast-deep-equal, and dates support is one of them. Also, we wouldn't need to write tests for it — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.