refactor(P060): drop dead loadDocument, derive ClientToolName, clean comments

- Remove unused bridge.loadDocument + LoadDocumentInput + 'LOAD_DOCUMENT'
  from BridgeRequestType + matching arm in getRequestTimeoutMs. The
  copilot demo loads documents via URL params, never via postMessage —
  the method had no callers.
- Derive ClientToolName from `keyof typeof LLM_STATIC_TOOLS | 'submit' |
  'download'`. Drop the redundant CLIENT_TOOL_NAMES array. isClientToolName
  uses a derived ReadonlySet for the runtime guard. CLIENT_TOOL_NAMES is
  no longer exported from the barrel (it was internal only).
- Stale "LLM dispatcher" comment wording → "LLM tool registry" (dispatch.ts
  has been gone for a while).

Author: bendersej

copilot/src/lib/embed-bridge-adapters/client-tools/factory.ts

@@ -28,8 +28,8 @@ export type ClientTools = {
   // the consumer boundary; the Vercel AI SDK guarantees the LLM only fires
   // registered tools.
   execute: (toolName: ClientToolName, input: ToolInput) => Promise<BridgeResult<unknown>>
-  // Type guard re-export so the consumer can branch on tool names without
-  // importing `tools.ts` separately.
+  // Type guard re-export so the consumer can branch on LLM tool names
+  // without importing `tools.ts` separately.
   isClientToolName: typeof isClientToolName
 }
 

copilot/src/lib/embed-bridge-adapters/client-tools/index.ts

@@ -5,4 +5,4 @@ export { FINALISATION_ACTION, FINALISATION_TOOL, withFinalisationTool } from './
 export type { MiddlewareContext, ToolMiddleware } from './middleware'
 export { composeMiddleware } from './middleware'
 export type { ClientToolName } from './tools'
-export { CLIENT_TOOL_NAMES, isClientToolName, LLM_STATIC_TOOLS } from './tools'
+export { isClientToolName, LLM_STATIC_TOOLS } from './tools'

copilot/src/lib/embed-bridge-adapters/client-tools/tools.ts

@@ -19,10 +19,9 @@ import {
 // name, and pulls each description verbatim from the bridge schema's
 // `.describe()` — no duplicated text.
 //
-// Adding a new LLM tool: add an entry to LLM_STATIC_TOOLS, add the snake
-// name to CLIENT_TOOL_NAMES, add a switch arm in factory.ts. The switch
-// is exhaustive over ClientToolName, so any addition forces a matching
-// arm at compile time.
+// Adding an LLM tool: add an entry to LLM_STATIC_TOOLS, add a switch arm
+// in factory.ts. The switch is exhaustive over ClientToolName, so any
+// addition forces a matching arm at compile time.
 
 const tool = <TSchema extends z.ZodType>(inputSchema: TSchema): { description: string; inputSchema: TSchema } => ({
   description: inputSchema.description ?? '',
@@ -43,23 +42,17 @@ export const LLM_STATIC_TOOLS = {
   rotate_page: tool(RotatePageInput),
 } as const
 
-export const CLIENT_TOOL_NAMES = [
-  'get_fields',
-  'get_document_content',
-  'detect_fields',
-  'delete_fields',
-  'select_tool',
-  'set_field_value',
-  'focus_field',
-  'go_to_page',
-  'move_page',
-  'delete_pages',
-  'rotate_page',
+// Finalisation tools (submit / download) are mode-gated and merged in via
+// `withFinalisationTool` rather than living in LLM_STATIC_TOOLS, so the
+// type union covers both.
+type FinalisationToolName = 'submit' | 'download'
+export type ClientToolName = keyof typeof LLM_STATIC_TOOLS | FinalisationToolName
+
+const ALL_CLIENT_TOOL_NAMES: ReadonlySet<string> = new Set<ClientToolName>([
+  ...(Object.keys(LLM_STATIC_TOOLS) as Array<keyof typeof LLM_STATIC_TOOLS>),
   'submit',
   'download',
-] as const
-
-export type ClientToolName = (typeof CLIENT_TOOL_NAMES)[number]
+])
 
 export const isClientToolName = (value: unknown): value is ClientToolName =>
-  typeof value === 'string' && CLIENT_TOOL_NAMES.some((candidate) => candidate === value)
+  typeof value === 'string' && ALL_CLIENT_TOOL_NAMES.has(value)

copilot/src/lib/embed-bridge/bridge.ts

@@ -6,7 +6,6 @@ import {
   FocusFieldInput,
   GetDocumentContentInput,
   GoToInput,
-  LoadDocumentInput,
   MovePageInput,
   RotatePageInput,
   SelectToolInput,
@@ -52,7 +51,6 @@ const getRequestTimeoutMs = (requestType: BridgeRequestType): number => {
     case 'GET_FIELDS':
     case 'DOWNLOAD':
     case 'GO_TO':
-    case 'LOAD_DOCUMENT':
     case 'MOVE_PAGE':
     case 'ROTATE_PAGE':
     case 'SELECT_TOOL':
@@ -385,7 +383,7 @@ export const createBridge = ({
 
   // The bridge OWNS validation: each method validates its `unknown` input
   // against the schema in schemas.ts before posting to the iframe. The
-  // adapter layer (LLM dispatcher, React SDK, etc.) is therefore a pure
+  // adapter layer (LLM tool registry, React SDK, etc.) is therefore a pure
   // router — no parse, no narrowing. Adding a new method = add a schema in
   // schemas.ts, add a method on IframeBridge, and add a `parseAndSend` line
   // here.
@@ -405,7 +403,6 @@ export const createBridge = ({
   }
   const bridge: IframeBridge = {
     getState: () => state,
-    loadDocument: (args) => parseAndSend(LoadDocumentInput, 'LOAD_DOCUMENT', args),
     getFields: () => sendRequest<{ fields: FieldRecord[] }>('GET_FIELDS', {}),
     getDocumentContent: (args) => parseAndSend<typeof GetDocumentContentInput, DocumentContentResult>(
       GetDocumentContentInput,

copilot/src/lib/embed-bridge/index.ts

@@ -11,7 +11,6 @@ export {
   GetDocumentContentInput,
   GetFieldsInput,
   GoToInput,
-  LoadDocumentInput,
   MovePageInput,
   NoInput,
   RotatePageInput,

copilot/src/lib/embed-bridge/schemas.ts

@@ -98,11 +98,3 @@ export const SubmitInput = z
 export const DownloadInput = NoInput.describe(
   'Finalizes the filled PDF and triggers an in-browser download for the user. Use only when the user asks to download.',
 )
-
-export const LoadDocumentInput = z
-  .object({
-    data_url: z.string(),
-    name: z.string().optional(),
-    page: z.number().int().positive().optional(),
-  })
-  .describe('Loads a PDF document into the editor by URL or data-URL.')

copilot/src/lib/embed-bridge/types.ts

@@ -74,7 +74,6 @@ export type BridgeState =
 // Request type union. Every postMessage the bridge sends carries one of these
 // as its `type` field. The editor honours each.
 export type BridgeRequestType =
-  | 'LOAD_DOCUMENT'
   | 'GO_TO'
   | 'SELECT_TOOL'
   | 'DETECT_FIELDS'
@@ -92,14 +91,13 @@ export type BridgeRequestType =
 export type FocusFieldResult = { hint: { type: 'user_action_expected'; message: string } } | null
 
 // The bridge owns the contract. Each method takes `unknown` (raw, from any
-// caller — the LLM dispatcher, direct UI code, etc.) and validates it
-// internally against the matching Zod schema in schemas.ts before posting
-// to the iframe. Bad input surfaces as `{ success: false, error: { code:
-// 'bad_input', ... } }` without a postMessage round-trip. Adapters do not
+// caller) and validates it internally against the matching Zod schema in
+// schemas.ts before posting to the iframe. Bad input surfaces as
+// `{ success: false, error: { code: 'bad_input', ... } }` without a
+// postMessage round-trip. Adapters (LLM tool registry, etc.) do not
 // re-validate.
 export type IframeBridge = {
   getState: () => BridgeState
-  loadDocument: (args: unknown) => Promise<BridgeResult>
   getFields: () => Promise<BridgeResult<{ fields: FieldRecord[] }>>
   getDocumentContent: (args: unknown) => Promise<BridgeResult<DocumentContentResult>>
   detectFields: () => Promise<BridgeResult<{ detected_count: number }>>