refactor(P060): collapse client-tools/schemas.ts into tools.ts

The tool-name registry (CLIENT_TOOL_NAMES, ClientToolName,
isClientToolName) lived next to the LLM_STATIC_TOOLS map but in a
separate file for no real reason. Merging both into tools.ts puts every
LLM-tool decision (which schema, which name, the runtime guard) in one
place. Adding a tool now touches one file in the adapter (tools.ts) +
one switch arm in factory.ts.

Author: bendersej

copilot/src/lib/embed-bridge-adapters/client-tools/factory.ts

@@ -12,7 +12,7 @@ import {
   SetFieldValueInput,
 } from '../../embed-bridge'
 import { composeMiddleware, type ToolMiddleware } from './middleware'
-import { type ClientToolName, isClientToolName } from './schemas'
+import { type ClientToolName, isClientToolName } from './tools'
 
 export type ToolInput = Record<string, unknown>
 

copilot/src/lib/embed-bridge-adapters/client-tools/index.ts

@@ -4,6 +4,5 @@ export type { FinalisationAction, FinalisationToolMap } from './finalisation'
 export { FINALISATION_ACTION, FINALISATION_TOOL, withFinalisationTool } from './finalisation'
 export type { MiddlewareContext, ToolMiddleware } from './middleware'
 export { composeMiddleware } from './middleware'
-export type { ClientToolName } from './schemas'
-export { CLIENT_TOOL_NAMES, isClientToolName } from './schemas'
-export { LLM_STATIC_TOOLS } from './tools'
+export type { ClientToolName } from './tools'
+export { CLIENT_TOOL_NAMES, isClientToolName, LLM_STATIC_TOOLS } from './tools'

copilot/src/lib/embed-bridge-adapters/client-tools/middleware.ts

@@ -1,6 +1,6 @@
 import type { BridgeResult } from '../../embed-bridge'
 import type { ToolInput } from './factory'
-import type { ClientToolName } from './schemas'
+import type { ClientToolName } from './tools'
 
 // Onion-style middleware. Each layer receives a context (tool name + input)
 // and `next()` which triggers the inner dispatcher. Layers can short-circuit

copilot/src/lib/embed-bridge-adapters/client-tools/schemas.ts

@@ -13,11 +13,17 @@ import {
   SetFieldValueInput,
 } from '../../embed-bridge'
 
-// LLM tool registration map. Each entry pulls its description verbatim
-// from the bridge schema's `.describe()` — no duplication. Spread into
-// streamText({ tools: withFinalisationTool(LLM_STATIC_TOOLS) }) on both
-// the /api/chat and BYOK paths. Adding a new LLM tool is one line here +
-// one switch arm in `factory.ts`.
+// LLM-tool adapter for the bridge. The bridge owns the schemas (with
+// descriptions) in embed-bridge/schemas.ts; this file enumerates which
+// bridge operations are exposed to the LLM, under which snake_case tool
+// name, and pulls each description verbatim from the bridge schema's
+// `.describe()` — no duplicated text.
+//
+// Adding a new LLM tool: add an entry to LLM_STATIC_TOOLS, add the snake
+// name to CLIENT_TOOL_NAMES, add a switch arm in factory.ts. The switch
+// is exhaustive over ClientToolName, so any addition forces a matching
+// arm at compile time.
+
 const tool = <TSchema extends z.ZodType>(inputSchema: TSchema): { description: string; inputSchema: TSchema } => ({
   description: inputSchema.description ?? '',
   inputSchema,
@@ -36,3 +42,24 @@ export const LLM_STATIC_TOOLS = {
   delete_pages: tool(DeletePagesInput),
   rotate_page: tool(RotatePageInput),
 } as const
+
+export const CLIENT_TOOL_NAMES = [
+  'get_fields',
+  'get_document_content',
+  'detect_fields',
+  'delete_fields',
+  'select_tool',
+  'set_field_value',
+  'focus_field',
+  'go_to_page',
+  'move_page',
+  'delete_pages',
+  'rotate_page',
+  'submit',
+  'download',
+] as const
+
+export type ClientToolName = (typeof CLIENT_TOOL_NAMES)[number]
+
+export const isClientToolName = (value: unknown): value is ClientToolName =>
+  typeof value === 'string' && CLIENT_TOOL_NAMES.some((candidate) => candidate === value)