Skip to content

Commit 23b49bc

Browse files
committed
support esr 115
1 parent 3266675 commit 23b49bc

3 files changed

Lines changed: 31 additions & 4 deletions

File tree

src/main/java/org/openqa/selenium/htmlunit/BrowserVersionDeterminer.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,7 @@ else if (browserName.equalsIgnoreCase(BrowserVersion.FIREFOX.getNickname())
8181
else {
8282
try {
8383
final int version = Integer.parseInt(browserVersion);
84-
if (version == 78 || version == 91) {
85-
browserVersionObject = BrowserVersion.FIREFOX_ESR;
86-
}
87-
else if (version == BrowserVersion.FIREFOX_ESR.getBrowserVersionNumeric()) {
84+
if (version == 78 || version == 91 || version == 102 || version == 115) {
8885
browserVersionObject = BrowserVersion.FIREFOX_ESR;
8986
}
9087
else if (version == BrowserVersion.FIREFOX.getBrowserVersionNumeric()) {

src/test/java/org/openqa/selenium/htmlunit/HtmlUnitCapabilitiesTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,14 @@ public void configurationOfFirefox102ViaRemote() {
9292
assertEquals(FIREFOX_ESR, BrowserVersionDeterminer.determine(firefoxCapabilities));
9393
}
9494

95+
@Test
96+
public void configurationOfFirefox115ViaRemote() {
97+
final DesiredCapabilities firefoxCapabilities =
98+
new DesiredCapabilities(Browser.HTMLUNIT.browserName(), "firefox-115",
99+
Platform.ANY);
100+
assertEquals(FIREFOX_ESR, BrowserVersionDeterminer.determine(firefoxCapabilities));
101+
}
102+
95103
@Test
96104
public void configurationOfFirefoxEsrViaRemote() {
97105
final DesiredCapabilities firefoxCapabilities =

src/test/java/org/openqa/selenium/htmlunit/HtmlUnitDriverTest.java

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,17 @@ protected WebClient modifyWebClient(final WebClient client) {
311311
}
312312
};
313313

314+
capabilities = new DesiredCapabilities(Browser.HTMLUNIT.browserName(), "firefox-115", Platform.ANY);
315+
316+
new HtmlUnitDriver(capabilities) {
317+
@Override
318+
protected WebClient modifyWebClient(final WebClient client) {
319+
assertEquals(BrowserVersion.FIREFOX_ESR, client.getBrowserVersion());
320+
321+
return client;
322+
}
323+
};
324+
314325
capabilities = new DesiredCapabilities(Browser.HTMLUNIT.browserName(), "firefox-esr", Platform.ANY);
315326

316327
new HtmlUnitDriver(capabilities) {
@@ -394,6 +405,17 @@ protected WebClient modifyWebClient(final WebClient client) {
394405
}
395406
};
396407

408+
capabilities = new DesiredCapabilities(Browser.HTMLUNIT.browserName(), "firefox-115", Platform.ANY);
409+
410+
new HtmlUnitDriver(capabilities) {
411+
@Override
412+
protected WebClient modifyWebClient(final WebClient client) {
413+
assertEquals(BrowserVersion.FIREFOX_ESR, client.getBrowserVersion());
414+
415+
return client;
416+
}
417+
};
418+
397419
capabilities = new DesiredCapabilities(Browser.HTMLUNIT.browserName(), "firefox-esr", Platform.ANY);
398420

399421
new HtmlUnitDriver(capabilities) {

0 commit comments

Comments
 (0)