Skip to content

Commit 63892a6

Browse files
DrFaust92claude
andcommitted
chart(feature): add support for revisionHistoryLimit and dnsConfig
Expose Deployment revisionHistoryLimit and pod dnsPolicy/dnsConfig across all Selenium Grid components (hub, router, distributor, event bus, session map, session queue, and chrome/edge/firefox nodes including KEDA ScaledJob pods). Values can be set globally via global.seleniumGrid.{revisionHistoryLimit,dnsPolicy,dnsConfig} and overridden per component, mirroring the existing affinity pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 3433334 commit 63892a6

11 files changed

Lines changed: 124 additions & 6 deletions

charts/selenium-grid/templates/_helpers.tpl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -514,6 +514,13 @@ template:
514514
{{- with .node.affinity }}
515515
affinity: {{- toYaml . | nindent 6 }}
516516
{{- end }}
517+
{{- if or $.Values.global.seleniumGrid.dnsPolicy .node.dnsPolicy }}
518+
dnsPolicy: {{ default $.Values.global.seleniumGrid.dnsPolicy .node.dnsPolicy }}
519+
{{- end }}
520+
{{- if or $.Values.global.seleniumGrid.dnsConfig .node.dnsConfig }}
521+
{{- $dnsConfigYaml := default $.Values.global.seleniumGrid.dnsConfig .node.dnsConfig }}
522+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 6 }}
523+
{{- end }}
517524
{{- with .node.tolerations }}
518525
tolerations:
519526
{{ toYaml . | nindent 4 }}

charts/selenium-grid/templates/chrome-node-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ spec:
1818
{{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
1919
replicas: {{ .Values.chromeNode.replicas }}
2020
{{end}}
21+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.chromeNode.revisionHistoryLimit }}
2122
selector:
2223
matchLabels:
2324
app: {{ template "seleniumGrid.chromeNode.fullname" . }}

charts/selenium-grid/templates/distributor-deployment.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.components.distributor.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.distributor.fullname" . }}
@@ -170,7 +171,14 @@ spec:
170171
{{- if or .Values.global.seleniumGrid.affinity .Values.components.distributor.affinity }}
171172
{{- $affinityYaml := default .Values.global.seleniumGrid.affinity .Values.components.distributor.affinity }}
172173
affinity: {{- toYaml $affinityYaml | nindent 8 }}
173-
{{- end }}
174+
{{- end }}
175+
{{- if or .Values.global.seleniumGrid.dnsPolicy .Values.components.distributor.dnsPolicy }}
176+
dnsPolicy: {{ default .Values.global.seleniumGrid.dnsPolicy .Values.components.distributor.dnsPolicy }}
177+
{{- end }}
178+
{{- if or .Values.global.seleniumGrid.dnsConfig .Values.components.distributor.dnsConfig }}
179+
{{- $dnsConfigYaml := default .Values.global.seleniumGrid.dnsConfig .Values.components.distributor.dnsConfig }}
180+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 8 }}
181+
{{- end }}
174182
{{- with .Values.components.distributor.tolerations }}
175183
tolerations: {{ toYaml . | nindent 6 }}
176184
{{- end }}

charts/selenium-grid/templates/edge-node-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ spec:
1818
{{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
1919
replicas: {{ .Values.edgeNode.replicas }}
2020
{{end}}
21+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.edgeNode.revisionHistoryLimit }}
2122
selector:
2223
matchLabels:
2324
app: {{ template "seleniumGrid.edgeNode.fullname" . }}

charts/selenium-grid/templates/event-bus-deployment.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.components.eventBus.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.eventBus.fullname" . }}
@@ -81,7 +82,14 @@ spec:
8182
{{- if or .Values.global.seleniumGrid.affinity .Values.components.eventBus.affinity }}
8283
{{- $affinityYaml := default .Values.global.seleniumGrid.affinity .Values.components.eventBus.affinity }}
8384
affinity: {{- toYaml $affinityYaml | nindent 8 }}
84-
{{- end }}
85+
{{- end }}
86+
{{- if or .Values.global.seleniumGrid.dnsPolicy .Values.components.eventBus.dnsPolicy }}
87+
dnsPolicy: {{ default .Values.global.seleniumGrid.dnsPolicy .Values.components.eventBus.dnsPolicy }}
88+
{{- end }}
89+
{{- if or .Values.global.seleniumGrid.dnsConfig .Values.components.eventBus.dnsConfig }}
90+
{{- $dnsConfigYaml := default .Values.global.seleniumGrid.dnsConfig .Values.components.eventBus.dnsConfig }}
91+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 8 }}
92+
{{- end }}
8593
{{- with .Values.components.eventBus.tolerations }}
8694
tolerations: {{ toYaml . | nindent 6 }}
8795
{{- end }}

charts/selenium-grid/templates/firefox-node-deployment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ spec:
1818
{{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
1919
replicas: {{ .Values.firefoxNode.replicas }}
2020
{{end}}
21+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.firefoxNode.revisionHistoryLimit }}
2122
selector:
2223
matchLabels:
2324
app: {{ template "seleniumGrid.firefoxNode.fullname" . }}

charts/selenium-grid/templates/hub-deployment.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ metadata:
1616
{{- end }}
1717
spec:
1818
replicas: 1
19+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.hub.revisionHistoryLimit }}
1920
selector:
2021
matchLabels:
2122
app: {{ template "seleniumGrid.hub.fullname" . }}
@@ -170,7 +171,14 @@ spec:
170171
{{- if or .Values.global.seleniumGrid.affinity .Values.hub.affinity }}
171172
{{- $affinityYaml := default .Values.global.seleniumGrid.affinity .Values.hub.affinity }}
172173
affinity: {{- toYaml $affinityYaml | nindent 8 }}
173-
{{- end }}
174+
{{- end }}
175+
{{- if or .Values.global.seleniumGrid.dnsPolicy .Values.hub.dnsPolicy }}
176+
dnsPolicy: {{ default .Values.global.seleniumGrid.dnsPolicy .Values.hub.dnsPolicy }}
177+
{{- end }}
178+
{{- if or .Values.global.seleniumGrid.dnsConfig .Values.hub.dnsConfig }}
179+
{{- $dnsConfigYaml := default .Values.global.seleniumGrid.dnsConfig .Values.hub.dnsConfig }}
180+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 8 }}
181+
{{- end }}
174182
{{- with .Values.hub.tolerations }}
175183
tolerations: {{ toYaml . | nindent 6 }}
176184
{{- end }}

charts/selenium-grid/templates/router-deployment.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.components.router.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.router.fullname" . }}
@@ -154,7 +155,14 @@ spec:
154155
{{- if or .Values.global.seleniumGrid.affinity .Values.components.router.affinity }}
155156
{{- $affinityYaml := default .Values.global.seleniumGrid.affinity .Values.components.router.affinity }}
156157
affinity: {{- toYaml $affinityYaml | nindent 8 }}
157-
{{- end }}
158+
{{- end }}
159+
{{- if or .Values.global.seleniumGrid.dnsPolicy .Values.components.router.dnsPolicy }}
160+
dnsPolicy: {{ default .Values.global.seleniumGrid.dnsPolicy .Values.components.router.dnsPolicy }}
161+
{{- end }}
162+
{{- if or .Values.global.seleniumGrid.dnsConfig .Values.components.router.dnsConfig }}
163+
{{- $dnsConfigYaml := default .Values.global.seleniumGrid.dnsConfig .Values.components.router.dnsConfig }}
164+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 8 }}
165+
{{- end }}
158166
{{- with .Values.components.router.tolerations }}
159167
tolerations: {{ toYaml . | nindent 6 }}
160168
{{- end }}

charts/selenium-grid/templates/session-map-deployment.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.components.sessionMap.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.sessionMap.fullname" . }}
@@ -80,7 +81,14 @@ spec:
8081
{{- if or .Values.global.seleniumGrid.affinity .Values.components.sessionMap.affinity }}
8182
{{- $affinityYaml := default .Values.global.seleniumGrid.affinity .Values.components.sessionMap.affinity }}
8283
affinity: {{- toYaml $affinityYaml | nindent 8 }}
83-
{{- end }}
84+
{{- end }}
85+
{{- if or .Values.global.seleniumGrid.dnsPolicy .Values.components.sessionMap.dnsPolicy }}
86+
dnsPolicy: {{ default .Values.global.seleniumGrid.dnsPolicy .Values.components.sessionMap.dnsPolicy }}
87+
{{- end }}
88+
{{- if or .Values.global.seleniumGrid.dnsConfig .Values.components.sessionMap.dnsConfig }}
89+
{{- $dnsConfigYaml := default .Values.global.seleniumGrid.dnsConfig .Values.components.sessionMap.dnsConfig }}
90+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 8 }}
91+
{{- end }}
8492
{{- with .Values.components.sessionMap.tolerations }}
8593
tolerations: {{ toYaml . | nindent 6 }}
8694
{{- end }}

charts/selenium-grid/templates/session-queue-deployment.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ metadata:
1313
{{- end }}
1414
spec:
1515
replicas: 1
16+
revisionHistoryLimit: {{ default .Values.global.seleniumGrid.revisionHistoryLimit .Values.components.sessionQueue.revisionHistoryLimit }}
1617
selector:
1718
matchLabels:
1819
app: {{ template "seleniumGrid.sessionQueue.fullname" . }}
@@ -77,7 +78,14 @@ spec:
7778
{{- if or .Values.global.seleniumGrid.affinity .Values.components.sessionQueue.affinity }}
7879
{{- $affinityYaml := default .Values.global.seleniumGrid.affinity .Values.components.sessionQueue.affinity }}
7980
affinity: {{- toYaml $affinityYaml | nindent 8 }}
80-
{{- end }}
81+
{{- end }}
82+
{{- if or .Values.global.seleniumGrid.dnsPolicy .Values.components.sessionQueue.dnsPolicy }}
83+
dnsPolicy: {{ default .Values.global.seleniumGrid.dnsPolicy .Values.components.sessionQueue.dnsPolicy }}
84+
{{- end }}
85+
{{- if or .Values.global.seleniumGrid.dnsConfig .Values.components.sessionQueue.dnsConfig }}
86+
{{- $dnsConfigYaml := default .Values.global.seleniumGrid.dnsConfig .Values.components.sessionQueue.dnsConfig }}
87+
dnsConfig: {{- toYaml $dnsConfigYaml | nindent 8 }}
88+
{{- end }}
8189
{{- with .Values.components.sessionQueue.tolerations }}
8290
tolerations: {{ toYaml . | nindent 6 }}
8391
{{- end }}

0 commit comments

Comments
 (0)