Merge pull request #337 from mjsheikh/generalbc

GeneralBC

Author: ChrisRackauckas

src/derivative_operators/bc_operators.jl

@@ -117,11 +117,11 @@ struct GeneralBC{T, L<:AbstractVector{T}, R<:AbstractVector{T}} <:AffineBC{T}
         S_r = zeros(T, (nr-2, order+nr-2))
 
         for i in 1:(nl-2)
-            S_l[i,:] = [transpose(calculate_weights(i, one(T), Array(one(T):convert(T, order+i)))) transpose(zeros(T, Int(nl-2-i)))]./(dx_l.^i)
+            S_l[i,:] = [transpose(calculate_weights(i, one(T), Array(one(T):convert(T, order+i)))) transpose(zeros(T, Int(nl-2-i)))]./transpose(dx_l.^i)
         end
 
         for i in 1:(nr-2)
-            S_r[i,:] = [transpose(calculate_weights(i, convert(T, order+i), Array(one(T):convert(T, order+i)))) transpose(zeros(T, Int(nr-2-i)))]./(dx_r.^i)
+            S_r[i,:] = [transpose(calculate_weights(i, convert(T, order+i), Array(one(T):convert(T, order+i)))) transpose(zeros(T, Int(nr-2-i)))]./transpose(dx_r.^i)
         end
         s0_l = S_l[:,1] ; Sl = S_l[:,2:end]
         s0_r = S_r[:,end] ; Sr = S_r[:,(end-1):-1:1]

test/robin.jl

@@ -92,15 +92,20 @@ end
 u0 = -4/10
 uend = 125/12
 u = Vector(1.0:10.0)
+h = ones(10)                                               # Vector step
 Q = RobinBC((1.0, 6.0, 10.0), (1.0, 6.0, 10.0), 1.0, 3)
 urobinextended = Q*u
 @test urobinextended.l ≈ u0
 @test urobinextended.r ≈ uend
 # General BC should be equivalent
 G = GeneralBC([-10.0, 1.0, 6.0], [-10.0, 1.0, 6.0], 1.0, 3)
+G2 = GeneralBC([-10.0, 1.0, 6.0], [-10.0, 1.0, 6.0], h, 3) # Operator for Vector step
+
 ugeneralextended = G*u
+ugeneralextended2 = G2*u
 @test ugeneralextended.l ≈ u0
 @test ugeneralextended.r ≈ uend
-
+@test ugeneralextended2.l ≈ u0
+@test ugeneralextended2.r ≈ uend
 
 #TODO: Implement tests for BC's that are contingent on the sign of the coefficient on the operator near the boundary